New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 855186 link

Starred by 2 users
Status: Assigned
Owner:
█ manasverma@google.com
Last visit > 30 days ago
Cc:
mahmadi@chromium.org
█ manasverma@google.com
jsaul@google.com
ma...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Sign-in/Sync after local credit card save (Implementation bug)

Project Member Reported by jsaul@google.com, Jun 21 2018 
This is the implementation bug for the "Sign-in and sync after local credit card save" project.

Launch bug at http://crbug.com/855182.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4f37ecdd97025d21e06f38be285ede6e4de5f03

commit c4f37ecdd97025d21e06f38be285ede6e4de5f03
Author: Jared Saul <jsaul@google.com>
Date: Fri Jul 20 03:28:53 2018

[Autofill] Show Sign-in/Sync promo after saving a card locally and Manage Cards bubble.

A sign-in promo pops up right after a card is saved locally. This also introduces
a "Manage cards" bubble, with a footnote of a sign-in promo.

An organized list of the diffs --
    https://screenshot.googleplex.com/kMBPkpWZYsq.png

A rough doc I quickly put together of the changes in this CL --
    https://docs.google.com/document/d/1DarGyLBDSBWcsumcxhpojuvugUTUU6r5j6uI0RZZAo0/edit?usp=sharing

Here are different screenshots explaining why we chose to have the promo not display a title --
Using promo's title (The string isn't updated in this screenshot):
    https://screenshot.googleplex.com/kiYnAynyedD
Empty promo title, using main bubble title:
    https://screenshot.googleplex.com/rT3F9RETsgq
No promo title, using main bubble title:
    https://screenshot.googleplex.com/nMXOdNvysbR

This is what the mocks were like (with the old UI):
    https://screenshot.googleplex.com/AhXfxONG0sO


Additionally, this is what the sync promo looks like:
    https://screenshot.googleplex.com/J3huQ06Y5X8
Sign-in promo on the Manage Cards view:
    https://screenshot.googleplex.com/MJqf5Fbhnpa
Sync promo on the Manage Cards view:
    https://screenshot.googleplex.com/cNLy78Ts80k


Metrics, additional browser tests, and omnibox icon animation to follow.

Bug: 855186
Change-Id: I74ecdd802da960120baacfdd771c90cb126fbd10
Reviewed-on: https://chromium-review.googlesource.com/1134514
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#576769}
[modify] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/chrome/browser/about_flags.cc
[modify] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
[modify] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/chrome/browser/ui/autofill/save_card_bubble_controller_impl_browsertest.cc
[modify] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
[add] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/chrome/browser/ui/autofill/save_card_ui.h
[modify] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/chrome/browser/ui/views/autofill/dialog_view_ids.h
[modify] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
[modify] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/chrome/browser/ui/views/autofill/save_card_bubble_views.h
[modify] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
[modify] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc
[add] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/chrome/browser/ui/views/autofill/save_card_manage_cards_bubble_views.cc
[add] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/chrome/browser/ui/views/autofill/save_card_manage_cards_bubble_views.h
[add] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/chrome/browser/ui/views/autofill/save_card_offer_bubble_views.cc
[add] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/chrome/browser/ui/views/autofill/save_card_offer_bubble_views.h
[add] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/chrome/browser/ui/views/autofill/save_card_sign_in_promo_bubble_views.cc
[add] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/chrome/browser/ui/views/autofill/save_card_sign_in_promo_bubble_views.h
[modify] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/chrome/browser/ui/views/sync/dice_bubble_sync_promo_view.cc
[modify] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/chrome/browser/ui/views/sync/dice_bubble_sync_promo_view.h
[modify] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/components/autofill/core/browser/ui/save_card_bubble_controller.h
[modify] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/components/autofill/core/common/autofill_features.h
[modify] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/components/autofill_strings.grdp
[add] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/components/autofill_strings_grdp/IDS_AUTOFILL_CARD_SAVED.png.sha1
[add] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/components/autofill_strings_grdp/IDS_AUTOFILL_DONE.png.sha1
[add] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/components/autofill_strings_grdp/IDS_AUTOFILL_MANAGE_CARDS.png.sha1
[add] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/components/autofill_strings_grdp/IDS_AUTOFILL_SIGNIN_PROMO_LINK_DICE_DISABLED.png.sha1
[add] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/components/autofill_strings_grdp/IDS_AUTOFILL_SIGNIN_PROMO_MESSAGE.png.sha1
[add] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/components/autofill_strings_grdp/IDS_AUTOFILL_SIGNIN_PROMO_MESSAGE_DICE_DISABLED.png.sha1
[add] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/components/autofill_strings_grdp/IDS_AUTOFILL_SYNC_PROMO_MESSAGE.png.sha1
[modify] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/components/signin/core/browser/signin_metrics.cc
[modify] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/components/signin/core/browser/signin_metrics.h
[modify] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/components/signin/core/browser/signin_metrics_unittest.cc
[modify] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/tools/metrics/actions/actions.xml
[modify] https://crrev.com/c4f37ecdd97025d21e06f38be285ede6e4de5f03/tools/metrics/histograms/enums.xml

Comment 2 by mea...@chromium.org, Jul 23 

Hi, is there any chance you forgot to upload the actual screenshots (.png files) for https://chromium-review.googlesource.com/c/chromium/src/+/1134514? 

For example, the SHA1 hash in components/autofill_strings_grdp/IDS_AUTOFILL_CARD_SAVED.png.sha1 is 19972b6ebc9586ca80abaabcd65a54fa41092beb but gsutil ls gs://chromium-translation-screenshots/19972b6ebc9586ca80abaabcd65a54fa41092beb fails to list any image file.

Translation pipeline is failing because of missing screenshots because of this, so please let me know if you can upload the images soon. Thanks!

Comment 3 by gov...@chromium.org, Jul 23

Cc: ma...@chromium.org

Comment 4 by jsaul@google.com, Jul 23 

Hi Mustafa,

The author of that CL is OOO today so unfortunately I don't know what the outcome of running the png upload tool was.  He'll be back tomorrow.

In the meantime, if it's urgent, would removing the .sha1 files resolve the problem?

Comment 5 by mea...@chromium.org, Jul 24 

Jared: Yes, that would resolve the problem. I'll send you a CL to do that.

Comment 6 by manasverma@google.com, Jul 24 

Hey, sorry about the issues -- I realized that when uploading the screenshots, I was not authenticated and so the uploads failed.

I'm currently working on re-uploading the images, but you can continue with the rollback for now.

Comment 7 by manasverma@google.com, Jul 24 

Just uploaded all of the images, and `gsutil ls gs://chromium-translation-screenshots/19972b6ebc9586ca80abaabcd65a54fa41092beb` (along with the other three hashes) are returning image files now.
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2eec4dd7d1643ef0a8dd38648cd6bbcc419c1695

commit 2eec4dd7d1643ef0a8dd38648cd6bbcc419c1695
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Jul 25 09:32:37 2018

Revert "[Autofill] Show Sign-in/Sync promo after saving a card locally and Manage Cards bubble."

This reverts commit c4f37ecdd97025d21e06f38be285ede6e4de5f03.

Reason for revert: Build bot failure:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-cocoa-rel/475

[ RUN      ] SaveCardBubbleViewsFullFormWithShippingBrowserTest.Upload_SubmittingFormWithConflictingNamesRequestsCardholderNameIfExpOn
[12092:9475:0719/223002.758479:WARNING:notification_platform_bridge_mac.mm(510)] AlertNotificationService: XPC connection invalidated.
2018-07-19 22:30:02.956 browser_tests[12092:1670186] *** Owner supplied to -[NSTrackingArea initWithRect:options:owner:userInfo:] referenced a deallocating object. Tracking area behavior is undefined. Break on NSTrackingAreaDeallocatingOwnerError to debug.
[12092:89883:0719/223003.745535:WARNING:embedded_test_server.cc(238)] Request not handled. Returning 404: /favicon.ico
BrowserTestBase received signal: Segmentation fault: 11. Backtrace:
0   browser_tests                       0x00000001129fb9bc base::debug::StackTrace::StackTrace(unsigned long) + 28
1   browser_tests                       0x0000000112fab7f5 content::(anonymous namespace)::DumpStackTraceSignalHandler(int) + 229
2   libsystem_platform.dylib            0x00007fff7de00f5a _sigtramp + 26
3   CoreFoundation                      0x00007fff55c0c8e6 _CFAutoreleasePoolPop + 22
4   browser_tests                       0x0000000112faae2b content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 491
5   browser_tests                       0x0000000112aabf47 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4375
6   browser_tests                       0x0000000112aaad2e ChromeBrowserMainParts::PreMainMessageLoopRun() + 62
7   browser_tests                       0x0000000111512c23 content::BrowserMainLoop::PreMainMessageLoopRun() + 67
8   browser_tests                       0x0000000111901147 content::StartupTaskRunner::RunAllTasksNow() + 39
9   browser_tests                       0x00000001115113c8 content::BrowserMainLoop::CreateStartupTasks() + 712
10  browser_tests                       0x0000000111514f80 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 96
11  browser_tests                       0x000000011150f4f4 content::BrowserMain(content::MainFunctionParams const&) + 180
12  browser_tests                       0x00000001128e1578 content::ContentMainRunnerImpl::Run(bool) + 824
13  browser_tests                       0x0000000114664651 service_manager::Main(service_manager::MainParams const&) + 2849
14  browser_tests                       0x00000001128e05c4 content::ContentMain(content::ContentMainParams const&) + 68
15  browser_tests                       0x0000000112faaa59 content::BrowserTestBase::SetUp() + 2697
16  browser_tests                       0x0000000112a31853 InProcessBrowserTest::SetUp() + 723
17  browser_tests                       0x00000001109bfefd testing::Test::Run() + 109
18  browser_tests                       0x00000001109c0b90 testing::TestInfo::Run() + 320
19  browser_tests                       0x00000001109c1107 testing::TestCase::Run() + 279
20  browser_tests                       0x00000001109cc737 testing::internal::UnitTestImpl::RunAllTests() + 871
21  browser_tests                       0x00000001109cc3ad testing::UnitTest::Run() + 109
22  browser_tests                       0x0000000112a4be76 base::TestSuite::Run() + 166
23  browser_tests                       0x000000011293dc65 ChromeTestSuiteRunner::RunTestSuite(int, char**) + 37
24  browser_tests                       0x0000000112fcb898 content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) + 552
25  browser_tests                       0x000000011293e13d LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) + 333
26  browser_tests                       0x000000011293dbde main + 94
27  libdyld.dylib                       0x00007fff7daf2015 start + 1
28  ???                                 0x000000000000000d 0x0 + 13

Original change's description:
> [Autofill] Show Sign-in/Sync promo after saving a card locally and Manage Cards bubble.
> 
> A sign-in promo pops up right after a card is saved locally. This also introduces
> a "Manage cards" bubble, with a footnote of a sign-in promo.
> 
> An organized list of the diffs --
>     https://screenshot.googleplex.com/kMBPkpWZYsq.png
> 
> A rough doc I quickly put together of the changes in this CL --
>     https://docs.google.com/document/d/1DarGyLBDSBWcsumcxhpojuvugUTUU6r5j6uI0RZZAo0/edit?usp=sharing
> 
> Here are different screenshots explaining why we chose to have the promo not display a title --
> Using promo's title (The string isn't updated in this screenshot):
>     https://screenshot.googleplex.com/kiYnAynyedD
> Empty promo title, using main bubble title:
>     https://screenshot.googleplex.com/rT3F9RETsgq
> No promo title, using main bubble title:
>     https://screenshot.googleplex.com/nMXOdNvysbR
> 
> This is what the mocks were like (with the old UI):
>     https://screenshot.googleplex.com/AhXfxONG0sO
> 
> 
> Additionally, this is what the sync promo looks like:
>     https://screenshot.googleplex.com/J3huQ06Y5X8
> Sign-in promo on the Manage Cards view:
>     https://screenshot.googleplex.com/MJqf5Fbhnpa
> Sync promo on the Manage Cards view:
>     https://screenshot.googleplex.com/cNLy78Ts80k
> 
> 
> Metrics, additional browser tests, and omnibox icon animation to follow.
> 
> Bug: 855186
> Change-Id: I74ecdd802da960120baacfdd771c90cb126fbd10
> Reviewed-on: https://chromium-review.googlesource.com/1134514
> Commit-Queue: Jared Saul <jsaul@google.com>
> Reviewed-by: Mathieu Perreault <mathp@chromium.org>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: Jared Saul <jsaul@google.com>
> Cr-Commit-Position: refs/heads/master@{#576769}

TBR=pkasting@chromium.org,isherman@chromium.org,mathp@chromium.org,estade@chromium.org,msarda@chromium.org,jsaul@google.com,dlkumar@google.com,manasverma@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 855186
Change-Id: Ibc7785f8f85b60a241d838c57a0bd385480dbd14
Reviewed-on: https://chromium-review.googlesource.com/1149740
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577828}
[modify] https://crrev.com/2eec4dd7d1643ef0a8dd38648cd6bbcc419c1695/chrome/browser/about_flags.cc
[modify] https://crrev.com/2eec4dd7d1643ef0a8dd38648cd6bbcc419c1695/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/2eec4dd7d1643ef0a8dd38648cd6bbcc419c1695/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/2eec4dd7d1643ef0a8dd38648cd6bbcc419c1695/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/2eec4dd7d1643ef0a8dd38648cd6bbcc419c1695/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/2eec4dd7d1643ef0a8dd38648cd6bbcc419c1695/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
[modify] https://crrev.com/2eec4dd7d1643ef0a8dd38648cd6bbcc419c1695/chrome/browser/ui/autofill/save_card_bubble_controller_impl_browsertest.cc
[modify] https://crrev.com/2eec4dd7d1643ef0a8dd38648cd6bbcc419c1695/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
[delete] https://crrev.com/44256192f2b9b62dc2cb5cc7a51804fe63637d35/chrome/browser/ui/autofill/save_card_ui.h
[modify] https://crrev.com/2eec4dd7d1643ef0a8dd38648cd6bbcc419c1695/chrome/browser/ui/views/autofill/dialog_view_ids.h
[modify] https://crrev.com/2eec4dd7d1643ef0a8dd38648cd6bbcc419c1695/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
[modify] https://crrev.com/2eec4dd7d1643ef0a8dd38648cd6bbcc419c1695/chrome/browser/ui/views/autofill/save_card_bubble_views.h
[modify] https://crrev.com/2eec4dd7d1643ef0a8dd38648cd6bbcc419c1695/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
[modify] https://crrev.com/2eec4dd7d1643ef0a8dd38648cd6bbcc419c1695/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc
[delete] https://crrev.com/44256192f2b9b62dc2cb5cc7a51804fe63637d35/chrome/browser/ui/views/autofill/save_card_manage_cards_bubble_views.cc
[delete] https://crrev.com/44256192f2b9b62dc2cb5cc7a51804fe63637d35/chrome/browser/ui/views/autofill/save_card_manage_cards_bubble_views.h
[delete] https://crrev.com/44256192f2b9b62dc2cb5cc7a51804fe63637d35/chrome/browser/ui/views/autofill/save_card_offer_bubble_views.cc
[delete] https://crrev.com/44256192f2b9b62dc2cb5cc7a51804fe63637d35/chrome/browser/ui/views/autofill/save_card_offer_bubble_views.h
[delete] https://crrev.com/44256192f2b9b62dc2cb5cc7a51804fe63637d35/chrome/browser/ui/views/autofill/save_card_sign_in_promo_bubble_views.cc
[delete] https://crrev.com/44256192f2b9b62dc2cb5cc7a51804fe63637d35/chrome/browser/ui/views/autofill/save_card_sign_in_promo_bubble_views.h
[modify] https://crrev.com/2eec4dd7d1643ef0a8dd38648cd6bbcc419c1695/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/2eec4dd7d1643ef0a8dd38648cd6bbcc419c1695/chrome/browser/ui/views/sync/dice_bubble_sync_promo_view.cc
[modify] https://crrev.com/2eec4dd7d1643ef0a8dd38648cd6bbcc419c1695/chrome/browser/ui/views/sync/dice_bubble_sync_promo_view.h
[modify] https://crrev.com/2eec4dd7d1643ef0a8dd38648cd6bbcc419c1695/components/autofill/core/browser/ui/save_card_bubble_controller.h
[modify] https://crrev.com/2eec4dd7d1643ef0a8dd38648cd6bbcc419c1695/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/2eec4dd7d1643ef0a8dd38648cd6bbcc419c1695/components/autofill/core/common/autofill_features.h
[modify] https://crrev.com/2eec4dd7d1643ef0a8dd38648cd6bbcc419c1695/components/autofill_strings.grdp
[delete] https://crrev.com/44256192f2b9b62dc2cb5cc7a51804fe63637d35/components/autofill_strings_grdp/IDS_AUTOFILL_CARD_SAVED.png.sha1
[delete] https://crrev.com/44256192f2b9b62dc2cb5cc7a51804fe63637d35/components/autofill_strings_grdp/IDS_AUTOFILL_DONE.png.sha1
[delete] https://crrev.com/44256192f2b9b62dc2cb5cc7a51804fe63637d35/components/autofill_strings_grdp/IDS_AUTOFILL_MANAGE_CARDS.png.sha1
[delete] https://crrev.com/44256192f2b9b62dc2cb5cc7a51804fe63637d35/components/autofill_strings_grdp/IDS_AUTOFILL_SIGNIN_PROMO_LINK_DICE_DISABLED.png.sha1
[delete] https://crrev.com/44256192f2b9b62dc2cb5cc7a51804fe63637d35/components/autofill_strings_grdp/IDS_AUTOFILL_SIGNIN_PROMO_MESSAGE.png.sha1
[delete] https://crrev.com/44256192f2b9b62dc2cb5cc7a51804fe63637d35/components/autofill_strings_grdp/IDS_AUTOFILL_SIGNIN_PROMO_MESSAGE_DICE_DISABLED.png.sha1
[delete] https://crrev.com/44256192f2b9b62dc2cb5cc7a51804fe63637d35/components/autofill_strings_grdp/IDS_AUTOFILL_SYNC_PROMO_MESSAGE.png.sha1
[modify] https://crrev.com/2eec4dd7d1643ef0a8dd38648cd6bbcc419c1695/components/signin/core/browser/signin_metrics.cc
[modify] https://crrev.com/2eec4dd7d1643ef0a8dd38648cd6bbcc419c1695/components/signin/core/browser/signin_metrics.h
[modify] https://crrev.com/2eec4dd7d1643ef0a8dd38648cd6bbcc419c1695/components/signin/core/browser/signin_metrics_unittest.cc
[modify] https://crrev.com/2eec4dd7d1643ef0a8dd38648cd6bbcc419c1695/tools/metrics/actions/actions.xml
[modify] https://crrev.com/2eec4dd7d1643ef0a8dd38648cd6bbcc419c1695/tools/metrics/histograms/enums.xml
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44ed6c0e49f62aff724f5d7b81e277cae1d46208

commit 44ed6c0e49f62aff724f5d7b81e277cae1d46208
Author: Manas Verma <manasverma@google.com>
Date: Thu Jul 26 18:20:29 2018

PageActionIconView inherits now from IconLabelBubbleView

The change is required for the sign-in after local save project. It will allow the save card icon to be able to animate and display text as part of feedback to the user that their card was saved.

This will also allow the password manager icon to be able to animate and display text as well.

Bug: 855186
Change-Id: I4e769a8b92f51a34d0feec10cdc77d508cd47b57
Reviewed-on: https://chromium-review.googlesource.com/1142439
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#578375}
[modify] https://crrev.com/44ed6c0e49f62aff724f5d7b81e277cae1d46208/chrome/browser/ui/views/location_bar/star_view.h
[modify] https://crrev.com/44ed6c0e49f62aff724f5d7b81e277cae1d46208/chrome/browser/ui/views/location_bar/star_view_browsertest.cc
[modify] https://crrev.com/44ed6c0e49f62aff724f5d7b81e277cae1d46208/chrome/browser/ui/views/page_action/page_action_icon_view.cc
[modify] https://crrev.com/44ed6c0e49f62aff724f5d7b81e277cae1d46208/chrome/browser/ui/views/page_action/page_action_icon_view.h
[modify] https://crrev.com/44ed6c0e49f62aff724f5d7b81e277cae1d46208/chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc

Comment 10 by mahmadi@chromium.org, Jul 30

Cc: mahmadi@chromium.org
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad

commit 99541e5c1e02db0c7a6cf6db5dff5466c9f013ad
Author: Manas Verma <manasverma@google.com>
Date: Fri Aug 03 20:37:23 2018

[Autofill] Show Sign-in/Sync promo after saving a card locally and Manage Cards bubble.

Fixing this build fail: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-cocoa-rel/475

Bug: 855186
Change-Id: I49b743e6d699e47768ff8d47ea2ac63dcb1ee49f
Reviewed-on: https://chromium-review.googlesource.com/1150445
Commit-Queue: Manas Verma <manasverma@google.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580640}
[modify] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/chrome/browser/about_flags.cc
[modify] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
[modify] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/chrome/browser/ui/autofill/save_card_bubble_controller_impl_browsertest.cc
[modify] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
[add] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/chrome/browser/ui/autofill/save_card_ui.h
[modify] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/chrome/browser/ui/cocoa/autofill/save_card_bubble_view_views.mm
[modify] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/chrome/browser/ui/views/autofill/dialog_view_ids.h
[modify] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
[modify] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/chrome/browser/ui/views/autofill/save_card_bubble_views.h
[modify] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
[modify] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc
[add] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/chrome/browser/ui/views/autofill/save_card_manage_cards_bubble_views.cc
[add] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/chrome/browser/ui/views/autofill/save_card_manage_cards_bubble_views.h
[add] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/chrome/browser/ui/views/autofill/save_card_offer_bubble_views.cc
[add] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/chrome/browser/ui/views/autofill/save_card_offer_bubble_views.h
[add] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/chrome/browser/ui/views/autofill/save_card_sign_in_promo_bubble_views.cc
[add] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/chrome/browser/ui/views/autofill/save_card_sign_in_promo_bubble_views.h
[modify] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/chrome/browser/ui/views/sync/dice_bubble_sync_promo_view.cc
[modify] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/chrome/browser/ui/views/sync/dice_bubble_sync_promo_view.h
[modify] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/components/autofill/core/browser/ui/save_card_bubble_controller.h
[modify] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/components/autofill/core/common/autofill_features.h
[modify] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/components/autofill_strings.grdp
[add] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/components/autofill_strings_grdp/IDS_AUTOFILL_CARD_SAVED.png.sha1
[add] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/components/autofill_strings_grdp/IDS_AUTOFILL_DONE.png.sha1
[add] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/components/autofill_strings_grdp/IDS_AUTOFILL_MANAGE_CARDS.png.sha1
[add] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/components/autofill_strings_grdp/IDS_AUTOFILL_SIGNIN_PROMO_LINK_DICE_DISABLED.png.sha1
[add] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/components/autofill_strings_grdp/IDS_AUTOFILL_SIGNIN_PROMO_MESSAGE.png.sha1
[add] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/components/autofill_strings_grdp/IDS_AUTOFILL_SIGNIN_PROMO_MESSAGE_DICE_DISABLED.png.sha1
[add] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/components/autofill_strings_grdp/IDS_AUTOFILL_SYNC_PROMO_MESSAGE.png.sha1
[modify] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/components/signin/core/browser/signin_metrics.cc
[modify] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/components/signin/core/browser/signin_metrics.h
[modify] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/components/signin/core/browser/signin_metrics_unittest.cc
[modify] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/tools/metrics/actions/actions.xml
[modify] https://crrev.com/99541e5c1e02db0c7a6cf6db5dff5466c9f013ad/tools/metrics/histograms/enums.xml
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ad5c66907292930c378b882c1634fad9b2b29eb

commit 1ad5c66907292930c378b882c1634fad9b2b29eb
Author: Manas Verma <manasverma@google.com>
Date: Fri Aug 10 20:54:59 2018

[Autofill] Updating strings for Save Card Sign-in Promo

Before: https://screenshot.googleplex.com/5YhNTQYuHV1
After: https://screenshot.googleplex.com/thg0VSMKzNX


Bug: 855186
Change-Id: I64b1ca9452330a847512c45220bda9173e1a1ac1
Reviewed-on: https://chromium-review.googlesource.com/1170141
Commit-Queue: Manas Verma <manasverma@google.com>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582327}
[modify] https://crrev.com/1ad5c66907292930c378b882c1634fad9b2b29eb/chrome/browser/ui/views/autofill/save_card_manage_cards_bubble_views.cc
[modify] https://crrev.com/1ad5c66907292930c378b882c1634fad9b2b29eb/chrome/browser/ui/views/autofill/save_card_sign_in_promo_bubble_views.cc
[modify] https://crrev.com/1ad5c66907292930c378b882c1634fad9b2b29eb/components/autofill_strings.grdp
[modify] https://crrev.com/1ad5c66907292930c378b882c1634fad9b2b29eb/components/autofill_strings_grdp/IDS_AUTOFILL_SIGNIN_PROMO_MESSAGE.png.sha1
[modify] https://crrev.com/1ad5c66907292930c378b882c1634fad9b2b29eb/components/autofill_strings_grdp/IDS_AUTOFILL_SIGNIN_PROMO_MESSAGE_DICE_DISABLED.png.sha1
[modify] https://crrev.com/1ad5c66907292930c378b882c1634fad9b2b29eb/components/autofill_strings_grdp/IDS_AUTOFILL_SYNC_PROMO_MESSAGE.png.sha1
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc4873aab0fa69589a09231699de4f47cce09643

commit dc4873aab0fa69589a09231699de4f47cce09643
Author: Manas Verma <manasverma@google.com>
Date: Tue Aug 14 19:54:30 2018

Renaming IconLabelBubble constants to avoid compilation error.


The variable `kTweenType` was re-defined in another class. Renaming it to `kIconLabelBubbleTweenType`, and changed the other constants similarly to avoid future conflicts.

Original change introduced here: https://chromium-review.googlesource.com/c/chromium/src/+/1162862


Bug: 855186
Change-Id: I94d3ea5b4732bac586780e441804a3e98bb99bb0
Reviewed-on: https://chromium-review.googlesource.com/1174893
Commit-Queue: Manas Verma <manasverma@google.com>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583003}
[modify] https://crrev.com/dc4873aab0fa69589a09231699de4f47cce09643/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f039920b514121dd618139257620728e34e3f9cb

commit f039920b514121dd618139257620728e34e3f9cb
Author: Manas Verma <manasverma@google.com>
Date: Fri Aug 17 00:18:05 2018

[Autofill] Save Card Icon is now highlighted when bubble is showing.

This CL: https://chromium-review.googlesource.com/c/chromium/src/+/1162862 got rid of the icon highlight. This change brings back the behavior where the icon is highlighted when the corresponding bubble is active.

Bug: 855186
Change-Id: Ifda765890bbc181af67ef0a435501a329fdd8470
Reviewed-on: https://chromium-review.googlesource.com/1179124
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#583899}
[modify] https://crrev.com/f039920b514121dd618139257620728e34e3f9cb/chrome/browser/ui/views/autofill/save_card_icon_view.cc
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2c5c920606d91b36de4f434df210d49490e8d9d

commit f2c5c920606d91b36de4f434df210d49490e8d9d
Author: Manas Verma <manasverma@google.com>
Date: Tue Aug 21 17:22:49 2018

[Autofill] Creating separate sign-in metric access point for Manage Cards bubble.

Previously there was a single access point for both the sign-in promo and the manage cards prompt, shown after saving a card locally. This change creates a separate access point for the manage cards prompt.


Bug: 855186
Change-Id: Ibdf036ac12a9ea7cce27abde41b368b7736ccb63
Reviewed-on: https://chromium-review.googlesource.com/1169630
Commit-Queue: Manas Verma <manasverma@google.com>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584810}
[modify] https://crrev.com/f2c5c920606d91b36de4f434df210d49490e8d9d/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/f2c5c920606d91b36de4f434df210d49490e8d9d/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
[modify] https://crrev.com/f2c5c920606d91b36de4f434df210d49490e8d9d/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
[modify] https://crrev.com/f2c5c920606d91b36de4f434df210d49490e8d9d/chrome/browser/ui/views/autofill/save_card_bubble_views.h
[modify] https://crrev.com/f2c5c920606d91b36de4f434df210d49490e8d9d/chrome/browser/ui/views/autofill/save_card_manage_cards_bubble_views.cc
[modify] https://crrev.com/f2c5c920606d91b36de4f434df210d49490e8d9d/chrome/browser/ui/views/autofill/save_card_sign_in_promo_bubble_views.cc
[modify] https://crrev.com/f2c5c920606d91b36de4f434df210d49490e8d9d/components/autofill/core/browser/ui/save_card_bubble_controller.h
[modify] https://crrev.com/f2c5c920606d91b36de4f434df210d49490e8d9d/components/signin/core/browser/signin_metrics.cc
[modify] https://crrev.com/f2c5c920606d91b36de4f434df210d49490e8d9d/components/signin/core/browser/signin_metrics.h
[modify] https://crrev.com/f2c5c920606d91b36de4f434df210d49490e8d9d/components/signin/core/browser/signin_metrics_unittest.cc
[modify] https://crrev.com/f2c5c920606d91b36de4f434df210d49490e8d9d/tools/metrics/actions/actions.xml
[modify] https://crrev.com/f2c5c920606d91b36de4f434df210d49490e8d9d/tools/metrics/histograms/enums.xml
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/617db9751dfc48554ea0058393cbdc4b57cdea7f

commit 617db9751dfc48554ea0058393cbdc4b57cdea7f
Author: Manas Verma <manasverma@google.com>
Date: Fri Aug 24 18:41:10 2018

Update fieldtrial_testing_config.json for AutofillSaveCardSignInAfterLocalSave

Bug: 855186
Change-Id: I0f83e8c802f98b01f62447bc2515d7a5cb2dc133
Reviewed-on: https://chromium-review.googlesource.com/1187626
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#585920}
[modify] https://crrev.com/617db9751dfc48554ea0058393cbdc4b57cdea7f/testing/variations/fieldtrial_testing_config.json
Project Member

Comment 17 by bugdroid1@chromium.org, Aug 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32e842cb3e72bd70a4c3d2c09da090d9a0fb08a0

commit 32e842cb3e72bd70a4c3d2c09da090d9a0fb08a0
Author: Manas Verma <manasverma@google.com>
Date: Mon Aug 27 22:59:19 2018

[Autofill] Correct sync-promo message for Save Card prompt.

After saving a card locally, when the user is signed-in but not syncing, the sync promo now uses the correct message.

Before: https://screenshot.googleplex.com/mVYG5Eg40Af
After: https://screenshot.googleplex.com/ijDADX71Nsq

Bug: 855186
Change-Id: I872c0c078c991d78afa07dba7e6bf394552ab4a7
Reviewed-on: https://chromium-review.googlesource.com/1191524
Commit-Queue: Manas Verma <manasverma@google.com>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#586468}
[modify] https://crrev.com/32e842cb3e72bd70a4c3d2c09da090d9a0fb08a0/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/32e842cb3e72bd70a4c3d2c09da090d9a0fb08a0/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
Project Member

Comment 18 by bugdroid1@chromium.org, Aug 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6aa5a8a398d978aca7cb31ecf40afd764323d8da

commit 6aa5a8a398d978aca7cb31ecf40afd764323d8da
Author: Manas Verma <manasverma@google.com>
Date: Wed Aug 29 20:24:57 2018

[Autofill] Save Card Icon Highlight Fix

Previously, if the user was signed-in but opted out of syncing (so no promo would be shown), after saving a card locally, the icon would highlight after the animation ended even if no bubble was showing. This change fixes that.

Bug: 855186
Change-Id: I8aca67c572dafb91f37bcf752a813d3bbcfe14e4
Reviewed-on: https://chromium-review.googlesource.com/1192584
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#587275}
[modify] https://crrev.com/6aa5a8a398d978aca7cb31ecf40afd764323d8da/chrome/browser/ui/views/autofill/save_card_icon_view.cc
Project Member

Comment 19 by bugdroid1@chromium.org, Sep 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/329d8468628836870c240d47a135a7529429083c

commit 329d8468628836870c240d47a135a7529429083c
Author: Manas Verma <manasverma@google.com>
Date: Thu Sep 06 23:10:43 2018

[Autofill] The "Card saved" animation resets properly once done.

Previously, if we save a card twice in a row, the second time the animation needs to be shown, it would just show static text. The animation continues to glitch for each subsequent use.
Now the animation works properly each time it is invoked.

This also applies to the pop-up blocker's "Pop-up blocked" text animation.

Bug: 855186,881324,881320
Change-Id: Ie6f8a53a24d5ec4dd06b9ead27b784fc46a26310
Reviewed-on: https://chromium-review.googlesource.com/1208140
Reviewed-by: Carlos IL <carlosil@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#589356}
[modify] https://crrev.com/329d8468628836870c240d47a135a7529429083c/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
Project Member

Comment 20 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d54e0de4392872e4b60947543ed730aac23c4ddf

commit d54e0de4392872e4b60947543ed730aac23c4ddf
Author: Manas Verma <manasverma@google.com>
Date: Tue Sep 18 22:22:48 2018

[Autofill] Browser Tests for Sign-in After Local Save.

Adding browser tests for the sign-in after local save flow. This includes user-action sign-in metrics, the sign-in promo, and the manage cards prompt.

Bug: 855186
Change-Id: I8c1d15f79e6915230860d7f0f2529a10c01559b7
Reviewed-on: https://chromium-review.googlesource.com/1196918
Commit-Queue: Manas Verma <manasverma@google.com>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592227}
[modify] https://crrev.com/d54e0de4392872e4b60947543ed730aac23c4ddf/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/d54e0de4392872e4b60947543ed730aac23c4ddf/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
[modify] https://crrev.com/d54e0de4392872e4b60947543ed730aac23c4ddf/chrome/browser/ui/views/autofill/dialog_view_ids.h
[modify] https://crrev.com/d54e0de4392872e4b60947543ed730aac23c4ddf/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
[modify] https://crrev.com/d54e0de4392872e4b60947543ed730aac23c4ddf/chrome/browser/ui/views/autofill/save_card_bubble_views.h
[modify] https://crrev.com/d54e0de4392872e4b60947543ed730aac23c4ddf/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
[modify] https://crrev.com/d54e0de4392872e4b60947543ed730aac23c4ddf/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc
[modify] https://crrev.com/d54e0de4392872e4b60947543ed730aac23c4ddf/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.h
[modify] https://crrev.com/d54e0de4392872e4b60947543ed730aac23c4ddf/chrome/browser/ui/views/autofill/save_card_icon_view.h
[modify] https://crrev.com/d54e0de4392872e4b60947543ed730aac23c4ddf/chrome/browser/ui/views/autofill/save_card_manage_cards_bubble_views.cc
[modify] https://crrev.com/d54e0de4392872e4b60947543ed730aac23c4ddf/chrome/browser/ui/views/autofill/save_card_offer_bubble_views.cc
[modify] https://crrev.com/d54e0de4392872e4b60947543ed730aac23c4ddf/chrome/browser/ui/views/autofill/save_card_offer_bubble_views.h
[modify] https://crrev.com/d54e0de4392872e4b60947543ed730aac23c4ddf/chrome/browser/ui/views/autofill/save_card_sign_in_promo_bubble_views.cc
[modify] https://crrev.com/d54e0de4392872e4b60947543ed730aac23c4ddf/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
[modify] https://crrev.com/d54e0de4392872e4b60947543ed730aac23c4ddf/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
[modify] https://crrev.com/d54e0de4392872e4b60947543ed730aac23c4ddf/chrome/browser/ui/views/sync/dice_bubble_sync_promo_view.cc
[modify] https://crrev.com/d54e0de4392872e4b60947543ed730aac23c4ddf/chrome/browser/ui/views/sync/dice_bubble_sync_promo_view.h
Project Member

Comment 21 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24ec90a378a7590b2b8ea389f39fa2e37c42e4ab

commit 24ec90a378a7590b2b8ea389f39fa2e37c42e4ab
Author: Asanka Herath <asanka@chromium.org>
Date: Wed Sep 19 14:53:57 2018

Revert "[Autofill] Browser Tests for Sign-in After Local Save."

This reverts commit d54e0de4392872e4b60947543ed730aac23c4ddf.

Reason for revert: Tests added in this CL are failing. See  https://crbug.com/886533 

Original change's description:
> [Autofill] Browser Tests for Sign-in After Local Save.
> 
> Adding browser tests for the sign-in after local save flow. This includes user-action sign-in metrics, the sign-in promo, and the manage cards prompt.
> 
> Bug: 855186
> Change-Id: I8c1d15f79e6915230860d7f0f2529a10c01559b7
> Reviewed-on: https://chromium-review.googlesource.com/1196918
> Commit-Queue: Manas Verma <manasverma@google.com>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Reviewed-by: Mathieu Perreault <mathp@chromium.org>
> Reviewed-by: Jared Saul <jsaul@google.com>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592227}

TBR=mathp@chromium.org,estade@chromium.org,msarda@chromium.org,jsaul@google.com,manasverma@google.com

Change-Id: I6fe0b1508df0980aded5fa38fb5d43b3664db83f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 855186
Reviewed-on: https://chromium-review.googlesource.com/1233938
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592397}
[modify] https://crrev.com/24ec90a378a7590b2b8ea389f39fa2e37c42e4ab/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/24ec90a378a7590b2b8ea389f39fa2e37c42e4ab/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
[modify] https://crrev.com/24ec90a378a7590b2b8ea389f39fa2e37c42e4ab/chrome/browser/ui/views/autofill/dialog_view_ids.h
[modify] https://crrev.com/24ec90a378a7590b2b8ea389f39fa2e37c42e4ab/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
[modify] https://crrev.com/24ec90a378a7590b2b8ea389f39fa2e37c42e4ab/chrome/browser/ui/views/autofill/save_card_bubble_views.h
[modify] https://crrev.com/24ec90a378a7590b2b8ea389f39fa2e37c42e4ab/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
[modify] https://crrev.com/24ec90a378a7590b2b8ea389f39fa2e37c42e4ab/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc
[modify] https://crrev.com/24ec90a378a7590b2b8ea389f39fa2e37c42e4ab/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.h
[modify] https://crrev.com/24ec90a378a7590b2b8ea389f39fa2e37c42e4ab/chrome/browser/ui/views/autofill/save_card_icon_view.h
[modify] https://crrev.com/24ec90a378a7590b2b8ea389f39fa2e37c42e4ab/chrome/browser/ui/views/autofill/save_card_manage_cards_bubble_views.cc
[modify] https://crrev.com/24ec90a378a7590b2b8ea389f39fa2e37c42e4ab/chrome/browser/ui/views/autofill/save_card_offer_bubble_views.cc
[modify] https://crrev.com/24ec90a378a7590b2b8ea389f39fa2e37c42e4ab/chrome/browser/ui/views/autofill/save_card_offer_bubble_views.h
[modify] https://crrev.com/24ec90a378a7590b2b8ea389f39fa2e37c42e4ab/chrome/browser/ui/views/autofill/save_card_sign_in_promo_bubble_views.cc
[modify] https://crrev.com/24ec90a378a7590b2b8ea389f39fa2e37c42e4ab/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
[modify] https://crrev.com/24ec90a378a7590b2b8ea389f39fa2e37c42e4ab/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
[modify] https://crrev.com/24ec90a378a7590b2b8ea389f39fa2e37c42e4ab/chrome/browser/ui/views/sync/dice_bubble_sync_promo_view.cc
[modify] https://crrev.com/24ec90a378a7590b2b8ea389f39fa2e37c42e4ab/chrome/browser/ui/views/sync/dice_bubble_sync_promo_view.h

Comment 22 by asanka@chromium.org, Sep 19 

 Issue 886533  was autofiled for the flaky tests.

Comment 23 by asanka@chromium.org, Sep 19

Cc: manasverma@google.com
 Issue 886533  has been merged into this issue.
Project Member

Comment 24 by bugdroid1@chromium.org, Sep 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bcfe1d68a2f5e6b9c2fd8ecc5d3b0fc8e697ac0

commit 0bcfe1d68a2f5e6b9c2fd8ecc5d3b0fc8e697ac0
Author: Manas Verma <manasverma@google.com>
Date: Fri Sep 28 18:16:03 2018

Reland "[Autofill] Browser Tests for Sign-in After Local Save."

This is a reland of d54e0de4392872e4b60947543ed730aac23c4ddf

Original change's description:
> [Autofill] Browser Tests for Sign-in After Local Save.
> 
> Adding browser tests for the sign-in after local save flow. This includes user-action sign-in metrics, the sign-in promo, and the manage cards prompt.
> 
> Bug: 855186
> Change-Id: I8c1d15f79e6915230860d7f0f2529a10c01559b7
> Reviewed-on: https://chromium-review.googlesource.com/1196918
> Commit-Queue: Manas Verma <manasverma@google.com>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Reviewed-by: Mathieu Perreault <mathp@chromium.org>
> Reviewed-by: Jared Saul <jsaul@google.com>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592227}

Bug: 855186
Change-Id: Id7258331f021a1f69dd84f7f6e6fc77b01f0885d
Reviewed-on: https://chromium-review.googlesource.com/1241558
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#595157}
[modify] https://crrev.com/0bcfe1d68a2f5e6b9c2fd8ecc5d3b0fc8e697ac0/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/0bcfe1d68a2f5e6b9c2fd8ecc5d3b0fc8e697ac0/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
[modify] https://crrev.com/0bcfe1d68a2f5e6b9c2fd8ecc5d3b0fc8e697ac0/chrome/browser/ui/views/autofill/dialog_view_ids.h
[modify] https://crrev.com/0bcfe1d68a2f5e6b9c2fd8ecc5d3b0fc8e697ac0/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
[modify] https://crrev.com/0bcfe1d68a2f5e6b9c2fd8ecc5d3b0fc8e697ac0/chrome/browser/ui/views/autofill/save_card_bubble_views.h
[modify] https://crrev.com/0bcfe1d68a2f5e6b9c2fd8ecc5d3b0fc8e697ac0/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
[modify] https://crrev.com/0bcfe1d68a2f5e6b9c2fd8ecc5d3b0fc8e697ac0/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc
[modify] https://crrev.com/0bcfe1d68a2f5e6b9c2fd8ecc5d3b0fc8e697ac0/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.h
[modify] https://crrev.com/0bcfe1d68a2f5e6b9c2fd8ecc5d3b0fc8e697ac0/chrome/browser/ui/views/autofill/save_card_icon_view.h
[modify] https://crrev.com/0bcfe1d68a2f5e6b9c2fd8ecc5d3b0fc8e697ac0/chrome/browser/ui/views/autofill/save_card_manage_cards_bubble_views.cc
[modify] https://crrev.com/0bcfe1d68a2f5e6b9c2fd8ecc5d3b0fc8e697ac0/chrome/browser/ui/views/autofill/save_card_offer_bubble_views.cc
[modify] https://crrev.com/0bcfe1d68a2f5e6b9c2fd8ecc5d3b0fc8e697ac0/chrome/browser/ui/views/autofill/save_card_offer_bubble_views.h
[modify] https://crrev.com/0bcfe1d68a2f5e6b9c2fd8ecc5d3b0fc8e697ac0/chrome/browser/ui/views/autofill/save_card_sign_in_promo_bubble_views.cc
[modify] https://crrev.com/0bcfe1d68a2f5e6b9c2fd8ecc5d3b0fc8e697ac0/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
[modify] https://crrev.com/0bcfe1d68a2f5e6b9c2fd8ecc5d3b0fc8e697ac0/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
[modify] https://crrev.com/0bcfe1d68a2f5e6b9c2fd8ecc5d3b0fc8e697ac0/chrome/browser/ui/views/sync/dice_bubble_sync_promo_view.cc
[modify] https://crrev.com/0bcfe1d68a2f5e6b9c2fd8ecc5d3b0fc8e697ac0/chrome/browser/ui/views/sync/dice_bubble_sync_promo_view.h
►

Sign in to add a comment