New issue
Advanced search Search tips

Issue 855180 link

Starred by 1 user
Status: Fixed
Owner:
fdoray@chromium.org
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Navigation to an error page stays in the LOADING state forever with PageAlmostIdle

Project Member Reported by fdoray@chromium.org, Jun 21 2018 
Steps to repro:
1. Run Chrome with --enable-features=PageAlmostIdle.
2. Navigate to a invalid domain (e.g. domain-that-doesnt-exist.ca) or to a domain blocked by the administrator.
3. In chrome://discards, observe that the loading state stays LOADING forever, instead of transitioning to LOADED.

Cause:
For a tab to transition to the LOADED state, PageSignalGeneratorImpl must be notified of a main frame navigation commit. This notification is sent by ResourceCoordinatorTabHelper::DidFinishNavigation(). Unfortunately, this method erroneously skips sending this notification when there is a navigation to an error page.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc05ae46788bb466c985539a4d5126191cff8fe7

commit cc05ae46788bb466c985539a4d5126191cff8fe7
Author: Francois Doray <fdoray@chromium.org>
Date: Thu Jun 21 23:17:05 2018

RC: Generate main frame navigation commit event for navigations to an error page.

For some reason, ResourceCoordinatorTabHelper::DidFinishNavigation()
currently skips updating the frame tree and notifying the
PageResourceCoordinator of main frame navigation commit when there is a
navigation to an error page. This causes multiple problems:

- The error page stays in the LOADING state forever.
- The main frame URL is not updated in PageCoordinationUnitImpl.

A navigation to an error page is just like a navigation to a normal
page (the error page has a main frame, a renderer process), so there is
no reason to have special case for it in
ResourceCoordinatorTabHelper::DidFinishNavigation().

Bug:  855180 
Change-Id: Ifbe52ce714ef04af574e00041f8b970c13c08f5d
Reviewed-on: https://chromium-review.googlesource.com/1110697
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569433}
[modify] https://crrev.com/cc05ae46788bb466c985539a4d5126191cff8fe7/chrome/browser/resource_coordinator/tab_helper.cc

Comment 2 by fdoray@chromium.org, Jun 26 2018

Status: Fixed (was: Started)
►

Sign in to add a comment