Issue 855176 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	nicolaso@chromium.org
Closed:	Jul 16
Cc:	anthonyvd@chromium.org
Components:	UI>Browser>Language>Translate
EstimatedDays:	----
NextAction:	----
OS:	Linux , Android
Pri:	3
Type:	Bug
TE-Verified-M69 TE-Verified-69.0.3475.0

chrome://translate-internals doesn't expose `translate_recent_target`

Project Member Reported by nicolaso@chromium.org, Jun 21 2018

Issue description

Chrome Version: 67.0.3396.87
OS: Linux

What steps will reproduce the problem?
(1) Visit a website in another language (e.g. Naver)
(2) Use the Translate popup to translate the webpage to another language
(3) Visit chrome://translate-internals

What is the expected result?

chrome://translate-internals should show the value of the `translate_recent_target` and allow resetting/modifying the value, to make debugging easier.

What happens instead?

chrome://translate-internals doesn't show and/or allow the user to modify `translate_recent_target`

Comment 1 by yyushkina@chromium.org, Jun 22 2018

Status: Assigned (was: Untriaged)

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/606ee9b344db1e9dc9f5e374ffa90bfa932dde4a

commit 606ee9b344db1e9dc9f5e374ffa90bfa932dde4a
Author: Nicolas Ouellet-payeur <nicolaso@chromium.org>
Date: Wed Jun 27 13:38:26 2018

Add 'translate_recent_target' to chrome://translate-internals

This should make it easier to debug Translate internals.

UI changes:

1. Add 'translate_recent_target' to the Preferences dump in the
   translate-internals page.

2. Add a box for the user to enter a new value for 'translate_recent_target',
   and an 'update' button. When the user clicks the button, the preference is
   updated.

Bug:  855176 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I97437c792c8b6efb73bdb6d1c21f05c5ffff7d8a
Reviewed-on: https://chromium-review.googlesource.com/1110739
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570747}
[modify] https://crrev.com/606ee9b344db1e9dc9f5e374ffa90bfa932dde4a/chrome/browser/resources/translate_internals/prefs.html
[modify] https://crrev.com/606ee9b344db1e9dc9f5e374ffa90bfa932dde4a/chrome/browser/resources/translate_internals/translate_internals.js
[modify] https://crrev.com/606ee9b344db1e9dc9f5e374ffa90bfa932dde4a/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc
[modify] https://crrev.com/606ee9b344db1e9dc9f5e374ffa90bfa932dde4a/chrome/browser/ui/webui/translate_internals/translate_internals_handler.h

Comment 3 by susan.boorgula@chromium.org, Jun 28 2018

Labels: TE-Verified-69.0.3475.0 TE-Verified-M69

Able to reproduce this issue on Ubuntu 17.10 on the reported version 67.0.3396.87 and the issue is fixed on the latest Canary 69.0.3475.0 by following the steps mentioned in the original comment.

On the latest Canary, in chrome://translate-internals page, can observe translate_recent_target with a text box and Update button.
Attached is the screen shot for reference.

Hence adding TE verified labels as the fix is working as intended.

Thanks..