Make run_suite_skylab pass job_keyvals |
||||||
Issue descriptionIt's hard to relate parent tasks to its child tasks through TKO since TKO seems doesn't have an effective parent task id. It makes me harder to double-check whether a suite succeeds in real. Is there already a bug for it?
,
Jun 22 2018
Are parent task id and parent job id distinct? Job ID was requested in 297652 and added for 305313.
,
Jun 23 2018
job id comes from job tag https://chromium.googlesource.com/chromiumos/third_party/autotest/+/master/tko/utils.py parent job id comes from keyvals These reference the AFE job id, but we don't have AFE job ids in Skylab. Swarming task ids are strings not ints, so we can't put them into the same column We could convert them from hex strings to ints, not sure if that's a good idea though.
,
Jun 23 2018
Oh, a MySQL int can't fit a task id: 3dfab6d2009c1110 = 4466082993560883472 int = 32 bit = 4294967296
,
Jun 26 2018
The problem here is that run_skylab_suite doesn't drop any job keyvals. This is why tbe tko_jobs table also doesn't have suite, build etc.
,
Jun 26 2018
skylab_run_suite needs to do the equivalent of: http://shortn/_UuNY28FYQW
,
Jun 28 2018
,
Jun 29 2018
,
Jun 29 2018
Issue 858898 has been merged into this issue.
,
Jul 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b279566d72166922706652d07fdf4fc254b1bab0 commit b279566d72166922706652d07fdf4fc254b1bab0 Author: Xixuan Wu <xixuan@chromium.org> Date: Mon Jul 02 23:58:20 2018 autotest: Pass job_keyvals to run_suite_skylab. BUG= chromium:855173 TEST=Ran locally. Change-Id: Ie750931801a9ebee66a9002beffbe676c324c685 Reviewed-on: https://chromium-review.googlesource.com/1119389 Reviewed-by: Xixuan Wu <xixuan@chromium.org> Commit-Queue: Xixuan Wu <xixuan@chromium.org> Tested-by: Xixuan Wu <xixuan@chromium.org> [modify] https://crrev.com/b279566d72166922706652d07fdf4fc254b1bab0/venv/skylab_suite/suite_runner.py [modify] https://crrev.com/b279566d72166922706652d07fdf4fc254b1bab0/venv/skylab_suite/suite_parser.py [modify] https://crrev.com/b279566d72166922706652d07fdf4fc254b1bab0/venv/skylab_suite/cros_suite.py
,
Jul 20
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7a450c58b067b366e78c7690aaa91e578b106be2 commit 7a450c58b067b366e78c7690aaa91e578b106be2 Author: Xixuan Wu <xixuan@chromium.org> Date: Fri Jul 20 23:27:50 2018 autotest: Pass job_keyvals to swarming_worker. BUG= chromium:855173 TEST=Ran "bin/run_suite_skylab --pool=cq --board=nyan_blaze --suite_name=sanity --build=nyan_blaze-release/R69-10763.0.0 --priority 80 --timeout_mins 30 --test_retry --max_retries 5". Verified in TKO. Change-Id: I95fcee378223a06c96bfb3819eb98aad1abf4f3d Reviewed-on: https://chromium-review.googlesource.com/1145645 Reviewed-by: Allen Li <ayatane@chromium.org> Commit-Queue: Xixuan Wu <xixuan@chromium.org> Tested-by: Xixuan Wu <xixuan@chromium.org> [modify] https://crrev.com/7a450c58b067b366e78c7690aaa91e578b106be2/venv/skylab_suite/suite_runner.py
,
Jul 23
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by xixuan@chromium.org
, Jun 21 2018