New issue
Advanced search Search tips

Issue 855168 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.chrome.browser.download.DownloadActivityTest#testSpaceDisplay" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 21 2018

Issue description

"org.chromium.chrome.browser.download.DownloadActivityTest#testSpaceDisplay" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVQsSBUZsYWtlIkpvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIuZG93bmxvYWQuRG93bmxvYWRBY3Rpdml0eVRlc3QjdGVzdFNwYWNlRGlzcGxheQw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Labels: OS-Android
Owner: dtrainor@chromium.org
Status: Assigned (was: Untriaged)
Hi dtrainor, could you help triage this?
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/055aafbe751ade39703914fc746ceb137543ce62

commit 055aafbe751ade39703914fc746ceb137543ce62
Author: Darren Shen <shend@chromium.org>
Date: Fri Jun 22 03:37:50 2018

Disable flaky chrome.browser.download.DownloadActivityTest tests

TBR=dtrainor@chromium.org

Bug: 855219, 855168, 855167, 854241
Change-Id: I555f125d6d581e4f7d0361e61bc6a3d2963d37a1
Reviewed-on: https://chromium-review.googlesource.com/1111483
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569525}
[modify] https://crrev.com/055aafbe751ade39703914fc746ceb137543ce62/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java

Comment 3 by shend@chromium.org, Jun 22 2018

Labels: -Sheriff-Chromium
Owner: xingliu@chromium.org
xingliu@ did you fix this for another bug?
No, this test will be removed shortly.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce3de2d33c08d47444e6f7798cea176654e642a5

commit ce3de2d33c08d47444e6f7798cea176654e642a5
Author: Xing Liu <xingliu@chromium.org>
Date: Mon Jun 25 18:46:16 2018

Download location: enable flaky tests in DownloadActivityTest.

The CL that causes the flakiness has been reverted. See:
https://chromium-review.googlesource.com/c/chromium/src/+/1112777
Landed as e4144ed1a4845edb13e3afce024a8cb60588b38f.

This CL enables flaky tests in DownloadActivityTest.

TBR=dtrainor@chromium.org

Bug: 855389,855219,855168,855167
Change-Id: Id53085ed71c5188cd1e7588998bda6f00c7b89a5
Reviewed-on: https://chromium-review.googlesource.com/1113910
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570107}
[modify] https://crrev.com/ce3de2d33c08d47444e6f7798cea176654e642a5/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d4f6fdc1c619ac1e15ade577008de18525a132e

commit 5d4f6fdc1c619ac1e15ade577008de18525a132e
Author: Theresa <twellington@chromium.org>
Date: Mon Jun 25 22:54:43 2018

Revert "Download location: enable flaky tests in DownloadActivityTest."

This reverts commit ce3de2d33c08d47444e6f7798cea176654e642a5.

Reason for revert: Some of the tests are still failing, triggering a try flakes alert. Will you please re-land with the tests we know are passing conditionally re-enabled?


Original change's description:
> Download location: enable flaky tests in DownloadActivityTest.
> 
> The CL that causes the flakiness has been reverted. See:
> https://chromium-review.googlesource.com/c/chromium/src/+/1112777
> Landed as e4144ed1a4845edb13e3afce024a8cb60588b38f.
> 
> This CL enables flaky tests in DownloadActivityTest.
> 
> TBR=dtrainor@chromium.org
> 
> Bug: 855389,855219,855168,855167
> Change-Id: Id53085ed71c5188cd1e7588998bda6f00c7b89a5
> Reviewed-on: https://chromium-review.googlesource.com/1113910
> Reviewed-by: Xing Liu <xingliu@chromium.org>
> Commit-Queue: Xing Liu <xingliu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570107}

TBR=dtrainor@chromium.org,xingliu@chromium.org

Change-Id: I7299f6a85b0acd59050f1f26c0f6c8a8fb3626c6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 855389, 855219, 855168, 855167
Reviewed-on: https://chromium-review.googlesource.com/1114044
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570215}
[modify] https://crrev.com/5d4f6fdc1c619ac1e15ade577008de18525a132e/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java

Sign in to add a comment