New issue
Advanced search Search tips

Issue 855163 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

automatic mouse hiding behavior needs some debouncing

Project Member Reported by vapier@chromium.org, Jun 21 2018

Issue description

Chrome Version: 68.0.3440.25 (Official Build) dev (64-bit)
OS: Chrome OS 10718.22.0 (Official Build) dev-channel eve

What steps will reproduce the problem?
(1) open a new tab
(2) select the omnibox
(3) hold down a key (like "f")
(4) observe its speed
(5) while still holding down the key, start moving the mouse cursor around
(6) watch the system stutter as the mouse cursor is continuously shown/hidden

What is the expected result?
there should be a delay after a mouse input event (like 500 msec?) whereby keyboard inputs would not cause it to be hidden

What happens instead?
the system gets pretty janky and inputs stutter while the mouse is being moved
 
Components: -UI UI>Input
Cc: afakhry@chromium.org osh...@chromium.org sadrul@chromium.org w...@chromium.org
Not sure who should work on this.
Labels: Hotlist-GoodFirstBug
Owner: afakhry@chromium.org
Status: Assigned (was: Untriaged)
I'll take it for now.
Owner: andrewxu@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/929c1eea7c58e4d656a57837e6161c88d79cbec8

commit 929c1eea7c58e4d656a57837e6161c88d79cbec8
Author: Andrew Xu <andrewxu@chromium.org>
Date: Thu Sep 13 17:34:48 2018

Not hiding the cursor when pressing the key repeatedly

If the KeyEvent has EF_IS_REPEAT flag, the cursor should not be
hidden.

In original code, when user moves the mouse while holding down
the key, UI looks weird.

R=afakhry@chromium.org

(cherry picked from commit 7b87a014ee5d90017b5c1027297684aa27aa5296)

Bug:  855163 
Test: ash unittests
Change-Id: Ib1fa6cb7b6002ab38e9c177edafd735d2114f4d1
Reviewed-on: https://chromium-review.googlesource.com/1191328
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591060}
[modify] https://crrev.com/929c1eea7c58e4d656a57837e6161c88d79cbec8/ash/display/mouse_cursor_event_filter_unittest.cc
[modify] https://crrev.com/929c1eea7c58e4d656a57837e6161c88d79cbec8/ash/wm/cursor_manager_chromeos.cc

Status: Fixed (was: Assigned)

Sign in to add a comment