New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 855157 link

Starred by 1 user
Status: Fixed
Owner:
haddowk@chromium.org
Closed: Jun 2018
Cc:
█ mattmallett@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Harden external - storage init script

Project Member Reported by haddowk@chromium.org, Jun 21 2018 

It has been observed in logs times when the readlink command is failing

+ set -e
+ logger -t moblab-external-storage-init Starting
+ readlink -f /dev/disk/by-label/MOBLAB-STORAGE
+ usb_drive=
+ set -e

ensure that if readlink fails the script does not exit but continues assuming no external storage
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/25c620edce95cdf329625b651d669e281542307b

commit 25c620edce95cdf329625b651d669e281542307b
Author: Keith Haddow <haddowk@chromium.org>
Date: Sat Jun 23 05:51:24 2018

[moblab] Continue processing the script even if readlink fails

TEST=built and tested on moblab
BUG= chromium:855157 

Change-Id: I46903e1162f0b92fb126383cd51ae40866edb7c2
Reviewed-on: https://chromium-review.googlesource.com/1112758
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Matt Mallett <mattmallett@chromium.org>

[modify] https://crrev.com/25c620edce95cdf329625b651d669e281542307b/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-external-storage-init.conf

Comment 2 by haddowk@chromium.org, Jun 23 2018

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 23 2018

Labels: merge-merged-release-R68-10718.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/1af2e8b5eac2b10b8d48386416c0f4a651296df8

commit 1af2e8b5eac2b10b8d48386416c0f4a651296df8
Author: Keith Haddow <haddowk@chromium.org>
Date: Sat Jun 23 06:05:11 2018

[moblab] Continue processing the script even if readlink fails

TEST=built and tested on moblab
BUG= chromium:855157 

Change-Id: I46903e1162f0b92fb126383cd51ae40866edb7c2
Reviewed-on: https://chromium-review.googlesource.com/1112758
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Matt Mallett <mattmallett@chromium.org>
(cherry picked from commit 25c620edce95cdf329625b651d669e281542307b)
Reviewed-on: https://chromium-review.googlesource.com/1112400
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Trybot-Ready: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/1af2e8b5eac2b10b8d48386416c0f4a651296df8/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-external-storage-init.conf
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 23 2018

Labels: merge-merged-release-R67-10575.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/584da5d2c29f2a676ec410b765dc71fad251cb82

commit 584da5d2c29f2a676ec410b765dc71fad251cb82
Author: Keith Haddow <haddowk@chromium.org>
Date: Sat Jun 23 06:07:17 2018

[moblab] Continue processing the script even if readlink fails

TEST=built and tested on moblab
BUG= chromium:855157 

Change-Id: I46903e1162f0b92fb126383cd51ae40866edb7c2
Reviewed-on: https://chromium-review.googlesource.com/1112758
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Matt Mallett <mattmallett@chromium.org>
(cherry picked from commit 25c620edce95cdf329625b651d669e281542307b)
Reviewed-on: https://chromium-review.googlesource.com/1112401
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Trybot-Ready: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/584da5d2c29f2a676ec410b765dc71fad251cb82/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-external-storage-init.conf
►

Sign in to add a comment