"updating..." always there on settings->extension page. |
||||
Issue descriptionChrome OS 10718.29.0, 68.0.3440.34 Please specify Cr-* of the system to which this bug/feature applies (add the label below). Steps To Reproduce: (1)Open extension page from settings window. (2)Click on Update button (3) Expected Result: should be disappear "updating..."button after sometime. Actual Result: Observe the left bottom of the screen, "updating..." always there. How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) What is the impact to the user, and is there a workaround? If so, what is it? Please provide any additional information below. Attach a screen shot or log if possible. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Dec 7
,
Dec 7
I just tried this on Chrome 70.0.3538.110 on Linux to see if I could reproduce, but seems to be functioning as expected: 1. Press Update, 2. "Updating..." shows then is replaced by "Extensions Updated" 3. Then the toast goes away. Does this still reproduce for you? Are there any extensions that might be taking a long time to update?
,
Dec 7
@dhaddock: UI>Browser>ExtensionsManagement is the correct component for bugs referring to the chrome://extensions page. UI>Settings is for chrome://settings.
,
Dec 7
,
Dec 7
The way I'm reproducing this, the auth fails when trying to update an extension and retries up to 10 times. This takes a really, really long time so it looks like the toast gets created and then never disappears, but it does eventually do go away. Interestingly, after it tries 10 times and still fails, the back-end seems to still indicate a success so a "Extensions Updated" toast is shown. Looking into why an error isn't thrown instead.
,
Dec 12
From what I can tell, it looks like the extensions back-end only notifies the front-end when updates/downloads are finished and doesn't differentiate between success/failures. See how in [1] and [2], there's only one callback for when things finish and how in [3] we don't ever reject the Promise. I would expect that the back-end would be able to throw an error if something goes wrong. @rdcronin, can you advise? [1] https://cs.chromium.org/chromium/src/chrome/browser/extensions/updater/extension_updater.cc?type=cs&sq=package:chromium&g=0&l=511 [2] https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/developer_private/developer_private_api.cc?type=cs&q=DeveloperPrivateAutoUpdateFunction&sq=package:chromium&g=0&l=713 [3] https://cs.chromium.org/chromium/src/chrome/browser/resources/md_extensions/service.js?type=cs&q=updateAllExtensions&sq=package:chromium&g=0&l=313 |
||||
►
Sign in to add a comment |
||||
Comment 1 by rdevlin....@chromium.org
, Jun 22 2018Components: -Platform>Extensions UI>Browser>ExtensionsManagement