New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 855141 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Clean up the notification bridge for offline pages.

Project Member Reported by romax@chromium.org, Jun 21 2018

Issue description

In https://chromium-review.googlesource.com/c/chromium/src/+/1103549, in order to fix the notification bug a temporary fix is used.

We should investigate to see if it's possible to have a cleaner/more generic way to hide notifications from the UI and avoid unimportant updates. (In this case the update invoked by Prefetched pages with their thumbnail updated.

Possible ways:
- Introduce a new method in observer interface for thumbnail updates.
- Have a more generalized way to identify uninterested offline items and avoid showing notification for them.
 
Labels: Hotlist-Fixit
Status: Available (was: Untriaged)
Some design is needed before the fixit starts.
I think this can be fixed by adding a new field in OfflineItem for shouldNotify. If false, then don't update notifications for the item at all...

Sign in to add a comment