New issue
Advanced search Search tips

Issue 855133 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 847665



Sign in to add a comment

Add a LUCI builder for recipe-based analyzer for chromium project

Project Member Reported by qyears...@chromium.org, Jun 21 2018

Issue description

In order for a build to be triggered by buildbucket that runs a recipe, there must be a builder.

I think that there will have to be at least one builder per project (chromium, fuchsia etc.). TBD: Will we require a separate builder for each platform?

Buildbucket API:
https://docs.google.com/document/d/10BH6oSq_UEtdSdhrguEuV4hx-JxY7jzFcgs1OCHcniQ/edit#

This builder would be like a try bot, although it ordinarily wouldn't be triggered by users directly, and normally wouldn't need to be viewed on the milo console (although it could be).
 

Comment 1 by no...@chromium.org, Jun 21 2018

for simplicity, you may want to start with one internal builder in infra_internal project and keep the builder an impl detail of tricium, so that each project doesn't have to define one

Comment 2 by no...@chromium.org, Jun 21 2018

Labels: -Type-Bug Type-Feature
Cc: juliehockett@google.com
Status: Started (was: Assigned)
Was a decision ever come to on how to set this up? I'm happy so do anything necessary to get it up and running on the Fuchsia repos. 
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/c4be983061a342ce7e1c2e11e6bcc94112a8ddb9

commit c4be983061a342ce7e1c2e11e6bcc94112a8ddb9
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Mon Jul 09 18:19:17 2018

[tricium] Add a tricium analyzer recipe that does nothing

This is intended to be used as the default recipe for the
tricium builder, which shouldn't actually be used in runs
triggered by Tricium.

Bug:  855133 
Change-Id: I2403b236ded42490c92736ce6bd27bce2956183e
Reviewed-on: https://chromium-review.googlesource.com/1128567
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[add] https://crrev.com/c4be983061a342ce7e1c2e11e6bcc94112a8ddb9/recipes/recipes/tricium_noop.py
[add] https://crrev.com/c4be983061a342ce7e1c2e11e6bcc94112a8ddb9/recipes/recipes/tricium_noop.expected/default.json
[modify] https://crrev.com/c4be983061a342ce7e1c2e11e6bcc94112a8ddb9/recipes/README.recipes.md

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 31

Labels: merge-merged-config
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/1855a3ffa7fb46b58530f440e8eb6eb7ab52c2aa

commit 1855a3ffa7fb46b58530f440e8eb6eb7ab52c2aa
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Tue Jul 31 16:43:31 2018

[tricium] Add a builder in infra buildbucket config

This would add a new bucket (luci.infra.tricium) with one builder
(tricium); this builder would be used by Tricium to run recipe-based
analyzers for public repos.

Bug:  855133 
Change-Id: Ib05a3eafbf38937b27365c9a7fa24d86194268e5
Reviewed-on: https://chromium-review.googlesource.com/1145475
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/1855a3ffa7fb46b58530f440e8eb6eb7ab52c2aa/cr-buildbucket.cfg

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7cec9e5bdee7b9e9afe49b74c8cb5e7ea7453900

commit 7cec9e5bdee7b9e9afe49b74c8cb5e7ea7453900
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Fri Aug 03 18:18:26 2018

Add tricium builder to luci-milo config

This is a single builder that would do builds for all recipe-based
tricium analyzers; the recipe and dimensions would be overridden
in requests from Tricium.

Bug:  855133 
Change-Id: I70353c6d63870efdb448d6d02fb8309071529da3
Reviewed-on: https://chromium-review.googlesource.com/1162432
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/7cec9e5bdee7b9e9afe49b74c8cb5e7ea7453900/luci-milo.cfg

Status: Fixed (was: Started)

Sign in to add a comment