New issue
Advanced search Search tips

Issue 855115 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

The lines in other devices screen on iPad is not clean.

Project Member Reported by vbhatso...@chromium.org, Jun 21 2018

Issue description

App Version: 69.0.3465.0 canary
iOS Version: 11.4, 10.3.3
Device: iPad ONLY
URL: 

Precondition:
Browse at least 10 pages and close the tabs to generate recent history

Steps to reproduce:
  1.Launch chrome canary.
  2.Go to Tab-switcher mode.
  3.Tap on Other devices.
 
Observed results:
The lines in other devices screen on iPad is not clean.

Expected results:
The lines in other devices screen on iPad should be clean.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): NA on M67
Bug reproducible on the current beta channel build (App Version, iOS Version): NA on M68
Link to video/image:  
https://drive.google.com/file/d/1c7MM0LoKDDZdAh6C4I1iLJ5vjClDmU6L/view?usp=sharing


 
Labels: -Restrict-View-Google S-Recent-Tabs-Cells
Cc: marq@chromium.org edchin@chromium.org
Components: UI>Browser>Mobile>TabSwitcher
Labels: Q2
Owner: sczs@chromium.org
Status: Assigned (was: Untriaged)
Cc: sczs@chromium.org
Labels: -Pri-2 Pri-1
Owner: edchin@chromium.org

Comment 4 by edchin@chromium.org, Jun 26 2018

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b0645819ae9ea8004763edbb6bda7b1f9a84fbb

commit 1b0645819ae9ea8004763edbb6bda7b1f9a84fbb
Author: edchin <edchin@chromium.org>
Date: Tue Jun 26 20:26:42 2018

[ios] Fix cell separators in recent tabs in tab grid

Since iOS 9, table views automatically shorten their width and center
content on large iPads so that the content is more readable in larger
screens.

The cell separator is following the shortened width on recent tabs in
tab grid. This CL makes the separator fit the whole table.

Screenshot:
https://drive.google.com/open?id=12CFWGsy9KQ7vPZINT-mBZkJzhHVy_PXL

Bug:  855115 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iaa56257c56c511a0cb315e579737396c7e5e3c78
Reviewed-on: https://chromium-review.googlesource.com/1115473
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570514}
[modify] https://crrev.com/1b0645819ae9ea8004763edbb6bda7b1f9a84fbb/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm

Status: Verified (was: Fixed)
Verified in 69.0.3479.0 Canary on iPad Air(iOS 11.4) and iPad Air(iOS 10.3.3)

The lines in other devices screen on iPad is now looks good

Link to video: 
https://drive.google.com/file/d/1Yq7KDkPlULzF4OApa-Irb0dC0C_0g7w5/view?usp=sharing

Sign in to add a comment