New issue
Advanced search Search tips

Issue 855091 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 821996
issue 820495
issue 822061



Sign in to add a comment

Insufficient contrast for background tab text

Project Member Reported by pkasting@chromium.org, Jun 21 2018

Issue description

Attached is a screenshot of my home machine, which uses a custom frame color.  The contrast ratio of the background tab text (#d2d9d2) to the frame (#647c64) is 3.16, which is well below minimum accessibility specs, and low enough that I have to focus on tab titles to read them instead of being able to do it at a glance.  In my first couple days of usage of refresh, this is probably the most troublesome aspect.  I suspect bettes@ was trying to make background tabs fade into the frame a bit more, but the net effect here is decreasing usability.

pbos@ and bsep@ both shared similar sentiments that the contrast was too low for other screenshots posted in the chat channel.  pbos@ volunteered to take this on.

I think we need to change background tabs/the NTB to either do what the caption buttons do (always use white/GG900), or else compute the contrast ratio of how we're blending, and limit the blend amount to maintain a 4.5 contrast ratio.

Note that in this case, using white text would produce a ratio of 4.55.
 
contrast.png
9.5 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0728316a5c4a05ad6e14e4027d7ed9a009ea7391

commit 0728316a5c4a05ad6e14e4027d7ed9a009ea7391
Author: Peter Boström <pbos@chromium.org>
Date: Thu Jun 21 18:59:52 2018

Significantly increase contrast for inactive tabs

This changes tab text color from ~GG200 and GG700 to white and GG800
which makes inactive tabs in both incognito and default theme easier to
read. It's especially important for themed-frame windows though where
very light grey on white provided significantly worse contrast.

This also increases tab-separator opacity to better match the increased
contrast.

Bug:  chromium:855091 
Change-Id: I0ec7208d6b1158e4abbb361acd119d3a48020f10
Reviewed-on: https://chromium-review.googlesource.com/1109271
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569343}
[modify] https://crrev.com/0728316a5c4a05ad6e14e4027d7ed9a009ea7391/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/0728316a5c4a05ad6e14e4027d7ed9a009ea7391/chrome/browser/ui/views/frame/browser_non_client_frame_view.h
[modify] https://crrev.com/0728316a5c4a05ad6e14e4027d7ed9a009ea7391/chrome/browser/ui/views/tabs/new_tab_button.cc

Comment 2 by pbos@chromium.org, Jun 21 2018

Status: Fixed (was: Assigned)
This should be fixed now. As a separate bullet we might want to consider using GG900 directly for the dark text, this wasn't done in this change as GG800 is used for text in the active tab, omnibox, etc.

If we want to do GG900 for text everywhere (which I'd agree with for contrast reasons) this needs to be an all-encompassing change or background tabs would have darker text than foreground and omnibox, which seems inconsistent.

Using GG800 or GG900 for NTB directly was very strong however (as NTB is about 3 dp wide, aka "very bold" compared to the text). It was also weird that it would be darker than the toolbar buttons just below it. Hence we changed NTB to use Chrome icon grey when dark and match the toolbar buttons.

Sign in to add a comment