New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 855088 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Move toggle to sync addresses and cards from Google Pay from Autofill settings to Sync settings in iOS

Project Member Reported by mahmadi@chromium.org, Jun 21 2018

Issue description

This is one, inconsistent with the other platforms and two, results in a few odd flows:
1) The toggle still shows but does nothing if user is signed out of Chrome.
2) The toggle can be switched on/off, even if "Sync Everything" is switched on.
 
Cc: ma...@chromium.org durgapandey@chromium.org ew...@chromium.org
Components: UI>Browser>Autofill>UI
Labels: -Pri-3 M-69 OS-iOS Pri-2
Owner: mahmadi@chromium.org
Status: Assigned (was: assin)
autofill.png
57.6 KB View Download

Comment 3 by ew...@chromium.org, Jun 21 2018

Thanks Moe! Just to add a bit more context: in general, I'm in favor of improving this holistically across all platforms in the future (e.g. providing a way for users to access the payments sync setting from autofill settings, maybe via a link to sync settings). But glad that we're at least making things consistent for now :)

Comment 4 by ma...@chromium.org, Jun 21 2018

Agreed, would be great to fix now. 
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0db6397a68993c6d1fa8986a09e4dce11dc48779

commit 0db6397a68993c6d1fa8986a09e4dce11dc48779
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Tue Jul 10 18:20:53 2018

[AF][IOS] Moves Autofill's Google Pay import switch to sync settings page

before: https://drive.google.com/file/d/1itVUr0s6pPW9roOzamc4t3MW0644gI-n/view
after: https://drive.google.com/file/d/1ENvOGwgE21zKCIANcfsB3Y_fT1erwo4m/view

Bug:855088

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie4abd38ea871d26e128c99a5f3012421cb714218
Reviewed-on: https://chromium-review.googlesource.com/1128186
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573817}
[modify] https://crrev.com/0db6397a68993c6d1fa8986a09e4dce11dc48779/ios/chrome/browser/ui/settings/autofill_collection_view_controller.mm
[modify] https://crrev.com/0db6397a68993c6d1fa8986a09e4dce11dc48779/ios/chrome/browser/ui/settings/autofill_collection_view_controller_unittest.mm
[modify] https://crrev.com/0db6397a68993c6d1fa8986a09e4dce11dc48779/ios/chrome/browser/ui/settings/autofill_settings_egtest.mm
[modify] https://crrev.com/0db6397a68993c6d1fa8986a09e4dce11dc48779/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm
[modify] https://crrev.com/0db6397a68993c6d1fa8986a09e4dce11dc48779/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller_unittest.mm

Cc: linds...@chromium.org dennishu@google.com
Status: Fixed (was: Started)
Hi Lindsay, This setting has now moved to the Sync settings page. Can we have someone from the test team verify this change? Steps to test:

1) Sign into Chrome.
2) Make sure user has credit cards in Google Pay by visiting https://pay.google.com/payments/u/0/home#paymentMethods
3) Verify the following interactions with the Google Pay toggle in the Sync settings.
 a) Turning on "Sync everything" should disable and turn on Google Pay toggle.
 b) Turning off Autofill toggle should disable and turn off Google Pay toggle.
 c) Turning on Autofill toggle should enable and turn on Google Pay toggle.
 d) Must be able to turn on/off Google Pay toggle independently when enabled.

Turning off this toggle should stop showing credit cards in the Autofill settings page. Note that this toggle doesn't affect addresses. Since the request to fetch credit cards from Google Pay is asynchronous, close Chrome settings and reopen it after changing the toggle in order to trigger the Autofill settings to get updated.
Status: Verified (was: Fixed)
Verified 70.0.3501.0 Canary, iPhone X iOS 11.4 , iPad Pro 12'9 iOS 11.3.1.
Testing done as below:
As per Steps in #7 
Account used is a managed account (Corp account in this case) to Sign in to Chrome.Also added a real Credit card number in for it to work in https://pay.google.com/payments/u/0/home#paymentMethods

a)Turning on "Sync everything" should disable and turn on Google Pay toggle. - PASS
b)) Turning off Autofill toggle should disable and turn off Google Pay toggle. - PASS
c) Turning on Autofill toggle should enable and turn on Google Pay toggle. - PASS
d) Must be able to turn on/off Google Pay toggle independently when enabled. - PASS
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86055195c43367569bedbfa38f84d7da1b8176d4

commit 86055195c43367569bedbfa38f84d7da1b8176d4
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Tue Jul 31 18:41:34 2018

[AF][IOS] Use same title for the Google Pay toggle on Desktop and iOS

iOS: https://drive.google.com/file/d/198YXGP4TW8VcZ-scZy6jf-8GPHLRQc2U/view?usp=sharing
Desktop: https://drive.google.com/file/d/1ouJGiWYjg-IfIaMdxKPXGh1sN3EDrYxQ/view?usp=sharing

Bug:  855088 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I92786a9aa33e228297352b9dfaf5730b00daf629
Reviewed-on: https://chromium-review.googlesource.com/1155484
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579492}
[modify] https://crrev.com/86055195c43367569bedbfa38f84d7da1b8176d4/chrome/app/settings_strings.grdp
[modify] https://crrev.com/86055195c43367569bedbfa38f84d7da1b8176d4/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/86055195c43367569bedbfa38f84d7da1b8176d4/components/autofill_strings.grdp
[modify] https://crrev.com/86055195c43367569bedbfa38f84d7da1b8176d4/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/86055195c43367569bedbfa38f84d7da1b8176d4/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm
[modify] https://crrev.com/86055195c43367569bedbfa38f84d7da1b8176d4/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller_unittest.mm

Labels: Merge-Request-69
Requesting merge into M69 for the https://chromium-review.googlesource.com/1155484. Note the CL in question involves string changes.
Project Member

Comment 11 by sheriffbot@chromium.org, Jul 31

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 34 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Are the string changes critical for M69? Can we possibly take the change but without the string changes?

Also let's get canary verification for this please.
Labels: -Hotlist-Merge-Review -Merge-Review-69
Not critical AFAIK. Since string merges aren't straightforward let's not merge.
Thank you.

Sign in to add a comment