New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 855063 link

Starred by 1 user
Status: Fixed
Owner:
█ amyqiu@google.com
Last visit > 30 days ago
Closed: Jul 2
Cc:
sadrul@chromium.org
eyaich@chromium.org
chiniforooshan@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 855062
Blocking:
issue 760553



Sign in to add a comment

Remove legacy smoothness, rendering & scheduler benchmarks

Project Member Reported by nednguyen@chromium.org, Jun 21 2018 
Now AmyQiu has merged all the benchmarks to rendering.desktop & rendering.mobile, we should be ready to remove legacy smoothness, rendering & scheduler benchmarks once the alerts are set

*The only exception is smoothness.tough_pinch_zoom_cases (due to issue 852373)

Comment 1 by nednguyen@chromium.org, Jun 21 2018

Blocking: 760553
Labels: -Pri-3 Pri-1
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e903f5e67c0cd1582752d473ecf49582d4857457

commit e903f5e67c0cd1582752d473ecf49582d4857457
Author: Amy Qiu <amyqiu@google.com>
Date: Fri Jun 29 18:34:59 2018

Delete smoothness benchmarks

Since the smoothness.__ benchmarks have been merged into
rendering.desktop and rendering.mobile, remove the benchmarks and the
no longer necessary page set json files. For now, add the deleted
benchmarks to NON_TELEMETRY_BENCHMARKS in perf_data_generator.py to
avoid errors related to the sharding map.

For the fetch_benchmark_deps_unittest that used
smoothness.top_25_smooth, change to use system_health.common_desktop
because using rendering.desktop fails the "no static local files"
assertion.

Also, remove tough_ad_cases.py completely because it is no longer used.

Bug:  855063 
Change-Id: I9b3c0a46b7704b520f8d44479fcd5385c78eb573
Reviewed-on: https://chromium-review.googlesource.com/1120345
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Amy Qiu <amyqiu@google.com>
Cr-Commit-Position: refs/heads/master@{#571559}
[modify] https://crrev.com/e903f5e67c0cd1582752d473ecf49582d4857457/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/e903f5e67c0cd1582752d473ecf49582d4857457/tools/perf/benchmark.csv
[modify] https://crrev.com/e903f5e67c0cd1582752d473ecf49582d4857457/tools/perf/benchmarks/smoothness.py
[modify] https://crrev.com/e903f5e67c0cd1582752d473ecf49582d4857457/tools/perf/core/shard_maps/desktop_26_shard_map.json
[modify] https://crrev.com/e903f5e67c0cd1582752d473ecf49582d4857457/tools/perf/core/shard_maps/mobile_39_shard_map.json
[modify] https://crrev.com/e903f5e67c0cd1582752d473ecf49582d4857457/tools/perf/expectations.config
[modify] https://crrev.com/e903f5e67c0cd1582752d473ecf49582d4857457/tools/perf/fetch_benchmark_deps_unittest.py
[delete] https://crrev.com/5f11548b7ddf26564dbb1bbf5ebf001db48ac6ac/tools/perf/page_sets/data/key_desktop_move_cases.json
[delete] https://crrev.com/5f11548b7ddf26564dbb1bbf5ebf001db48ac6ac/tools/perf/page_sets/data/pathological_mobile_sites.json
[delete] https://crrev.com/5f11548b7ddf26564dbb1bbf5ebf001db48ac6ac/tools/perf/page_sets/data/tough_ad_cases.json
[delete] https://crrev.com/5f11548b7ddf26564dbb1bbf5ebf001db48ac6ac/tools/perf/page_sets/data/tough_canvas_cases.json
[delete] https://crrev.com/5f11548b7ddf26564dbb1bbf5ebf001db48ac6ac/tools/perf/page_sets/data/tough_filters_cases.json
[delete] https://crrev.com/5f11548b7ddf26564dbb1bbf5ebf001db48ac6ac/tools/perf/page_sets/data/tough_image_decode_cases.json
[delete] https://crrev.com/5f11548b7ddf26564dbb1bbf5ebf001db48ac6ac/tools/perf/page_sets/data/tough_path_rendering_cases.json
[delete] https://crrev.com/5f11548b7ddf26564dbb1bbf5ebf001db48ac6ac/tools/perf/page_sets/data/tough_webgl_cases.json
[modify] https://crrev.com/e903f5e67c0cd1582752d473ecf49582d4857457/tools/perf/page_sets/rendering/image_decoding_cases.py
[modify] https://crrev.com/e903f5e67c0cd1582752d473ecf49582d4857457/tools/perf/page_sets/rendering/key_desktop_move_cases.py
[modify] https://crrev.com/e903f5e67c0cd1582752d473ecf49582d4857457/tools/perf/page_sets/rendering/maps.py
[modify] https://crrev.com/e903f5e67c0cd1582752d473ecf49582d4857457/tools/perf/page_sets/rendering/pathological_mobile_sites.py
[modify] https://crrev.com/e903f5e67c0cd1582752d473ecf49582d4857457/tools/perf/page_sets/rendering/tough_canvas_cases.py
[modify] https://crrev.com/e903f5e67c0cd1582752d473ecf49582d4857457/tools/perf/page_sets/rendering/tough_filters_cases.py
[modify] https://crrev.com/e903f5e67c0cd1582752d473ecf49582d4857457/tools/perf/page_sets/rendering/tough_image_decode_cases.py
[modify] https://crrev.com/e903f5e67c0cd1582752d473ecf49582d4857457/tools/perf/page_sets/rendering/tough_path_rendering_cases.py
[modify] https://crrev.com/e903f5e67c0cd1582752d473ecf49582d4857457/tools/perf/page_sets/rendering/tough_scheduling_cases.py
[modify] https://crrev.com/e903f5e67c0cd1582752d473ecf49582d4857457/tools/perf/page_sets/rendering/tough_texture_upload_cases.py
[modify] https://crrev.com/e903f5e67c0cd1582752d473ecf49582d4857457/tools/perf/page_sets/rendering/tough_webgl_cases.py
[delete] https://crrev.com/5f11548b7ddf26564dbb1bbf5ebf001db48ac6ac/tools/perf/page_sets/tough_ad_cases.py
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c3f5062dd6d1f45dcf436333bfd35975f4570de

commit 6c3f5062dd6d1f45dcf436333bfd35975f4570de
Author: Amy Qiu <amyqiu@google.com>
Date: Fri Jun 29 22:25:59 2018

Delete thread times benchmarks

Now that the thread_times.__ benchmarks are merged into the rendering
benchmarks, remove benchmarks in thread_times.py and unnecessary
page set json files. Since oop_raster.py benchmarks use
thread_times._ThreadTimes, leave this for now.

Remove page_sets/polymer.py because it has been entirely replaced by
page_sets/rendering/polymer.py.

Bug:  855063 
Change-Id: Ie78a503d3a0b09ad696b6d375c2af7b60483d39f
Reviewed-on: https://chromium-review.googlesource.com/1120949
Commit-Queue: Amy Qiu <amyqiu@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#571678}
[modify] https://crrev.com/6c3f5062dd6d1f45dcf436333bfd35975f4570de/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/6c3f5062dd6d1f45dcf436333bfd35975f4570de/tools/perf/benchmark.csv
[modify] https://crrev.com/6c3f5062dd6d1f45dcf436333bfd35975f4570de/tools/perf/benchmarks/thread_times.py
[modify] https://crrev.com/6c3f5062dd6d1f45dcf436333bfd35975f4570de/tools/perf/core/shard_maps/desktop_26_shard_map.json
[modify] https://crrev.com/6c3f5062dd6d1f45dcf436333bfd35975f4570de/tools/perf/core/shard_maps/mobile_39_shard_map.json
[modify] https://crrev.com/6c3f5062dd6d1f45dcf436333bfd35975f4570de/tools/perf/expectations.config
[delete] https://crrev.com/339c012e89e3a2f86c3818afb199da24f754552c/tools/perf/page_sets/data/polymer.json
[delete] https://crrev.com/339c012e89e3a2f86c3818afb199da24f754552c/tools/perf/page_sets/data/simple_mobile_sites.json
[delete] https://crrev.com/339c012e89e3a2f86c3818afb199da24f754552c/tools/perf/page_sets/data/tough_compositor_cases.json
[delete] https://crrev.com/339c012e89e3a2f86c3818afb199da24f754552c/tools/perf/page_sets/polymer.py
[modify] https://crrev.com/6c3f5062dd6d1f45dcf436333bfd35975f4570de/tools/perf/page_sets/rendering/key_hit_test_cases.py
[modify] https://crrev.com/6c3f5062dd6d1f45dcf436333bfd35975f4570de/tools/perf/page_sets/rendering/key_idle_power_cases.py
[modify] https://crrev.com/6c3f5062dd6d1f45dcf436333bfd35975f4570de/tools/perf/page_sets/rendering/key_noop_cases.py
[modify] https://crrev.com/6c3f5062dd6d1f45dcf436333bfd35975f4570de/tools/perf/page_sets/rendering/simple_mobile_sites.py
[modify] https://crrev.com/6c3f5062dd6d1f45dcf436333bfd35975f4570de/tools/perf/page_sets/rendering/tough_compositor_cases.py
[modify] https://crrev.com/6c3f5062dd6d1f45dcf436333bfd35975f4570de/tools/perf/page_sets/rendering/tough_scrolling_cases.py
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96874db4bed9cc3251b6e275b6a4017557a89fcf

commit 96874db4bed9cc3251b6e275b6a4017557a89fcf
Author: Emily Hanley <eyaich@google.com>
Date: Mon Jul 02 19:00:20 2018

Re-generating shard maps for FYI bots and cleaning up un-used

Bug:  855063 , 713357 
Change-Id: I79e5e5eac6283493f0eb83771fe6edbde1a0496e
Reviewed-on: https://chromium-review.googlesource.com/1122843
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571958}
[modify] https://crrev.com/96874db4bed9cc3251b6e275b6a4017557a89fcf/tools/perf/core/perf_data_generator.py
[modify] https://crrev.com/96874db4bed9cc3251b6e275b6a4017557a89fcf/tools/perf/core/shard_maps/android_go_14_shard_map.json
[delete] https://crrev.com/17d0f0fb2457a1ff37f9b248bb5e6526235aabaa/tools/perf/core/shard_maps/benchmark_android_bot_map.json
[delete] https://crrev.com/17d0f0fb2457a1ff37f9b248bb5e6526235aabaa/tools/perf/core/shard_maps/benchmark_desktop_bot_map.json
[delete] https://crrev.com/17d0f0fb2457a1ff37f9b248bb5e6526235aabaa/tools/perf/core/shard_maps/desktop_26_shard_map.json
[delete] https://crrev.com/17d0f0fb2457a1ff37f9b248bb5e6526235aabaa/tools/perf/core/shard_maps/desktop_5_shard_map.json
[modify] https://crrev.com/96874db4bed9cc3251b6e275b6a4017557a89fcf/tools/perf/core/shard_maps/mac1012_5_shard_map.json
[delete] https://crrev.com/17d0f0fb2457a1ff37f9b248bb5e6526235aabaa/tools/perf/core/shard_maps/mobile_21_shard_map.json
[delete] https://crrev.com/17d0f0fb2457a1ff37f9b248bb5e6526235aabaa/tools/perf/core/shard_maps/mobile_39_shard_map.json
[delete] https://crrev.com/17d0f0fb2457a1ff37f9b248bb5e6526235aabaa/tools/perf/core/shard_maps/mobile_7_shard_map.json
[modify] https://crrev.com/96874db4bed9cc3251b6e275b6a4017557a89fcf/tools/perf/core/shard_maps/pixel2_7_shard_map.json
[modify] https://crrev.com/96874db4bed9cc3251b6e275b6a4017557a89fcf/tools/perf/core/shard_maps/pixel2_webview_7_shard_map.json

Comment 6 by nednguyen@chromium.org, Jul 2

Status: Fixed (was: Untriaged)
Thanks Amy!
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/331acd06b6008bac0efbbe0acfaf05e76d35d293

commit 331acd06b6008bac0efbbe0acfaf05e76d35d293
Author: Emily Hanley <eyaich@google.com>
Date: Tue Jul 03 17:17:39 2018

Removing deleted benchmarks from obbs shard map

Bug:855063
NOTRY=true
TBR=nednguyen@google.com

Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: Ica527284a240bf2251e2a57c26729c541577aa44
Reviewed-on: https://chromium-review.googlesource.com/1124943
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572264}
[modify] https://crrev.com/331acd06b6008bac0efbbe0acfaf05e76d35d293/tools/perf/core/shard_maps/benchmark_bot_map.json
►

Sign in to add a comment