Picture-in-Picutre: when video quality changes, the window reverts to default position and size |
|||
Issue descriptionChrome Version : 69.0.3464.0 OS Version: Linux What steps will reproduce the problem? 1. Play adaptive bitrate video in Picture-in-Picture 2. Move it to top left corner and max size 3. Wait for an ABR event What is the expected result? Video quality changes but window isn't impacted. What happens instead of that? Video quality changes and window moves back to bottom right corner of current screen and is back to tiny size.
,
Jun 26 2018
I believe https://chromium-review.googlesource.com/c/chromium/src/+/1089331 helps but window still moves back to bottom right corner. I can have a look as well as part of the CL.
,
Jun 26 2018
It's not really related to the CL you pointed to as the issue isregarding adaptive. You can test with https://mounirlamouri.github.io/bunny-player/index.html for example.
,
Jun 27 2018
,
Jul 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40dc0c129cc346e06e9a282c97adad104ade45e1 commit 40dc0c129cc346e06e9a282c97adad104ade45e1 Author: Mounir Lamouri <mlamouri@chromium.org> Date: Thu Jul 05 15:43:18 2018 Picture-in-Picture: do not reset window size and position when SurfaceId changes. In other words, while the window is visible, it will keep its size and position and only resize to match the aspect ratio of the video. Bug: 855059 Change-Id: I4dbe57653670883b046ef7ee2994d7574764827d Reviewed-on: https://chromium-review.googlesource.com/1126559 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#572804} [modify] https://crrev.com/40dc0c129cc346e06e9a282c97adad104ade45e1/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc [modify] https://crrev.com/40dc0c129cc346e06e9a282c97adad104ade45e1/chrome/browser/ui/views/overlay/overlay_window_views.cc
,
Jul 5
|
|||
►
Sign in to add a comment |
|||
Comment 1 by mlamouri@chromium.org
, Jun 25 2018Owner: mlamouri@chromium.org