New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 855042 link

Starred by 2 users
Status: Assigned
Owner:
falken@chromium.org
Cc:
falken@chromium.org
█ loonyb...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 862643



Sign in to add a comment

UseCounter test for Navigation Preload is incorrect and failing

Project Member Reported by loonyb...@chromium.org, Jun 21 2018 
What steps will reproduce the problem?
On a clean build, test the thress promise_test_s in third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation_preload/use-counter.html, one promise_test at a time (comment out the other ones). 

What is the expected result?
The third test is expected to record usage of service worker navigation preload.

What happens instead?
The third test starts failing.

Comment 1 by falken@chromium.org, Jul 3

Summary: UseCounter test for Navigation Preload is incorrect and failing (was: tests for service worker navigation preload are incorrect)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c97e35c2ca0bf62c7082e3550c62c82def3ef186

commit c97e35c2ca0bf62c7082e3550c62c82def3ef186
Author: Luna Lu <loonybear@chromium.org>
Date: Tue Jul 10 21:17:52 2018

Moving UseCounter from Page to DocumentLoader

UseCounter is sending usage to the browser side page load metrics to
accurately record usage per page load. However, page load metrics
observer is only created after navigation commits. This means pre-
loading features could lose some usage. We would love to buffer the
pre-loading features and resend to the browser side upon commit.
Page is a challenging place to achieve so since a Page can have
multiple page load, it is hard to know where exactly to reset the
buffer. Therefore, DocumentLoader seems to be a better fit for that.

Design doc: https://docs.google.com/document/d/1yuJ8iPCFPZ5-vZJ30lgc2J8c4Olo2SqfLPY8KXfkRJU/edit
This CL is based on this CL https://chromium-review.googlesource.com/c/chromium/src/+/1100972

Change-Id: If3d52a766db0cd573e4e139f552a49edcf0f90f2

Bug:  828416 , 855042
Change-Id: If3d52a766db0cd573e4e139f552a49edcf0f90f2
Reviewed-on: https://chromium-review.googlesource.com/1079787
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573909}
[modify] https://crrev.com/c97e35c2ca0bf62c7082e3550c62c82def3ef186/third_party/WebKit/LayoutTests/svg/as-image/svgview-references-use-counters-expected.txt
[modify] https://crrev.com/c97e35c2ca0bf62c7082e3550c62c82def3ef186/third_party/WebKit/LayoutTests/svg/as-image/svgview-references-use-counters.html
[add] https://crrev.com/c97e35c2ca0bf62c7082e3550c62c82def3ef186/third_party/WebKit/LayoutTests/virtual/service-worker-servicification/http/tests/serviceworker/navigation_preload/use-counter-expected.txt
[modify] https://crrev.com/c97e35c2ca0bf62c7082e3550c62c82def3ef186/third_party/blink/renderer/bindings/core/v8/binding_security_test.cc
[modify] https://crrev.com/c97e35c2ca0bf62c7082e3550c62c82def3ef186/third_party/blink/renderer/core/css/parser/css_lazy_parsing_test.cc
[modify] https://crrev.com/c97e35c2ca0bf62c7082e3550c62c82def3ef186/third_party/blink/renderer/core/css/parser/css_parser_context.cc
[modify] https://crrev.com/c97e35c2ca0bf62c7082e3550c62c82def3ef186/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/c97e35c2ca0bf62c7082e3550c62c82def3ef186/third_party/blink/renderer/core/frame/deprecation.cc
[modify] https://crrev.com/c97e35c2ca0bf62c7082e3550c62c82def3ef186/third_party/blink/renderer/core/frame/deprecation.h
[modify] https://crrev.com/c97e35c2ca0bf62c7082e3550c62c82def3ef186/third_party/blink/renderer/core/frame/local_frame.cc
[modify] https://crrev.com/c97e35c2ca0bf62c7082e3550c62c82def3ef186/third_party/blink/renderer/core/frame/use_counter.cc
[modify] https://crrev.com/c97e35c2ca0bf62c7082e3550c62c82def3ef186/third_party/blink/renderer/core/frame/use_counter.h
[modify] https://crrev.com/c97e35c2ca0bf62c7082e3550c62c82def3ef186/third_party/blink/renderer/core/frame/use_counter_test.cc
[modify] https://crrev.com/c97e35c2ca0bf62c7082e3550c62c82def3ef186/third_party/blink/renderer/core/html/html_iframe_element.cc
[modify] https://crrev.com/c97e35c2ca0bf62c7082e3550c62c82def3ef186/third_party/blink/renderer/core/inspector/main_thread_debugger.cc
[modify] https://crrev.com/c97e35c2ca0bf62c7082e3550c62c82def3ef186/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/c97e35c2ca0bf62c7082e3550c62c82def3ef186/third_party/blink/renderer/core/loader/document_loader.h
[modify] https://crrev.com/c97e35c2ca0bf62c7082e3550c62c82def3ef186/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/c97e35c2ca0bf62c7082e3550c62c82def3ef186/third_party/blink/renderer/core/page/page.cc
[modify] https://crrev.com/c97e35c2ca0bf62c7082e3550c62c82def3ef186/third_party/blink/renderer/core/page/page.h
[modify] https://crrev.com/c97e35c2ca0bf62c7082e3550c62c82def3ef186/third_party/blink/renderer/core/testing/internals.cc

Comment 3 by loonyb...@chromium.org, Jul 11

Blocking: 862643

Comment 4 by loonyb...@chromium.org, Jul 11

Blocking: -862643

Comment 5 by loonyb...@chromium.org, Jul 11

Blocking: 862643
Cc: falken@chromium.org loonyb...@chromium.org
 Issue 862643  has been merged into this issue.
►

Sign in to add a comment