New issue
Advanced search Search tips

Issue 855039 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 869867



Sign in to add a comment

[LayoutNG] Orthogonal flow root children of table cells get their inline size wrong

Project Member Reported by mstensho@chromium.org, Jun 21 2018

Issue description

Since inline containing block sizes are always required to be definite during block flow layout, we set them to the size of the initial containing block (based on the spec). This may be correct under certain circumstances, but we even do it when the containing block (table cell) size is specified. Now, tables are weird and everything, but one would expect this to work:

<div style="display:table-cell; width:100px; height:100px; background:blue;">
  <div style="writing-mode:vertical-rl; width:50%; height:50%; background:hotpink;"</div>
</div>

There should really be a 50x50 hotpink square in the top left corner of a 100x100 blue square, orthogonal writing mode or not. The immediate reason for it not working, is the table-cell specific bail in ComputeBlockSizeForFragment() (which I believe is more or less the right thing to do).

This is responsible for at least the following failures:
html/details_summary/details-writing-mode-align-center.html
html/details_summary/details-writing-mode-align-left.html
html/details_summary/details-writing-mode-align-right.html
html/details_summary/details-writing-mode.html
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eae93ca8666e70fb28e6ccccb277289f05f8e35b

commit eae93ca8666e70fb28e6ccccb277289f05f8e35b
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Thu Jun 21 16:35:11 2018

[LayoutNG] All html/details_summary tests are caused by the same bug.

Refer to that bug in the test expectations file.

TBR=dgrogan@chromium.org,kojii@chromium.org

Bug:  855039 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I9eb0827a1d56a7a196e862c6580dedb9fdffad3a
Reviewed-on: https://chromium-review.googlesource.com/1110122
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569292}
[modify] https://crrev.com/eae93ca8666e70fb28e6ccccb277289f05f8e35b/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG

Edge 18.17713 gets these wrong (example and layout tests from description) in the same way that NG does.
Blocking: 869867
Owner: dgro...@chromium.org
Status: Started (was: Available)
Owner: ----
Status: Available (was: Started)

Comment 6 by mstensho@chromium.org, Jan 18 (4 days ago)

Status: Fixed (was: Available)
This got fixed some time ago, although I don't remember exactly by what.

Sign in to add a comment