DesktopMediaPickerViewsTest failing on several Mac trybots |
||
Issue descriptionSee e.g.: Mac 10.11: - DesktopMediaPickerViewsTest.DoneCallbackCalledOnDoubleClick https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/27554 Mac 10.10: - DesktopMediaPickerViewsTest.DoneCallbackCalledWhenWindowClosed - DesktopMediaPickerViewsTest.DoneCallbackCalledOnDoubleTap - DesktopMediaPickerViewsTest.DoneCallbackCalledOnOkButtonPressed - DesktopMediaPickerViewsTest.DoneWithAudioShare https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/33278
,
Jun 21 2018
The failures started shortly after that CL, though not immediately (2-3 builds).
,
Jun 21 2018
Yep. These are bot only failures that need to be investigated on the bot as noted in the CL description.
,
Jun 21 2018
The work for this was just deprioritized. Delete comment ⚐ The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f6ea60ef53c47383bd2954a8b908c8eecd25f5f commit 7f6ea60ef53c47383bd2954a8b908c8eecd25f5f Author: Robert Liao <robliao@chromium.org> Date: Thu Jun 21 21:17:20 2018 Revert "Add Views DesktopMediaPicker into the Overall Views Build" This reverts commit 59da623a9597b60252f1c657add234eecbb30918. Reason for revert: This work was just deprioritized, so the investigation into the bot only failures is now on the backburner. Original change's description: > Add Views DesktopMediaPicker into the Overall Views Build > > This moves the code into the toolkit_views source list and gates Aura > specific code behind build flags. > > Additionally, this links up DesktopMediaPicker::Create in a manner > similar to ScreenCaptureNotificationUI::Create[Cocoa]. > > BUG=726005,657883 > NOAUTOREVERT=true > Need to investigate any failure on the Mac Bot. Not reproducible locally. > > Change-Id: I9ece0b875268495d70154378c7608c3e1bae2938 > Reviewed-on: https://chromium-review.googlesource.com/1102042 > Commit-Queue: Robert Liao <robliao@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569095} TBR=ellyjones@chromium.org,sky@chromium.org,robliao@chromium.org Change-Id: Ice2800851d19895e687525bc63b8afa9d1746517 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 726005, 657883 Reviewed-on: https://chromium-review.googlesource.com/1110897 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#569377} [modify] https://crrev.com/7f6ea60ef53c47383bd2954a8b908c8eecd25f5f/chrome/browser/ui/BUILD.gn [delete] https://crrev.com/cb8b61b491aad9c3b36dbfd705d52a7bfc3c2dda/chrome/browser/ui/cocoa/media_picker/create_desktop_media_picker_cocoa.h [delete] https://crrev.com/cb8b61b491aad9c3b36dbfd705d52a7bfc3c2dda/chrome/browser/ui/cocoa/media_picker/create_desktop_media_picker_cocoa.mm [modify] https://crrev.com/7f6ea60ef53c47383bd2954a8b908c8eecd25f5f/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_cocoa.mm [modify] https://crrev.com/7f6ea60ef53c47383bd2954a8b908c8eecd25f5f/chrome/browser/ui/views/desktop_capture/desktop_media_list_view.cc [modify] https://crrev.com/7f6ea60ef53c47383bd2954a8b908c8eecd25f5f/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc [modify] https://crrev.com/7f6ea60ef53c47383bd2954a8b908c8eecd25f5f/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc [modify] https://crrev.com/7f6ea60ef53c47383bd2954a8b908c8eecd25f5f/chrome/test/BUILD.gn |
||
►
Sign in to add a comment |
||
Comment 1 by msramek@chromium.org
, Jun 21 2018Owner: robliao@chromium.org
Status: Assigned (was: Available)