New issue
Advanced search Search tips

Issue 855029 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-07-04
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

Adaptive Toolbar: Bottom education doesn't disappear on scroll

Project Member Reported by gambard@chromium.org, Jun 21 2018

Issue description

When the user scroll, the in product help doesn't disappear, leading to a weird state.
 
Labels: Proj-UIRefresh
Labels: -Pri-2 Pri-1
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52706ac690c03e7285fef500206cd031450e39fd

commit 52706ac690c03e7285fef500206cd031450e39fd
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Jun 26 16:14:36 2018

Dismiss in help product on swipe events

The in product help should be dismissed on swipe event because the
toolbar is going away and the bubble isn't linked to any UI element
after that.

Bug:  855029 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6cc62441b613c5c9f14d32bb7584364a9b529f77
Reviewed-on: https://chromium-review.googlesource.com/1115124
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570421}
[modify] https://crrev.com/52706ac690c03e7285fef500206cd031450e39fd/ios/chrome/browser/ui/bubble/bubble_view_controller_presenter.mm

NextAction: 2018-07-04
Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
verified in 69.0.3479.0 Canary in iPad Air(iOS 11.4), iPhone 8plus(iOS 11.4.1) and iPad Air(iOS 10.3.3)

Followed the below steps:
1. Enable in product help flag in chrome://flags
2. Force quit and relaunch the app
3. Tap on scroll

Observed result:
The in product help dismisses on scroll

Link to video:
https://drive.google.com/file/d/1NSBOmtDrSRRQ4i4wsrCXMeqaA3z9dzHV/view?usp=sharing

The NextAction date has arrived: 2018-07-04

Sign in to add a comment