New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 855014 link

Starred by 2 users
Status: Fixed
Owner:
sammiequon@chromium.org
Closed: Aug 15
Cc:
ajha@chromium.org
█ brajkumar@chromium.org
steve...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression : 'Continue' button is still in enabled mode even after PIN is erased through 'Shift+Tab' key in 'Enter your PIN' overlay of chrome://settings/lockScreen page

Project Member Reported by mmanchala@chromium.org, Jun 21 2018 
Chrome Version: 68.0.3440.34/10718.29.0 beta channel Daisy,Kip and Reks
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Go to chrome://settings -> Now under 'People' section click on 'Screen lock' option
2)Now enter User Password in 'Confirm your password' dialog box -> At 'screen lock options' section select 'PIN or Password' option -> click on 'SET UP PIN'
(3)In 'Enter your PIN' overlay enter required digits(6 digits) so that 'Continue' button is enabled -> now press 'Tab'until focus is on digit '1' 
(4)Now press 'Shift+Tab' key to bring back focus on 'PIN' field -> press 'Backspace' key so that pin will be erased -> observe 'Continue'  button is still in enabled mode
(Please refer Video and Screenshot)


Expected: 'Continue' button should get disabled after PIN is erased 
Actual: Instead 'Continue' button is still in enabled mode even  after PIN is erased 

This is Non-Regression Issue as 'Screen lock' option is introduced from M-57

@sammiequon : Please confirm the Issue
Actual_EnabledContinueButton.mp4
16.0 MB Download
Actual_EnabledContinueButton.jpg
834 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0e8e86f030d12688914f9b29f632542261682bc

commit f0e8e86f030d12688914f9b29f632542261682bc
Author: Sammie Quon <sammiequon@google.com>
Date: Tue Aug 14 21:04:21 2018

settings: Update ripples on setup PIN keyboard.

Also fix a bug where continue button was still enabled after tabbing to
and pressing backspace with the keyboard.

Test: manual
Bug:  855014 ,  869641 
Change-Id: I0f3e570fc87b1a2e60de112de47558885f5d4847
Reviewed-on: https://chromium-review.googlesource.com/1173139
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583030}
[modify] https://crrev.com/f0e8e86f030d12688914f9b29f632542261682bc/chrome/browser/resources/settings/people_page/setup_pin_dialog.js
[modify] https://crrev.com/f0e8e86f030d12688914f9b29f632542261682bc/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.html

Comment 2 by sammiequon@chromium.org, Aug 15

Status: Fixed (was: Assigned)
►

Sign in to add a comment