Regression : 'Filter' text box in ‘Service worker’ section doesn't accept "Space bar" as a input and section gets collapsed.
Reported by
avsha...@etouch.net,
Jun 21 2018
|
||
Issue descriptionChrome Version : 69.0.3466.0 (Official Build) 7a22a4a62948746c970b84f31b1f78cd2cb3a1c2-refs/branch-heads/3466@{#1} 32/64 bit OS : Windows (7, 8, 8.1, 10), Linux (14.04 LTS), Mac(10.12.6, 10.13.1, 10.13.5, 10.13.6) What steps will reproduce the problem? 1. Launch chrome, navigate to www.google.com and open devtools on the page. 2. In devtools, navigate to ‘Application’ tab and go to ‘Service Workers’ section. 3. Expand ‘Service worker from other domains’ section and hit 'Tab' key to bring focus in ‘Filter’ text box. 4. Now, type letter "g" in it and press "Space bar" key to enter a space. 5. Observe. Actual Result : 'Filter' text box in ‘Service worker’ section does not accept "Space bar" as a input and section gets collapsed after hitting "Space bar" while performing query. Expected Result : 'Filter' text box should allow user to enter space through 'Space bar' while performing a query and it should not collapse. This is a regression issue broken in ‘M-65’ and providing the bisect using ‘per-revision bisect’ script : Good Build : 65.0.3286.0 (revision : 521957) Bad Build : 65.0.3287.0 (revision : 522296) You are probably looking for a change made after 522141 (known good), but no later than 522142 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/3009675f23c9d898168e015c9bed2c9c6f27a099..b76ab6a6b9982ca622a7779733c7009cf1b62aff Suspect : https://chromium.googlesource.com/chromium/src/+/b76ab6a6b9982ca622a7779733c7009cf1b62aff Eugene@:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note : Able to reproduce issue on Beta build #68.0.3440.33 and Stable #67.0.3396.87 Thank You..!
,
Nov 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5fc2dfd4633fc10b771c3efd53eef8133cd0d282 commit 5fc2dfd4633fc10b771c3efd53eef8133cd0d282 Author: Harley Li <hhli@chromium.org> Date: Fri Nov 02 22:51:25 2018 [DevTools] Prevent SW-from-other-domain's list from collapsing on search Add an event.target check in SW-from-other-domain's filter, so that an Enter or Space key input in the filter's editor box will not collapse the list of service workers from other domains. However, if the focus is on the div element of the "service worker from other domains" (instead of on the editor box inside the div), an Enter or Space key is still to expand/collapse the list. Bug: 855001 Change-Id: Iaeedd47fefe64bb081cd7cae66fd3eb53b4418b0 Reviewed-on: https://chromium-review.googlesource.com/c/1315356 Reviewed-by: Erik Luo <luoe@chromium.org> Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Cr-Commit-Position: refs/heads/master@{#605080} [modify] https://crrev.com/5fc2dfd4633fc10b771c3efd53eef8133cd0d282/third_party/blink/renderer/devtools/front_end/resources/ServiceWorkersView.js
,
Nov 8
|
||
►
Sign in to add a comment |
||
Comment 1 by dgozman@chromium.org
, Oct 12