Telemetry patches are failing with unidiomatic-typecheck |
||||
Issue descriptionTelemetry CLs are failing to land due to presubmit errors: ** Presubmit ERRORS ** Pylint (471 files using ['--disable=cyclic-import'] on 8 cores) (21.32s) failed ************* Module telemetry.benchmark W:274, 9: Using type() instead of isinstance() for a typecheck. (unidiomatic-typecheck) ************* Module telemetry.internal.image_processing._bitmap W: 46, 7: Using type() instead of isinstance() for a typecheck. (unidiomatic-typecheck) W:129, 7: Using type() instead of isinstance() for a typecheck. (unidiomatic-typecheck) ************* Module telemetry.internal.story_runner_unittest W:832, 9: Using type() instead of isinstance() for a typecheck. (unidiomatic-typecheck) W:870, 9: Using type() instead of isinstance() for a typecheck. (unidiomatic-typecheck) ************* Module telemetry.util.statistics W:268, 5: Using type() instead of isinstance() for a typecheck. (unidiomatic-typecheck) W:270, 7: Using type() instead of isinstance() for a typecheck. (unidiomatic-typecheck) W:272, 7: Using type() instead of isinstance() for a typecheck. (unidiomatic-typecheck) ************* Module telemetry.value W: 94,12: Using type() instead of isinstance() for a typecheck. (unidiomatic-typecheck) Writing now a CL to fix these.
,
Jun 21 2018
,
Jun 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d370bf6746dba7d05a325c314cfc12b2693beb9c commit d370bf6746dba7d05a325c314cfc12b2693beb9c Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu Jun 21 18:47:17 2018 Roll src/third_party/catapult 44fc6f687b35..53842b6cbc1f (11 commits) https://chromium.googlesource.com/catapult.git/+log/44fc6f687b35..53842b6cbc1f git log 44fc6f687b35..53842b6cbc1f --date=short --no-merges --format='%ad %ae %s' 2018-06-21 ckitagawa@chromium.org [Devil] Fix pylint typecheck errors 2018-06-21 perezju@chromium.org [Telemetry] Add clear_caches option to possible_browser.Create 2018-06-21 charliea@chromium.org Tell sqlite3 to use a write-ahead mode 2018-06-21 perezju@chromium.org Fix index of timeseries data frames 2018-06-21 perezju@chromium.org [Telemetry] Do not cache installed apps in AndroidPlatformBackend 2018-06-21 benjhayden@chromium.org Increase Anomaly query limit in graph_json. 2018-06-21 nednguyen@google.com Disable testWaitForJavaScriptCondition on Mac 2018-06-21 perezju@chromium.org [Telemetry] Example: restart browser during story 2018-06-21 perezju@chromium.org [Telemetry] Fix pylint unidiomatic-typecheck warnings 2018-06-21 perezju@chromium.org [soundwave] Code health in dashboard_api.py 2018-06-21 perezju@chromium.org [soundwave] Follow cursor on fetch alerts API call Created with: gclient setdep -r src/third_party/catapult@53842b6cbc1f The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:811244,chromium:711073,chromium:854744, chromium:849703 , chromium:854986 TBR=sullivan@chromium.org Change-Id: I7a6383560447cee344a85996f9a7f595e0e9088c Reviewed-on: https://chromium-review.googlesource.com/1110297 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569338} [modify] https://crrev.com/d370bf6746dba7d05a325c314cfc12b2693beb9c/DEPS
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Jun 21 2018