Mac chrome toolbar checkmark does not get updated on NTP
Reported by
vineetha...@etouch.net,
Jun 21 2018
|
|||||||
Issue descriptionChrome Version: 69.0.3466.0 (Official Build) 7a22a4a62948746c970b84f31b1f78cd2cb3a1c2-refs/branch-heads/3466@{#1}(64 bit) OS: Mac(10.12.6 , 10.13.1 , 10.13.5, 10.13.6) Pre-condition: Enable 'Use Views browser windows instead of Cocoa' from chrome://flags. What steps will reproduce the problem? (1) Launch chrome, open NTP. (2) Click on ‘View’ menu in chrome toolbar and try to check/uncheck ‘Always show bookmark..’ option and observe. Actual : Unable to check/uncheck 'Always show bookmark..' option on NTP Expected: Should be able to check/uncheck 'Always show bookmark..' option on NTP This is a Non-regression issue, seen from M-67 build #67.0.3385.0 Note: (1)The issue is not seen Windows(7,8,8.1,10) and Linux(14.04) OS. (2)The menu items work as intended, the checkmark doesn't get updated. (3)This issue is only observed on NTP and not on chrome internal pages. Thank you!
,
Jun 21 2018
,
Jun 26 2018
,
Jul 2
Hi, I would like to look into this for my first code contribution
,
Jul 3
I'll own this bug to sponsor this contribution.
,
Jul 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f42285a00e836ecd0ddde8cb0624c7bb2bed162 commit 1f42285a00e836ecd0ddde8cb0624c7bb2bed162 Author: Jeffrey <jeffreyca16@gmail.com> Date: Tue Jul 03 15:46:43 2018 Update 'Always Show Bookmarks' checkmark visibility when toggled on New Tab Page In MacViews mode, the 'Always Show Bookmarks' menu item is always checked regardless of whether the bookmark bar is detached or attached. In Cocoa mode, this was not an issue because the visibility state is determined by the bookmark preference value for 'kShowBookmarkBar', which stores whether the 'Always Show Bookmarks' option is checked. In MacViews mode, the visibility state always returns 'true' because it calls IsBookmarkBarVisible() instead, which is 'true' if the bookmark bar is in a detached state (on New Tab Page). Add contact info to AUTHORS Update 'Always Show Bookmarks' checkmark visibility when toggled on New Tab Page R=bsep@chromium.org, sky@chromium.org Bug: 854962 Change-Id: I19f3741cd720474642d0661192f92f4517da075c Reviewed-on: https://chromium-review.googlesource.com/1123890 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#572236} [modify] https://crrev.com/1f42285a00e836ecd0ddde8cb0624c7bb2bed162/AUTHORS [modify] https://crrev.com/1f42285a00e836ecd0ddde8cb0624c7bb2bed162/chrome/browser/ui/cocoa/browser_window_command_handler.mm
,
Jul 3
This fix should be in tomorrow's Canary.
,
Jul 4
Update : Rechecked the above issue on Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) with latest Canary Chrome version #69.0.3481.0 and the issue is fixed. Kindly refer the attached screen cast.
,
Jul 12
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by rbasuvula@chromium.org
, Jun 21 2018