New issue
Advanced search Search tips

Issue 854960 link

Starred by 9 users
Status: Fixed
Owner:
rakina@chromium.org
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Feature



Sign in to add a comment

Implement support for Element.toggleAttribute

Reported by jkings...@mozilla.com, Jun 21 2018 
UserAgent: Mozilla/5.0 (X11; Linux x86_64; rv:62.0) Gecko/20100101 Firefox/62.0

Steps to reproduce the problem:
1. In JavaScript use element.toggleAttribute("disabled")

What is the expected behavior?
https://github.com/whatwg/dom/pull/656

What went wrong?
Didn't implement

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: <Copy from: 'about:version'>  Channel: n/a
OS Version: 
Flash Version: Shockwave Flash 29.0 r0

Comment 1 by dtapu...@chromium.org, Jun 21 2018

Components: Blink>DOM

Comment 2 by rakina@chromium.org, Jun 21 2018

Labels: -Type-Bug Type-Feature
Owner: rakina@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5361078a2944c3b70c5092bebecbf042fb824fc0

commit 5361078a2944c3b70c5092bebecbf042fb824fc0
Author: Rakina Zata Amni <rakina@chromium.org>
Date: Tue Jun 26 08:13:32 2018

Implement Element.toggleAttribute

Add a new method Element.toggleAttribute(string qualifiedName,
optional bool force) that allow toggling the existence of an element’s
attribute, similar to Element.classList.toggle.

Spec
https://dom.spec.whatwg.org/#dom-element-toggleattribute

Intent to Implement and Ship
https://groups.google.com/a/chromium.org/d/msg/blink-dev/mAWBTaANvmE/OgaCRH04BAAJ

Bug:  854960 
Change-Id: Iab8a1a97dd4e2f8b377bcf590401699f9013aa8a
Reviewed-on: https://chromium-review.googlesource.com/1111761
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570348}
[delete] https://crrev.com/b017844723c4de4d2036b8c78cd2f3bc7b0efb34/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/attributes-expected.txt
[modify] https://crrev.com/5361078a2944c3b70c5092bebecbf042fb824fc0/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/attributes.html
[modify] https://crrev.com/5361078a2944c3b70c5092bebecbf042fb824fc0/third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/5361078a2944c3b70c5092bebecbf042fb824fc0/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/5361078a2944c3b70c5092bebecbf042fb824fc0/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/5361078a2944c3b70c5092bebecbf042fb824fc0/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/5361078a2944c3b70c5092bebecbf042fb824fc0/third_party/blink/renderer/core/dom/element.h
[modify] https://crrev.com/5361078a2944c3b70c5092bebecbf042fb824fc0/third_party/blink/renderer/core/dom/element.idl

Comment 4 by rakina@chromium.org, Jun 26 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment