New issue
Advanced search Search tips

Issue 854948 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Input language is not known without any user operations, when multiple input languages are enabled

Project Member Reported by mukai@chromium.org, Jun 21 2018

Issue description

Google Chrome	69.0.3464.0 (Official Build) dev (64-bit)
Revision	3c26b60e3842fee660bcff5eb35aa0587d795f02-refs/branch-heads/3464@{#1}
Platform	10798.0.0 (Official Build) dev-channel eve

What steps will reproduce the problem?
(1) open the settings, advanced > Input Methods, enables English and Japanese input
(2) open a browser window
(3) focus on the omnibox

What is the expected result?
Can see which language (English or Japanese) is activated for the current text input session, without any user operations

What happens instead?
Nothing


Note that historically this language information appears on the right-bottom area of the screen. Now it's gone. The input language information is visible within the system tray, however, the user needs to open the system tray. That information needs to be available to the users without any operations.

I believe this is a serious regression for multi-language input users, and such users are quite common in east Asia.
 

Comment 1 by uekawa@google.com, Jun 21 2018

+1; but I also think I don't seem to see it when I need it because it's far away in the bottom right hand side of the screen. I usually realize after typing. This feels like vi to me that I need to look at the modeline.

I wonder if it is possible to have an affordance near the text caret for the input modality.

Comment 2 by derat@chromium.org, Jun 21 2018

Cc: lpalmaro@chromium.org dtseng@chromium.org dmazz...@chromium.org
(I think the spec is at https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZXS6M2rSjiqy/files/MCG16K9U0aaVg9n6665EzXbKwMSJbxAVNpw, but it seems to be low-res and is hard to read.)

I suspect that the decision to remove a11y-related icons from the tray may also be problematic -- cc-ing a few people as a heads-up.

Can this be reconsidered? I feel like it's important to make information about some user-enabled functionality like input methods and a11y readily available.

Comment 3 by mukai@chromium.org, Jun 21 2018

c02:

While I agree that dropping a11y icon might be problematic, I feel like it would be better to separate the issue per each icon/element since the solution could be different.

For example, the language information does not have to be back to the status area exactly if the required information is provided properly.

Comment 4 by mukai@chromium.org, Jun 21 2018

Filed Issue 855190.

Comment 5 by mukai@chromium.org, Jun 21 2018

#c01:

I see. I also agree that it does not have to be in the bottom right of the screen. An option is the language indicator popup, which appears just below the text cursor when the user switches the input language (see the attached image in case it is unclear what the indicator popup means).

Maybe showing it also on-focus automatically (when multiple input languages are active) would be helpful. WDYT?
Screenshot 2018-06-21 at 13.22.19 - Display 2.png
2.9 KB View Download

Comment 6 by tetsui@chromium.org, Jun 22 2018

#2 (off topic): you can fix low-res by clicking on "SHOW ORIGINAL" button shown at the bottom when the doc is opened

Comment 7 by mukai@chromium.org, Jun 22 2018

Cc: yhanada@chromium.org shuchen@chromium.org kinaba@chromium.org
cc-ed a few people regarding the IME things
I'm wondering whether the "Show input menu on shelf" feature can solve this issue.
Now the feature is sitting behind a deep buried setting in the Language and Input Method settings.
Should we by default enable it if user enables more than one input methods?

Thanks for bringing that up. The big cleanup we're doing in the status tray may lead to some unpleasantness for sure. 

In this particular case, I think this is worth bringing back, either in panel form or in the status tray itself, as an exception.

I'll sync with UI review and circle back.

From offline chat, just to make it clear, the change of removing the language indicator is only relevant for tablet mode, where the user can see the layout of the keyboard on the VK. It's also where we want to support portrait orientation so most critical for that.

For clamshell mode we still show the language indicator.
Cc: sgabr...@chromium.org
Owner: tetsui@chromium.org
Restoring the icon for non-tablet mode.
Status: Started (was: Assigned)
Spec is available in the Launcher, Shelf & Apps gallery here:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZXS6M2rSjiqy/files/MCFQynNxbfc7gEm06mlQjAmGwMSJbxAVNpw

Excerpt attached.

spec excerpt.png
258 KB View Download
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3b34354fd7572702bf619b1e4bf9b46d9974b6f

commit c3b34354fd7572702bf619b1e4bf9b46d9974b6f
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Fri Jun 29 05:46:44 2018

Add IME mode icon to UnifiedSystemTray.

This CL restores IME mode icon to UnifiedSystemTray. The icon was
removed as a part of UnifiedSystemTray & Shelf spec, but it turned out
the icon is important especially for CJK users with laptop mode.
We still hide the icon for tablet mode.

TEST=manual
BUG= 854948 

Change-Id: I55bdd88627f91c9e285242b725c4a55451d0c60a
Reviewed-on: https://chromium-review.googlesource.com/1116412
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571395}
[modify] https://crrev.com/c3b34354fd7572702bf619b1e4bf9b46d9974b6f/ash/BUILD.gn
[add] https://crrev.com/c3b34354fd7572702bf619b1e4bf9b46d9974b6f/ash/system/unified/ime_mode_view.cc
[add] https://crrev.com/c3b34354fd7572702bf619b1e4bf9b46d9974b6f/ash/system/unified/ime_mode_view.h
[modify] https://crrev.com/c3b34354fd7572702bf619b1e4bf9b46d9974b6f/ash/system/unified/unified_system_tray.cc
[modify] https://crrev.com/c3b34354fd7572702bf619b1e4bf9b46d9974b6f/ash/system/unified/unified_system_tray.h

Status: Fixed (was: Started)

Comment 16 by mukai@chromium.org, Jun 29 2018

Thank you for fixing!

Sign in to add a comment