Regression : Blue focus highlight appears chopped from botton on 'Browse' button in chrome://extensions/ page.
Reported by
rp...@etouch.net,
Jun 21 2018
|
||||
Issue descriptionChrome version: 69.0.3466.0 (Official Build)Revision 7a22a4a62948746c970b84f31b1f78cd2cb3a1c2-refs/branch-heads/3466@{#1}(32/64-bit) OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.6) What steps will reproduce the problem? 1. Launch chrome,navigate to chrome://extensions/ page 2. Now click on 'Developer mode' toggle button to open developer mode and click on 'Pack extension' button 3. Now press 'Tab' key to bring focus on Private key file (optional) 'Browse' button and observe focus highlight Actual: Blue focus highlight appears chopped from botton on 'Browse' button Expected: Blue focus highlight should be seen properly on 'Browse' button This is regression issue, broken in ‘M 69’ and below is the bisect info : Good build: 69.0.3464.0 (Revision: 567919). Bad build: 69.0.3465.0 (Revision: 568285). You are probably looking for a change made after 568240 (known good), but no later than 568241 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/fbb0e336a2d6fe1237aecbb9cdfaa59e252857fa..9a7643defbc3e5114439b6d2240eed0715c1705c Suspect : https://chromium.googlesource.com/chromium/src/+/9a7643defbc3e5114439b6d2240eed0715c1705c From the CL above, assigning the issue to the concern owner @scottchen- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
,
Jun 21 2018
,
Jun 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9de18ffa9e0c829b9b1374b17268896c38e91d30 commit 9de18ffa9e0c829b9b1374b17268896c38e91d30 Author: Scott Chen <scottchen@chromium.org> Date: Fri Jun 22 17:55:43 2018 Extensions: fix focus being chopped in pack dialog. Bug: 854936 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id5e2f544cf2425e641c68d042b88b40230ba471c Reviewed-on: https://chromium-review.googlesource.com/1110856 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#569689} [modify] https://crrev.com/9de18ffa9e0c829b9b1374b17268896c38e91d30/chrome/browser/resources/md_extensions/pack_dialog.html
,
Jun 22 2018
,
Jun 25 2018
Update:- Re-tested this issue on Windows (7,8,8.1,10), Mac(10.12.6,10.13.1,10.13.6) and Linux(14.04 LTS) machines using latest Chrome Canary build# 69.0.3472.0 and fix is working as expected.. Hence adding TE-Verified labels. Please find the attached screen-cast for reference. Thanks..! |
||||
►
Sign in to add a comment |
||||
Comment 1 by scottchen@chromium.org
, Jun 21 2018