Blue ring is seen misplaced on close button('x') of TAB in Tabstrip.
Reported by
shruti.j...@etouch.net,
Jun 21 2018
|
|||||
Issue descriptionChrome Version: 69.0.3466.0 (Official Build) 7a22a4a62948746c970b84f31b1f78cd2cb3a1c2-refs/branch-heads/3466@{#1} (32/64 bit) OS:S: Mac (10.12.6, 10.13.1, 10.13.5, 10.13.6) Pre-Condition: 1.Enable 'Use Views browser windows instead of Cocoa' from chrome://flags. 2.Enable RTL' frome chrome://flags Steps to reproduce: 1.Launch chrome and Press tab for focus on close button('x') of TAB in Tabstrip. 2.Observe the focus on close button('x') of TAB. Actual Result : Blue ring is seen misplaced on close button('x') of TAB in Tabstrip. Expected Result :Blue ring should be seen properly on close button('x') of TAB in Tabstrip. This is a Non-regression issue seen from ‘M-69’ series(#69.0.3455.0) as focus ring on Tab-Strip is implemented from this build. Note:Issue is not seen on Windows(7,8,8.1,10) AND Linux(14.04 LTS). Kindly review the attached screen-cast . Thank You!
,
Jun 30 2018
[chrome mac triage] Assigning to lgrey@ for RTL bugs
,
Jun 30 2018
,
Jul 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e6fbdf867ad100cb5358f7c012f1c43310c1605 commit 0e6fbdf867ad100cb5358f7c012f1c43310c1605 Author: Leonard Grey <lgrey@chromium.org> Date: Tue Jul 03 18:41:07 2018 Views: fix tab close button's focus ring in RTL Also removes the explicit focus ring layout since ImageButton::Layout takes care of this. Bug: 854934 Change-Id: Ib49442d1db95577d9e4f7d0497e1b3bd50bf2cbc Reviewed-on: https://chromium-review.googlesource.com/1124765 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#572303} [modify] https://crrev.com/0e6fbdf867ad100cb5358f7c012f1c43310c1605/chrome/browser/ui/views/tabs/tab_close_button.cc
,
Jul 4
Update :
Retested above issue on Mac(10.12.6,10.13.1,10.13.6) OS using latest Canary #69.0.3481.0 and issue is fixed.Blue Ring is now seen on ('x') close button of NTP properly .Kindly review the attached screen-cast.
Thank you!
,
Jul 6
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rbasuvula@chromium.org
, Jun 21 2018