Good Build: 66.0.3343.0(Revision: 535277)
Bad Build: 66.0.3344.0(Revision: 535592)

My change was only temporarily disabling a DCHECK and was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/911708 so I don't think it's related.

If I understand the bug correctly, the placeholder text should distinguish between crashes and kills, but it's not.

From git blame, it looks like afakhry@ has done some work related to feedback strings and can hopefully triage further.

This is also seen on ChromeOS.

This is the culprit CL: https://chromium-review.googlesource.com/c/chromium/src/+/907675

wez@ please take a look.

Thanks afakhry@

IIUC the issue is that the RenderFrameImpl call to base::Process::Terminate() was relying on two not-explicitly-documented properties:
1. On Windows, an exit-code of 1 is conventionally as "process killed" - I didn't change the exit code, so that property was preserved.
2. On POSIX, base::ProcessTerminate() first attempts to SIGTERM the process, which is what we look for to determine that the tab was killed, rather than crashing or (ab)normal termination.

So I plan to amend the chrome://kill implementation to:
(1) Explicitly self-terminate using base::win::kProcessKilledExitCode on Windows.
(2) Explicitly kill(SIGTERM) on POSIX.
(3) Fall-back to TerminateCurrentProcessImmediately on all other configurations (as is currently the case).

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b63f00de4179518540f06dacb6108d7e21091e45

commit b63f00de4179518540f06dacb6108d7e21091e45
Author: Wez <wez@chromium.org>
Date: Wed Jun 27 16:46:36 2018

Fix chrome://kill debug URL to simulate process kills correctly.

The implementation of this debug URL was changed in
https://chromium-review.googlesource.com/c/chromium/src/+/907675 to one
which _exit()s the process under POSIX, rather than self-terminating via
kill().  Since we detect process kills (versus self-termination, crashes
etc) by checking for SIGTERM, this broke chrome://kill.

Fix chrome://kill by explicitly kill()ing the process, and structure the
implementation to make clear that we need to simulate termination by a
peer process, specifically.

Bug: 806451,  854926 
Change-Id: I0408dd1d248e04b3045f37d46051c220b33ab081
Reviewed-on: https://chromium-review.googlesource.com/1116076
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570801}
[modify] https://crrev.com/b63f00de4179518540f06dacb6108d7e21091e45/content/renderer/render_frame_impl.cc

Update:-
 Re-tested this issue on Mac(10.12.6 , 10.13.1 , 10.13.6) using latest Chrome latest Canary build# 69.0.3475.0 and fix is working as intended. 

Please find the attached screen-cast for reference.

Thank you.

Deleted: Fix_Issue.mov 3.5 MB

	Fix_Issue.mov 3.5 MB View Download