Tether, integrated with SecureChannel, does not correctly timeout |
||
Issue descriptionIf SecureChannel does not find a connection, Tether will hang forever. A timeout for each operation needs to be introduced. Oddly, this timeout mechanism should already be present in each operation (e.g. ConnectTetheringOperation). Requires further investigation.
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c628af56763408031cf1832f70dbcf374ab3ada commit 6c628af56763408031cf1832f70dbcf374ab3ada Author: Ryan Hansberry <hansberry@chromium.org> Date: Fri Jun 29 17:39:18 2018 [CrOS Multidevice] Tether: time out if SecureChannel does not create connection in time. SecureChannel will simply listen forever, waiting for a connection to the specified remote device. MessageTransferOperation now uses a new timer that times out if a connection is not created in time. Bug: 824568, 752273 , 854885 Change-Id: Ia37cf1ec55e60ae3e7e386cdf40fdd9486ab6cdf Reviewed-on: https://chromium-review.googlesource.com/1117899 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#571516} [modify] https://crrev.com/6c628af56763408031cf1832f70dbcf374ab3ada/chromeos/components/tether/connect_tethering_operation.cc [modify] https://crrev.com/6c628af56763408031cf1832f70dbcf374ab3ada/chromeos/components/tether/connect_tethering_operation.h [modify] https://crrev.com/6c628af56763408031cf1832f70dbcf374ab3ada/chromeos/components/tether/connect_tethering_operation_unittest.cc [modify] https://crrev.com/6c628af56763408031cf1832f70dbcf374ab3ada/chromeos/components/tether/message_transfer_operation.cc [modify] https://crrev.com/6c628af56763408031cf1832f70dbcf374ab3ada/chromeos/components/tether/message_transfer_operation.h [modify] https://crrev.com/6c628af56763408031cf1832f70dbcf374ab3ada/chromeos/components/tether/message_transfer_operation_unittest.cc
,
Jul 2
Fixed for Tether. Re: my comment in #1, this actually shouldn't be an issue because Smart Lock should be listening forever, until it's torn down after screen unlock. Closing as fixed.
,
Sep 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f994f436c5f6994446afcefe21c675814452ae2 commit 9f994f436c5f6994446afcefe21c675814452ae2 Author: Ryan Hansberry <hansberry@chromium.org> Date: Tue Sep 18 19:37:56 2018 [CrOS Multidevice] Do not initialize BleConnectionManager if MultiDevice APIs are active. In the process, this also adapts HostConnectionMetricsLogger to use the MultiDevice APIs to properly log to the "Background" versions of its metrics. Bug: 824568, 752273 , 854885 , 857302 Change-Id: I77fc52b3d07d903fe61ac62de2620216984d28de Reviewed-on: https://chromium-review.googlesource.com/1117897 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#592146} [modify] https://crrev.com/9f994f436c5f6994446afcefe21c675814452ae2/chromeos/components/tether/asynchronous_shutdown_object_container_impl.cc [modify] https://crrev.com/9f994f436c5f6994446afcefe21c675814452ae2/chromeos/components/tether/host_connection_metrics_logger.cc [modify] https://crrev.com/9f994f436c5f6994446afcefe21c675814452ae2/chromeos/components/tether/host_connection_metrics_logger.h [modify] https://crrev.com/9f994f436c5f6994446afcefe21c675814452ae2/chromeos/components/tether/host_connection_metrics_logger_unittest.cc |
||
►
Sign in to add a comment |
||
Comment 1 by hansberry@chromium.org
, Jun 21 2018