New issue
Advanced search Search tips

Issue 854882 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Implement clear data logic and open link logic for ClearBrowsingDataTableViewController

Project Member Reported by thegreenfrog@chromium.org, Jun 21 2018

Issue description

Not ideal if ClearBrowsingDataTableView is dependent on history's coordinator for the dispatcher/delegate for the logic. Figure out a way to better structure this so that it can also be used in Settings.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf8cd82568d1e198e23463712d78ccafd2a05061

commit cf8cd82568d1e198e23463712d78ccafd2a05061
Author: Chris Lu <thegreenfrog@chromium.org>
Date: Sun Jun 24 22:31:51 2018

[ios] Implement open link logic in ClearBrowsingDataTableView

Also moves it's coordinator to history and creates HistoryClearBrowsingDataLocalCommands delegate.

Bug:  854882 
Change-Id: Ia408681d5d559b1ae2da38315436fc93a7591489
Reviewed-on: https://chromium-review.googlesource.com/1111077
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569939}
[modify] https://crrev.com/cf8cd82568d1e198e23463712d78ccafd2a05061/ios/chrome/browser/ui/history/BUILD.gn
[add] https://crrev.com/cf8cd82568d1e198e23463712d78ccafd2a05061/ios/chrome/browser/ui/history/history_clear_browsing_data_coordinator.h
[add] https://crrev.com/cf8cd82568d1e198e23463712d78ccafd2a05061/ios/chrome/browser/ui/history/history_clear_browsing_data_coordinator.mm
[modify] https://crrev.com/cf8cd82568d1e198e23463712d78ccafd2a05061/ios/chrome/browser/ui/history/history_coordinator.mm
[modify] https://crrev.com/cf8cd82568d1e198e23463712d78ccafd2a05061/ios/chrome/browser/ui/settings/BUILD.gn
[delete] https://crrev.com/0c062061326cd05a1ab884e5b2d6e03e2b79f215/ios/chrome/browser/ui/settings/clear_browsing_data_coordinator.h
[delete] https://crrev.com/0c062061326cd05a1ab884e5b2d6e03e2b79f215/ios/chrome/browser/ui/settings/clear_browsing_data_coordinator.mm
[add] https://crrev.com/cf8cd82568d1e198e23463712d78ccafd2a05061/ios/chrome/browser/ui/settings/clear_browsing_data_local_commands.h
[modify] https://crrev.com/cf8cd82568d1e198e23463712d78ccafd2a05061/ios/chrome/browser/ui/settings/clear_browsing_data_table_view_controller.h
[modify] https://crrev.com/cf8cd82568d1e198e23463712d78ccafd2a05061/ios/chrome/browser/ui/settings/clear_browsing_data_table_view_controller.mm

Status: Fixed (was: Assigned)

Sign in to add a comment