New issue
Advanced search Search tips

Issue 854878 link

Starred by 1 user
Status: Fixed
Owner:
agrieve@chromium.org
Closed: Jun 2018
Cc:
bsazonov@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Apk was not rebuilt when resource attribute changed

Project Member Reported by agrieve@chromium.org, Jun 21 2018 
Pointed out here:
https://bugs.chromium.org/p/chromium/issues/detail?id=702625#c42

The change altered a few xml properties, but the build did not consider this enough to rebuild the apk.
https://chromium-review.googlesource.com/c/chromium/src/+/1105979

Looks like the compile_resources.py is not writing its input .zip files to its depfile:

https://cs.chromium.org/chromium/src/build/android/gyp/compile_resources.py?rcl=6407dba4c9759affdb5ef44b9235601bc6b4ba9e&l=648

It should have a depfile_deps= argument listing the .zip files.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c59f5988813ba200eaeee3f39a5f68c32917f26

commit 0c59f5988813ba200eaeee3f39a5f68c32917f26
Author: Andrew Grieve <agrieve@chromium.org>
Date: Fri Jun 22 15:36:21 2018

Android: Fix ninja not rebuilding when android resources change

Bug:  854878 
Change-Id: Ia8936dc875e6d577f702e83fb8e112a0ee0dd8ba
Reviewed-on: https://chromium-review.googlesource.com/1110747
Reviewed-by: David Turner <digit@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569638}
[modify] https://crrev.com/0c59f5988813ba200eaeee3f39a5f68c32917f26/build/android/gyp/compile_resources.py

Comment 2 by agrieve@chromium.org, Jun 22 2018

Status: Fixed (was: Assigned)

Comment 3 by bsazonov@chromium.org, Jun 22 2018 

Many thanks for fixing this!
►

Sign in to add a comment