Issue metadata
Sign in to add a comment
|
ChromeVox: Selecting text with ChromeVox+S doesn't work properly in hterm |
||||||||||||||||||||||||
Issue descriptionSelecting rows upward in hterm doesn't seem to select them at all. Selecting them downward seems to get stuck half after 1 or 2 rows. To repro: 1) Run hterm with latest accessiblity patches (I will provide another extension which you can load with the latest patches) 2) Press ChromeVox+Up to navigate to a previous row 3) Press ChromeVox+S to start selection 4) Then press ChromeVox+Up/Down and observe behavior.
,
Jun 26 2018
1. we don't allow backward selections (as of the latest selection code in ChromeVox). 2. I'm not seeing the other case you posed. I actually am unsure how to copy (Ctrl+C actually inserts a control character).
,
Jun 27 2018
Please see the attached minimal repro case. It requires your readonly patch to Chrome in order to repro. I think the stuttery selection ( issue 854867 ) is related to this. To repro: -ChromeVox+down through the rows -ChromeVox+S -ChromeVox+down 5 times. You will see that only 3 rows get selected and after that selection keeps jumping back up. Then, after you do this: -Clear selection -Hold down ChromeVox+down or ChromeVox+up -Notice the stuttery movement of selection which keeps jumping to previous rows
,
Jun 27 2018
I don't see the jumpy selection...but I can guess how it might happen. I have a change for that as well as adding support for selecting backward using Search+S.
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5fcbbaa50f62ff04765f916775445c4a74f5b0d0 commit 5fcbbaa50f62ff04765f916775445c4a74f5b0d0 Author: David Tseng <dtseng@chromium.org> Date: Wed Jun 27 19:42:50 2018 Enhance ChromeVox selection - backward selections were previously not implemented/supported. Add that feature in this change. - suppress hints during selection. chromevox_tests --gtest_filter=BackgroundTest.Selection Test: manually select forwards and backwards in all possible granularities. Bug: 854872 Change-Id: Ic26a9e2d1426e8fcea31323c33c42c3476b1bc4c Reviewed-on: https://chromium-review.googlesource.com/1115913 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#570865} [modify] https://crrev.com/5fcbbaa50f62ff04765f916775445c4a74f5b0d0/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js [modify] https://crrev.com/5fcbbaa50f62ff04765f916775445c4a74f5b0d0/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js
,
Jun 27 2018
Appears jumping selections was filed separately. Not sure what was expected by the original repro, but I think this is fixed.
,
Jul 18
Hi David, this bug seems to have come back on ToT. Could you ptal? The repro case still reproduces it for me.
,
Aug 2
,
Aug 9
I believe this has been fixed. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by raymes@chromium.org
, Jun 21 2018