Trigger error dialog to open when attempting to open a file on CrOS with a Crostini app |
||||
Issue descriptionFor initial launch, files located on the local CrOS file system can not be opened by a Crostini app (users will need to copy the files over to Linux files first). If a user attempts to open a file on the local CrOS system, we should trigger an error dialog. This dialog should indicate that users can either copy the file to Linux Files or use "Open With" to open the file with a Chrome OS or Android app.
,
Jun 21 2018
Tim, you are welcome to take this bug, otherwise I can look at this once your code lands.
,
Jun 21 2018
,
Jun 21 2018
I can take it (I also still need to get the icons working). To clarify, the state after my CL lands is that Crostini apps aren't listed for files outside the Linux Files section. Android apps likewise don't show up for Linux Files, but I'm not sure if this is intentional or not.
,
Jun 21 2018
Question - Is it additional work to make Crostini apps available for files on the local CrOS file system? I had assumed that would work out of box like Chrome OS web apps being available to Linux files. On the other hand, I would not expect Androids apps to be available to Linux Files without additional work. We can create a separate bug to track that feature if needed.
,
Jun 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/736d5d189e2c4ed19b4ed07b7d4124da4a982976 commit 736d5d189e2c4ed19b4ed07b7d4124da4a982976 Author: Joel Hockey <joelhockey@chromium.org> Date: Thu Jun 28 03:27:34 2018 FilesApp show error dialog when opening Downloads files with Crostini app * Updated FindCrostiniTasks to stop filtering for entries outside of crostini. * FilesApp FileTasks.execute takes chrome.fileManagerPrivate.FileTask rather than just the taskId so that the task.title is available to show in the error dialgo. * Fixed js docs in file_tasks.js to use correct FileTask rather than generic Object. Added FileTasks.ComboButtonItem type which is used by some functions. * FileTasks.executeInternal_ checks if the selected task type is crostini and any of the entries being operated on are not crostini. If this is detected, error dialog is shown. * Updated existing crostini UI tests to assume crostini is enabled by default. * Added crostini.testErrorOpeningDownloadsWithCrostiniApp test which verifies error dialog is shown when opening Downloads file with crostini app. Bug: 854858 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ic89c70bf4bfec3167f329fd3dc3fef40939e2657 Reviewed-on: https://chromium-review.googlesource.com/1116878 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#571021} [modify] https://crrev.com/736d5d189e2c4ed19b4ed07b7d4124da4a982976/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/736d5d189e2c4ed19b4ed07b7d4124da4a982976/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc [modify] https://crrev.com/736d5d189e2c4ed19b4ed07b7d4124da4a982976/chrome/browser/chromeos/file_manager/crostini_file_tasks.cc [modify] https://crrev.com/736d5d189e2c4ed19b4ed07b7d4124da4a982976/ui/file_manager/file_manager/foreground/js/file_manager_commands.js [modify] https://crrev.com/736d5d189e2c4ed19b4ed07b7d4124da4a982976/ui/file_manager/file_manager/foreground/js/file_tasks.js [modify] https://crrev.com/736d5d189e2c4ed19b4ed07b7d4124da4a982976/ui/file_manager/file_manager/foreground/js/task_controller.js [modify] https://crrev.com/736d5d189e2c4ed19b4ed07b7d4124da4a982976/ui/file_manager/file_manager/test/crostini.js [modify] https://crrev.com/736d5d189e2c4ed19b4ed07b7d4124da4a982976/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js [modify] https://crrev.com/736d5d189e2c4ed19b4ed07b7d4124da4a982976/ui/file_manager/file_manager/test/js/strings.js
,
Jun 28 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by weifangsun@chromium.org
, Jun 21 2018