Filter no-fetch-event controllers from most UMA about service worker controlled page loads |
|||
Issue descriptionCurrently we log perf metrics like PageLoad.Clients.ServiceWorker.PaintTiming* whenever a page has a controller service worker. However, if that controller didn't have a fetch event handler, no service worker was started or involved in loading the page, since we have a no fetch event handler optimization. We aren't interested in these cases for such UMA, so the UMA shouldn't include them.
,
Jun 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c5b3ef7d542a3be683839b3d90b4f64bf6082cb commit 6c5b3ef7d542a3be683839b3d90b4f64bf6082cb Author: Matt Falkenhagen <falken@chromium.org> Date: Tue Jun 26 03:09:26 2018 service worker: Filter no-fetch-event controllers from some UMA. When a page has a controller service worker without a fetch event handler, the service worker is not started and does not intercept requests. Therefore we don't care about such loads for most UMA about controlled page loads. Bug: 854851 Change-Id: I55198f43177c3d2468028672380bd2a8d08eb1f4 Reviewed-on: https://chromium-review.googlesource.com/1109314 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570317} [modify] https://crrev.com/6c5b3ef7d542a3be683839b3d90b4f64bf6082cb/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc [modify] https://crrev.com/6c5b3ef7d542a3be683839b3d90b4f64bf6082cb/third_party/blink/renderer/core/loader/document_loader.cc [modify] https://crrev.com/6c5b3ef7d542a3be683839b3d90b4f64bf6082cb/tools/metrics/histograms/histograms.xml
,
Jun 27 2018
,
Jun 27 2018
,
Jul 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ab9c21956e2f5208ea6b162bfe9c0d8e3b1f313 commit 9ab9c21956e2f5208ea6b162bfe9c0d8e3b1f313 Author: Matt Falkenhagen <falken@chromium.org> Date: Sat Jul 07 00:38:21 2018 histograms: Add Clients.ServiceWorker2* as affected_histogram to relevant suffixes. ServiceWorker2 replaced ServiceWorker and should be listed as an affected_histogram wherever ServiceWorker was. Missed in r570317 (https://chromium-review.googlesource.com/1109314) Bug: 854851 Change-Id: I03320e68b72d38b8062356fdba12fda542501530 Reviewed-on: https://chromium-review.googlesource.com/1127901 Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#573129} [modify] https://crrev.com/9ab9c21956e2f5208ea6b162bfe9c0d8e3b1f313/tools/metrics/histograms/histograms.xml |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jun 22 2018