New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 854848 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Repeating header/footers are painted at wrong places if the page is scrolled

Project Member Reported by wangxianzhu@chromium.org, Jun 21 2018

Issue description

Chrome Version: Latest M68 and M69
OS: (e.g. Win10, MacOS 10.12, etc...)

What steps will reproduce the problem?
(1) Open a page containing repeating table header/footer (e.g. the test case for  bug 852773 ) 
(2) Scroll down the page
(3) Print

What is the expected result?
The repeating header/footer should be at the correct places

What happens instead?
The repeating header/footer are at wrong places



Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1615ffa2f911b8d8582b02f1b15666fad3725b4

commit d1615ffa2f911b8d8582b02f1b15666fad3725b4
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Jun 21 23:10:03 2018

[PE] Fix repeating table header/footer printing when page is scrolled

Bug:  854848 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id1cf7b09fc32141758792c26f805fb73a1f131cb
Reviewed-on: https://chromium-review.googlesource.com/1109500
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569420}
[add] https://crrev.com/d1615ffa2f911b8d8582b02f1b15666fad3725b4/third_party/WebKit/LayoutTests/printing/thead-tfoot-repeat-scrolled-expected.html
[add] https://crrev.com/d1615ffa2f911b8d8582b02f1b15666fad3725b4/third_party/WebKit/LayoutTests/printing/thead-tfoot-repeat-scrolled.html
[modify] https://crrev.com/d1615ffa2f911b8d8582b02f1b15666fad3725b4/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc

Labels: Merge-Request-68
Verified on the latest Canary 69.0.3472.0. The patch is simple and very safe to merge.
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 25 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-68 Merge-Approved-68
Approved - branch:3440
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 26 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28a60850a8268f00d97e84070c2fd29362aec0e8

commit 28a60850a8268f00d97e84070c2fd29362aec0e8
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Tue Jun 26 18:01:15 2018

[PE] Fix repeating table header/footer printing when page is scrolled

TBR=wangxianzhu@chromium.org

(cherry picked from commit d1615ffa2f911b8d8582b02f1b15666fad3725b4)

Bug:  854848 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id1cf7b09fc32141758792c26f805fb73a1f131cb
Reviewed-on: https://chromium-review.googlesource.com/1109500
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#569420}
Reviewed-on: https://chromium-review.googlesource.com/1115419
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#533}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[add] https://crrev.com/28a60850a8268f00d97e84070c2fd29362aec0e8/third_party/WebKit/LayoutTests/printing/thead-tfoot-repeat-scrolled-expected.html
[add] https://crrev.com/28a60850a8268f00d97e84070c2fd29362aec0e8/third_party/WebKit/LayoutTests/printing/thead-tfoot-repeat-scrolled.html
[modify] https://crrev.com/28a60850a8268f00d97e84070c2fd29362aec0e8/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc

Status: Fixed (was: Assigned)

Sign in to add a comment