At least 70% of web pages use strict mode on 2014 study.
It seems more pages use strict mode in today.

#3: We have some layout tests in quirks mode, including some very similar to the attached test case.

To support hit testing culled inlines, I need to create box fragment for the inline element, which currently regresses the layout test. So this needs to be fixed.

I guess it's just a fixup of a few lines, but I couldn't figure out exactly what the fixup is...

Is this only when quirks? I think we can then try webcompat first. I've converted several quirks tests to standard to "fix".

Karl did the original quriks code. After that, whenever I tried to refactor or make it match to the spec, some tests start failing. There are a lot of unspec'ed behavior for line-height quirks, and Edge has different quirks for them.

Originally we thought we can fallback to legacy, but found too many tests are in quirks that we didn't want to lose their coverage. AFAIU, that's the reason we try to fix quirks. When we know reasons and only small number of tests hit, I don't think it's worth to fix.

Recent example: https://chromium-review.googlesource.com/c/chromium/src/+/1065751

It's quirk only. However, it's interoperable: I tested with Chrome, Firefox and IE, all of which have no gap under the image.

After all, it seems a pretty common pattern: <div><a href="..."><img></a></div>

So I think we'd better fix it?

Currently, we got 15 such failures in fast/table and tables/ (if inline fragments are created):

https://test-results.appspot.com/data/layout_results/linux_layout_tests_layout_ng/6995/layout-test-results/results.html

15 also seems too big to ignore.

Thanks for checking tests. 15 is a number easy to add <DOCTYPE> to "fix" them. What's more interesting is how much this breaks real sites, but that's not easy to know, and even if it does, if it drives changing pages to standard mode, it's a good thing.

Agree nice to fix, but it still doesn't look high priority to me.

All right.

2 of those tests are explicted marked as "quirks" so I guess we have to mark them as either Failure or Skip.

I'll convert the remaining ones.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5

commit d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Fri Jun 22 06:18:03 2018

[LayoutNG] Convert 14 quirks mode layout tests to standards mode

crrev.com/c/1108509 fixes some hit test behavior, but also reveals
a bug that we compute the wrong line height in quirks mode in some
cases.

Since quirks mode is of low priority for now, this patch converts
some quirks mode layout tests to standards mode to unblock
crrev.com/c/1108509.

Bug: 854840,  851075 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I0177d9a395368c5e361d191e1e742732f4fc0c52
Reviewed-on: https://chromium-review.googlesource.com/1111002
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569540}
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/fast/forms/form-element-geometry.html
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/forms/form-element-geometry-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/forms/form-element-geometry-expected.txt
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/tables/mozilla/bugs/bug4427-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/tables/mozilla/bugs/bug5538-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/tables/mozilla/bugs/bug78162-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/tables/mozilla/core/bloomberg-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/tables/mozilla_expected_failures/bugs/bug72393-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/linux/fast/forms/form-element-geometry-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/linux/fast/forms/form-element-geometry-expected.txt
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug10565-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug113424-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug1188-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug4427-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug4527-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug5538-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug78162-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug86708-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/core/bloomberg-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/other/ms-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug72393-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/form-element-geometry-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/form-element-geometry-expected.txt
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/mac-mac10.10/tables/mozilla/bugs/bug1188-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/form-element-geometry-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/form-element-geometry-expected.txt
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/mac-mac10.11/tables/mozilla/bugs/bug1188-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/mac-mac10.11/tables/mozilla/core/bloomberg-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/forms/form-element-geometry-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/mac-mac10.12/tables/mozilla/bugs/bug1188-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/form-element-geometry-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/mac-retina/tables/mozilla/bugs/bug4527-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/mac/fast/forms/form-element-geometry-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/mac/fast/forms/form-element-geometry-expected.txt
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla/bugs/bug10565-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla/bugs/bug113424-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla/bugs/bug1188-expected.png
[add] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla/bugs/bug26553-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla/bugs/bug4427-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla/bugs/bug4527-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla/bugs/bug5538-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla/bugs/bug78162-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla/bugs/bug86708-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla/core/bloomberg-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla/other/ms-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug23847-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug72393-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/win/fast/forms/form-element-geometry-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/win/fast/forms/form-element-geometry-expected.txt
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/win/tables/mozilla/bugs/bug10565-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/win/tables/mozilla/bugs/bug113424-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/win/tables/mozilla/bugs/bug1188-expected.png
[add] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/win/tables/mozilla/bugs/bug26553-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/win/tables/mozilla/bugs/bug4427-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/win/tables/mozilla/bugs/bug4527-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/win/tables/mozilla/bugs/bug5538-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/win/tables/mozilla/bugs/bug78162-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/win/tables/mozilla/bugs/bug86708-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/win/tables/mozilla/core/bloomberg-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/win/tables/mozilla/other/ms-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/win/tables/mozilla_expected_failures/bugs/bug23847-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/platform/win/tables/mozilla_expected_failures/bugs/bug72393-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/tables/mozilla/bugs/bug10565.html
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/tables/mozilla/bugs/bug113424.html
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/tables/mozilla/bugs/bug1188.html
[delete] https://crrev.com/36eaf8e14c06bf165668db7b54ea13db17b2ef65/third_party/WebKit/LayoutTests/tables/mozilla/bugs/bug26553-expected.png
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/tables/mozilla/bugs/bug26553.html
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/tables/mozilla/bugs/bug4427.html
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/tables/mozilla/bugs/bug4527.html
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/tables/mozilla/bugs/bug5538.html
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/tables/mozilla/bugs/bug78162.html
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/tables/mozilla/bugs/bug86708.html
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/tables/mozilla/core/bloomberg.html
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/tables/mozilla/other/ms.html
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/tables/mozilla_expected_failures/bugs/bug23847.html
[modify] https://crrev.com/d9aac9e91bf6742245583c91f8e6c11d8d6fdaf5/third_party/WebKit/LayoutTests/tables/mozilla_expected_failures/bugs/bug72393.html