XRSession.prototype.requestHitTest rejects promise on unsuccessful hit |
|||||||
Issue descriptionChrome Version: 69.0.3466.0 OS: Chrome for Android Occasionally, `XRSession.prototype.requestHitTest` upon an unsuccessful hit, will return an empty array -- other times, it'll reject the promise. The spec isn't clear on whether this promise can be rejected (I'll open an issue shortly there), but it at least should be consistent on hit-failure: either always return an empty array (ideal IMO), or always reject. What steps will reproduce the problem? (1) Ensure you have everything set up to run AR with WebXR (2) Go to https://web-education-ar-demo.appspot.com/ (3) Scroll down to model and click blue button to enter AR (4) trace the floor, move around What is the expected result? To not have a thrown error from requestHitTest being unable to succeed on a hit. What happens instead? Get errors thrown viewable in the console: "Uncaught (in promise) undefined"
,
Jul 23
,
Jul 23
,
Sep 4
,
Sep 20
if it repros, we should mark this as P2.
,
Oct 30
,
Nov 6
,
Dec 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f61ad483f82729343b651972320333297110756a commit f61ad483f82729343b651972320333297110756a Author: Piotr Bialecki <bialpio@chromium.org> Date: Fri Dec 21 22:54:31 2018 Hook up AR hit-test to 3D ARCore hit-test API Now that we can use ARCore SDK 1.5, we can start using 3D version of hit test and remove previously used one. Since we no longer use ArFrame_hitTest, it is getting removed from arcore_shim.cc. Bug: 835948, 854823 Change-Id: Ibf8e953135b04925dbebd384e16f8f08ad52a869 Reviewed-on: https://chromium-review.googlesource.com/c/1357723 Reviewed-by: Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#618649} [modify] https://crrev.com/f61ad483f82729343b651972320333297110756a/chrome/browser/android/vr/arcore_device/arcore.h [modify] https://crrev.com/f61ad483f82729343b651972320333297110756a/chrome/browser/android/vr/arcore_device/arcore_gl.cc [modify] https://crrev.com/f61ad483f82729343b651972320333297110756a/chrome/browser/android/vr/arcore_device/arcore_gl.h [modify] https://crrev.com/f61ad483f82729343b651972320333297110756a/chrome/browser/android/vr/arcore_device/arcore_impl.cc [modify] https://crrev.com/f61ad483f82729343b651972320333297110756a/chrome/browser/android/vr/arcore_device/arcore_impl.h [modify] https://crrev.com/f61ad483f82729343b651972320333297110756a/chrome/browser/android/vr/arcore_device/arcore_shim.cc [modify] https://crrev.com/f61ad483f82729343b651972320333297110756a/chrome/browser/android/vr/arcore_device/fake_arcore.cc [modify] https://crrev.com/f61ad483f82729343b651972320333297110756a/chrome/browser/android/vr/arcore_device/fake_arcore.h
,
Dec 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19403331035331c985f2ec8ee740ab50545ecc88 commit 19403331035331c985f2ec8ee740ab50545ecc88 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Sat Dec 22 08:02:35 2018 Revert "Hook up AR hit-test to 3D ARCore hit-test API" This reverts commit f61ad483f82729343b651972320333297110756a. Reason for revert: Needs to be reverted due to revert of dbf4acb16a15c8e3fa55a8b689d9571693aa34a9 Original change's description: > Hook up AR hit-test to 3D ARCore hit-test API > > Now that we can use ARCore SDK 1.5, we can start using 3D version of > hit test and remove previously used one. Since we no longer use > ArFrame_hitTest, it is getting removed from arcore_shim.cc. > > Bug: 835948, 854823 > Change-Id: Ibf8e953135b04925dbebd384e16f8f08ad52a869 > Reviewed-on: https://chromium-review.googlesource.com/c/1357723 > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Commit-Queue: Piotr Bialecki <bialpio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618649} TBR=ddorwin@chromium.org,klausw@chromium.org,bialpio@chromium.org Change-Id: I7204392419d6d18449b7a5ad97b1a668e9829763 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 835948, 854823 Reviewed-on: https://chromium-review.googlesource.com/c/1390036 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#618742} [modify] https://crrev.com/19403331035331c985f2ec8ee740ab50545ecc88/chrome/browser/android/vr/arcore_device/arcore.h [modify] https://crrev.com/19403331035331c985f2ec8ee740ab50545ecc88/chrome/browser/android/vr/arcore_device/arcore_gl.cc [modify] https://crrev.com/19403331035331c985f2ec8ee740ab50545ecc88/chrome/browser/android/vr/arcore_device/arcore_gl.h [modify] https://crrev.com/19403331035331c985f2ec8ee740ab50545ecc88/chrome/browser/android/vr/arcore_device/arcore_impl.cc [modify] https://crrev.com/19403331035331c985f2ec8ee740ab50545ecc88/chrome/browser/android/vr/arcore_device/arcore_impl.h [modify] https://crrev.com/19403331035331c985f2ec8ee740ab50545ecc88/chrome/browser/android/vr/arcore_device/arcore_shim.cc [modify] https://crrev.com/19403331035331c985f2ec8ee740ab50545ecc88/chrome/browser/android/vr/arcore_device/fake_arcore.cc [modify] https://crrev.com/19403331035331c985f2ec8ee740ab50545ecc88/chrome/browser/android/vr/arcore_device/fake_arcore.h
,
Jan 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4000c195657ff2012a2cd03de45f8ce6dabf55f commit a4000c195657ff2012a2cd03de45f8ce6dabf55f Author: Piotr Bialecki <bialpio@chromium.org> Date: Tue Jan 08 20:01:50 2019 Reland "Hook up AR hit-test to 3D ARCore hit-test API" This is a reland of f61ad483f82729343b651972320333297110756a Original CL got reverted due to dependency on CL to upgrade ARCore SDK to version 1.5, which got reverted. Now that the ARCore SDK is at version 1.5, we can reland this CL. Original change's description: > Hook up AR hit-test to 3D ARCore hit-test API > > Now that we can use ARCore SDK 1.5, we can start using 3D version of > hit test and remove previously used one. Since we no longer use > ArFrame_hitTest, it is getting removed from arcore_shim.cc. > > Bug: 835948, 854823 > Change-Id: Ibf8e953135b04925dbebd384e16f8f08ad52a869 > Reviewed-on: https://chromium-review.googlesource.com/c/1357723 > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Commit-Queue: Piotr Bialecki <bialpio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618649} TBR=klausw@chromium.org Bug: 835948, 854823 Change-Id: I99c2514b3a25a84884eae713205c6b3c34688b1e Reviewed-on: https://chromium-review.googlesource.com/c/1399286 Reviewed-by: Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#620850} [modify] https://crrev.com/a4000c195657ff2012a2cd03de45f8ce6dabf55f/chrome/browser/android/vr/arcore_device/arcore.h [modify] https://crrev.com/a4000c195657ff2012a2cd03de45f8ce6dabf55f/chrome/browser/android/vr/arcore_device/arcore_gl.cc [modify] https://crrev.com/a4000c195657ff2012a2cd03de45f8ce6dabf55f/chrome/browser/android/vr/arcore_device/arcore_gl.h [modify] https://crrev.com/a4000c195657ff2012a2cd03de45f8ce6dabf55f/chrome/browser/android/vr/arcore_device/arcore_impl.cc [modify] https://crrev.com/a4000c195657ff2012a2cd03de45f8ce6dabf55f/chrome/browser/android/vr/arcore_device/arcore_impl.h [modify] https://crrev.com/a4000c195657ff2012a2cd03de45f8ce6dabf55f/chrome/browser/android/vr/arcore_device/arcore_shim.cc [modify] https://crrev.com/a4000c195657ff2012a2cd03de45f8ce6dabf55f/chrome/browser/android/vr/arcore_device/fake_arcore.cc [modify] https://crrev.com/a4000c195657ff2012a2cd03de45f8ce6dabf55f/chrome/browser/android/vr/arcore_device/fake_arcore.h |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by jsant...@google.com
, Jun 20 2018