New issue
Advanced search Search tips

Issue 854821 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 854267



Sign in to add a comment

Fix Print Preview Unit Tests with MacViews Enabled

Project Member Reported by robliao@chromium.org, Jun 20 2018

Issue description

These unit_tests fail:
PrintPreviewDialogControllerUnitTest.MultiplePreviewDialogsClose
PrintPreviewUIUnitTest.PrintPreviewDraftPages
PrintPreviewDialogControllerUnitTest.ClearInitiatorDetails
PrintPreviewUIUnitTest.PrintPreviewData
PrintPreviewUIUnitTest.GetCurrentPrintPreviewStatus
PrintPreviewDialogControllerUnitTest.GetOrCreatePreviewDialog
PrintPreviewDialogControllerUnitTest.CloseDialogOnNavigation
 
Labels: Proj-MacViews
Status: Fixed (was: Started)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3045a6e26dbfb23a21c79cf122b2b1cb786332fd

commit 3045a6e26dbfb23a21c79cf122b2b1cb786332fd
Author: Robert Liao <robliao@chromium.org>
Date: Thu Jun 21 22:57:58 2018

Set a ConstrainedDialogWebView Minimum Size of 1x1 on Mac

MacOS does not handle zero-sized windows well.

BUG= 854267 

Change-Id: I3da67cef7abdc035ca6378d5cb31dc68a097ee67
Reviewed-on: https://chromium-review.googlesource.com/1109200
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569402}
[modify] https://crrev.com/3045a6e26dbfb23a21c79cf122b2b1cb786332fd/chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc

Sign in to add a comment