New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 854820 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature

Blocked on:
issue 799950



Sign in to add a comment

Feature request: --no-install flag for run_benchmark script to use an already-installed WebView

Project Member Reported by ntfschr@chromium.org, Jun 20 2018

Issue description

It seems like whenever I run the webview startup benchmark in a particular checkout, it re-installs Monochrome (or systemwebviewgoogle) from that checkout. I would like to use this script to run benchmarks on a monochrome I install myself.

Can we add a --no-install flag to the script? This flag should prevent the script from reinstalling monochrome, and it should also *not* change the monochrome provider (it can assume I've already installed a suitable webview and set the monochrome provider).

To clarify, I run the webview startup benchmark with:

$ tools/perf/run_benchmark system_health.webview_startup --browser android-webview-google -v --pageset-repeat=1
$ # this command installs Monochrome, which I found very surprising (and not always what I want)

---

Some use cases I have in mind:

 1. I want to install systemwebviewgoogle instead of monochrome. I always develop with systemwebviewgoogle on N+ because it builds and installs faster than monochrome. If the script requires monochrome, I have to spend extra time building and installing monochrome
 2. I want to install an official build from android-bourbon. I understand these builds will *not* use the GN arg "enable_profiling = true", but I assume that I can still get some useful information from such builds.
    * If I've misunderstood, and this configuration will *not* give any useful information, please let me know.
 
Labels: -Type-Bug Type-Feature
Blockedon: 799950
Cc: nednguyen@chromium.org
Yeah, the larger problem is issue 799950, in which the browser selection logic in Telemetry is quite confusing and doesn't fit well with use cases like this one.

We'll need to consider this when thinking about how to revamp browser selection.
perezju@ do we have a workaround in the mean-time? For example, what if I do something like:

$ cp path/to/desired-webview.apk out/Default/apks/Monochrome.apk
$ tools/perf/run_benchmark system_health.webview_startup --browser android-webview-google -v --pageset-repeat=1
$ # my intention is to trick the script into installing desired-webview.apk, but I'm not sure which out/ folder it actually uses
Labels: Pri-3

Sign in to add a comment