New issue
Advanced search Search tips

Issue 854809 link

Starred by 1 user
Status: Fixed
Owner:
malaykeshav@chromium.org
Closed: Jun 2018
Cc:
afakhry@chromium.org
ovanieva@chromium.org
osh...@chromium.org
steve...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Display settings page crashed on linux CrOS build with multi monitor

Project Member Reported by malaykeshav@chromium.org, Jun 20 2018 
Chrome Version: 68

What steps will reproduce the problem?
(1) Add an external display with ash dev shortcut ctrl + shift + D
(2) Goto chrome://settings/display
(3) Navigate to the secondary display

What is the expected result?
You are able to navigate to the settings and prefs for the secondary display.

What happens instead?
The settings page crashes.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d767cab0621366a88239536f0ee53b5f2ccdb159

commit d767cab0621366a88239536f0ee53b5f2ccdb159
Author: Malay Keshav <malaykeshav@chromium.org>
Date: Thu Jun 21 18:37:42 2018

Update the aria labels only if the index is updated

This patch ensures that the aria labels are updated only when the index
is updated on the display size slider. Without this we may update the
aria label with an index in the array that is out of bounds. This
happens in certain race conditions where the index has been updated but
the array has not or vice versa.

Bug:  854809 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I23807fe8b0a27ead8323b7a3d484db14ce79bf7d
Component: Display Size slider, display settings
Reviewed-on: https://chromium-review.googlesource.com/1108933
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569334}
[modify] https://crrev.com/d767cab0621366a88239536f0ee53b5f2ccdb159/chrome/browser/resources/settings/device_page/display_size_slider.js

Comment 2 by malaykeshav@chromium.org, Jun 21 2018

Status: Fixed (was: Started)
►

Sign in to add a comment