New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 854807 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 860367



Sign in to add a comment

the highlight of the time indicator in the shelf does not cover well when resized

Project Member Reported by mukai@chromium.org, Jun 20 2018

Issue description

Google Chrome	69.0.3464.0 (Official Build) dev (64-bit)
Revision	3c26b60e3842fee660bcff5eb35aa0587d795f02-refs/branch-heads/3464@{#1}
Platform	10798.0.0 (Official Build) dev-channel eve

What steps will reproduce the problem?
(1) clear the all notifications
(2) open the system tray (ctrl-shift-I)
(3) ctrl-F5 to take the screenshot

What is the expected result?
The highlight gets resized

What happens instead?
The highlight moves but not gets resized

See the screenshot



Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 
Screenshot 2018-06-20 at 15.05.46.png
4.9 KB View Download

Comment 1 by tetsui@chromium.org, Jun 21 2018

Cc: yamaguchi@chromium.org yoshiki@chromium.org
Labels: -Pri-3 M-69 Pri-2
Owner: tetsui@chromium.org
Status: Assigned (was: Available)

Comment 2 by tetsui@chromium.org, Jun 21 2018

Cc: tetsui@chromium.org
 Issue 853655  has been merged into this issue.

Comment 3 by tetsui@chromium.org, Jun 21 2018

Issue 669253 has been merged into this issue.
Labels: Not-Touch-Friendly-Launcher
Blockedon: 860367
Issue 861892 has been merged into this issue.
Cc: ajha@chromium.org
 Issue 860652  has been merged into this issue.
Labels: -M-69 M-70
Labels: -Pri-2 Pri-1
sgabriel@ mentioned this is P1
Cc: weiliangc@chromium.org
Cc: manucornet@chromium.org mccanny@chromium.org omrilio@chromium.org sgabr...@chromium.org kejiashao@chromium.org
Issue 876532 has been merged into this issue.
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d35da84fdaae2a3c745a4e0703573da403aa8df6

commit d35da84fdaae2a3c745a4e0703573da403aa8df6
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Tue Aug 28 16:55:18 2018

Unified: Workaround tray btn highlight resize bug

This CL workarounds a ui::Layer mask bug for UnifiedSystemTray.
ui::Layer mask does not update properly when a layer is resized.
I reached out to cc OWNERS but couldn't figure out the way to fix the
bug on cc:: or ui:: side. As the tray button highlight issue is easily
noticeable by users, we workaround the problem in ash for now.

Steps to repro:
1. Open UnifiedSystemTray
2. Click do-not-disturb button
3. System Tray button highlight does not resize
   (See the screenshot on the bug)

TEST=manual
BUG= 854807 ,860367

Change-Id: Ic6dcefde8d0263e2e31953621b8c43f522696aba
Reviewed-on: https://chromium-review.googlesource.com/1193042
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586749}
[modify] https://crrev.com/d35da84fdaae2a3c745a4e0703573da403aa8df6/ash/system/unified/unified_system_tray.cc
[modify] https://crrev.com/d35da84fdaae2a3c745a4e0703573da403aa8df6/ash/system/unified/unified_system_tray.h

Status: Fixed (was: Assigned)

Sign in to add a comment