New issue
Advanced search Search tips

Issue 854804 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: false in gles2_cmd_copy_texture_chromium.cc

Project Member Reported by ClusterFuzz, Jun 20 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4989749547499520

Fuzzer: libFuzzer_gpu_raster_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  false in gles2_cmd_copy_texture_chromium.cc
  gpu::gles2::GetFragmentShaderId
  gpu::gles2::CopyTextureResourceManagerImpl::DoCopyTextureInternal
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=564546:564563

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4989749547499520

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 20 2018

Components: Internals>GPU>Internals
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jun 20 2018

Cc: piman@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, Jun 20 2018

Labels: Test-Predator-Auto-Owner
Owner: backer@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/774e03c6946af8fa37f226e3446bd80a5d27fd37 (Remove levels from RasterInterface).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 4 by ClusterFuzz, Jul 3

ClusterFuzz has detected this issue as fixed in range 572025:572026.

Detailed report: https://clusterfuzz.com/testcase?key=4989749547499520

Fuzzer: libFuzzer_gpu_raster_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  false in gles2_cmd_copy_texture_chromium.cc
  gpu::gles2::GetFragmentShaderId
  gpu::gles2::CopyTextureResourceManagerImpl::DoCopyTextureInternal
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=564546:564563
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=572025:572026

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4989749547499520

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Jul 3

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4989749547499520 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cb165c8fc0aa857fc9b95fd7a186a4d638d2b23

commit 4cb165c8fc0aa857fc9b95fd7a186a4d638d2b23
Author: Jonathan Backer <backer@chromium.org>
Date: Tue Jul 03 20:25:33 2018

Validate texture formats for CopySubTextureCHROMIUM

Refactors some GLES2Decoder code for reuse by RasterDecoder. This
validation avoids NOTREACHED within gles2_cmd_copy_texture_chromium.cc
in GetFragmentShaderId.

Bug:  854804 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie1edbef68d65449ac2e84949ac7ac0d7b5ebb0cf
Reviewed-on: https://chromium-review.googlesource.com/1124962
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572336}
[modify] https://crrev.com/4cb165c8fc0aa857fc9b95fd7a186a4d638d2b23/gpu/command_buffer/service/gl_utils.cc
[modify] https://crrev.com/4cb165c8fc0aa857fc9b95fd7a186a4d638d2b23/gpu/command_buffer/service/gl_utils.h
[modify] https://crrev.com/4cb165c8fc0aa857fc9b95fd7a186a4d638d2b23/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/4cb165c8fc0aa857fc9b95fd7a186a4d638d2b23/gpu/command_buffer/service/raster_decoder.cc
[modify] https://crrev.com/4cb165c8fc0aa857fc9b95fd7a186a4d638d2b23/gpu/command_buffer/service/raster_decoder_unittest.cc
[modify] https://crrev.com/4cb165c8fc0aa857fc9b95fd7a186a4d638d2b23/gpu/command_buffer/service/raster_decoder_unittest_base.cc
[modify] https://crrev.com/4cb165c8fc0aa857fc9b95fd7a186a4d638d2b23/gpu/command_buffer/service/raster_decoder_unittest_base.h

CL references in comment #6 is the real fix. The previous "fix" just invalidated the test case that clusterfuzz found but adding some enums to viz::ResourceFormat

Sign in to add a comment