Issue 854792 link

Starred by 1 user

Issue metadata

Status:	Assigned
Owner:	jchin...@chromium.org
Cc:	no...@chromium.org
Components:	Infra>Platform>Buildbucket
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	1
Type:	Feature

Blocking:
issue 853450

Implement annotation proto -> buildbucket.v2.Build converter in Go

Project Member Reported by no...@chromium.org, Jun 20 2018

Issue description

Implement annotation.proto Step to buildbucket.v2.Build converter in Go.
It will be used in kitchen for  bug 853450 

some reference implementations:
- annotation proto -> buildbot.Buil in Go: 
https://cs.chromium.org/chromium/infra/go/src/go.chromium.org/luci/milo/buildsource/buildbot/buildstore/annotations.go
- annotation proto -> buildbucket.v2.Build in python
https://cs.chromium.org/chromium/infra/appengine/cr-buildbucket/v2/steps.py

the latter is a port of the former.

Project Member

Comment 1 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/29575879a364f9207dd4fd232f03e74ad12b488a

commit 29575879a364f9207dd4fd232f03e74ad12b488a
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Wed Aug 01 05:24:25 2018

[buildbucket] Set up annotations->Buildbucket v2 converter.

BUG=854792

Change-Id: I0a42dfd6d8097b1d941236dafdb736b9a0df993a
Reviewed-on: https://chromium-review.googlesource.com/1147515
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[add] https://crrev.com/29575879a364f9207dd4fd232f03e74ad12b488a/buildbucket/annotations.go
[add] https://crrev.com/29575879a364f9207dd4fd232f03e74ad12b488a/buildbucket/annotations_test.go
[add] https://crrev.com/29575879a364f9207dd4fd232f03e74ad12b488a/buildbucket/testdata/annotations/annotations.pb.txt
[add] https://crrev.com/29575879a364f9207dd4fd232f03e74ad12b488a/buildbucket/testdata/annotations/expected_steps.pb.txt

►

Issue 854792 link

Issue metadata

Implement annotation proto -> buildbucket.v2.Build converter in Go

Issue description

Comment 1 by bugdroid1@chromium.org, Aug 1

Comment 1 Deleted

Sign in to add a comment