New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 854774 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jul 10
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-06-25
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: audio_thread_checker_.CalledOnValidThread() in webrtc_audio_sink.cc

Project Member Reported by ClusterFuzz, Jun 20 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6444274783354880

Fuzzer: phoglund_webrtc_peerconnection
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  audio_thread_checker_.CalledOnValidThread() in webrtc_audio_sink.cc
  content::WebRtcAudioSink::OnData
  content::MediaStreamAudioDeliverer<content::MediaStreamAudioSink>::OnData
  
Sanitizer: address (ASAN)

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6444274783354880

Additional requirements: Requires HTTP

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Cc: m...@chromium.org brajkumar@chromium.org
Components: Blink>WebRTC>Audio
Labels: M-68 Test-Predator-Wrong
Unable to find actual suspect through code search and also observing no suspected CL's under regression range, hence adding appropriate label and requesting someone from blink team to look in to this issue.

Thanks!
Labels: CF-NeedsTriage
Cc: maxmorin@chromium.org
Components: Internals>Media>Audio Blink>WebAudio
Labels: OS-Android OS-Chrome OS-Mac OS-Windows
NextAction: 2018-06-25
Most likely just a bad thread check. Will have a look on Monday if no one else takes it first.
The NextAction date has arrived: 2018-06-25
Project Member

Comment 5 by ClusterFuzz, Jun 25 2018

Labels: -Reproducible Unreproducible
ClusterFuzz testcase 6444274783354880 appears to be flaky, updating reproducibility label.
Project Member

Comment 6 by ClusterFuzz, Jun 25 2018

Components: Blink>GetUserMedia
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.

Comment 7 by guidou@chromium.org, Jun 25 2018

Components: -Blink>GetUserMedia
Owner: maxmorin@chromium.org
Status: Assigned (was: Untriaged)
What happens is that the SilentSinkSuspender kicks in. It has its own worker pumping audio, thus thread check. Not dangerous at all, I guess I'll just remove the thread check.
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bcd889423b7aac3b257274adfa001661fc658e9

commit 0bcd889423b7aac3b257274adfa001661fc658e9
Author: Max Morin <maxmorin@chromium.org>
Date: Thu Jun 28 11:34:48 2018

Remove overeager WebRTCAudioSink thread check.

The callback thread thread check may trigger if the
SilentSinkSuspender sets in.

Drive-by update the other thread check of this class to use a macro
and add missing includes.

Bug:  854774 
Change-Id: I79f7c56886acd7f1ad56c466eb0c2825d1d8ec16
Reviewed-on: https://chromium-review.googlesource.com/1114973
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571081}
[modify] https://crrev.com/0bcd889423b7aac3b257274adfa001661fc658e9/content/renderer/media/webrtc/webrtc_audio_sink.cc
[modify] https://crrev.com/0bcd889423b7aac3b257274adfa001661fc658e9/content/renderer/media/webrtc/webrtc_audio_sink.h

Project Member

Comment 11 by ClusterFuzz, Jul 10

Status: WontFix (was: Assigned)
ClusterFuzz testcase 6444274783354880 is flaky and no longer crashes, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment