DRM-atomic: Disabling degamma seems to disable color management completely |
||||
Issue descriptionToT Chrome on Eve CTM is configured to a red shift. Gamma/degamma is left disabled (value=0). Atomic commit contains CTM, gamma, degamma. Expected to see red shift. Saw no color correction See test to reproduce the issue: https://chromium-review.googlesource.com/c/chromiumos/platform/drm-tests/+/1108513
,
Jul 6
Daniele I moved to a different project, please copy Nathan Ciobanu instead (I would have helped anyway but I know nothing about color management) By the way there's a serious misconfiguration problem with this bug tracker: most people I know cannot remove themselves from Cc:. I'm all for erring on the over-communication side but it shouldn't be possible to add people in Cc: unless they can opt out later. Is there a project where bugs can be filed about the bug tracker itself?
,
Jul 6
Thank you for the update. I'm not sure where to file bugs regarding the cc issue. Maybe https://bugs.chromium.org/p/monorail/issues/list? Let me know if you want to be removed from the issue in the meanwhile.
,
Jul 6
Please cc Prathyushi Nangia for Intel bug triage.
,
Jul 25
,
Jul 26
Is this a regression?
,
Jul 26
Unclear. I don't know if we've ever tested this previously. Until now we've been relying on setting CTM,GAMMA_LUT and DEGAMMA_LUT as part of separate commit commands. This sets all 3 as part of the same DRM atomic commit.
,
Jul 26
> I'm not sure where to file bugs regarding the cc issue. Maybe https://bugs.chromium.org/p/monorail/issues/list? Yes - and already filed in 2016 as issue 1852 https://bugs.chromium.org/p/monorail/issues/detail?id=1852 https://bugs.chromium.org/p/monorail/issues/list?q=unsubscribe There's also a useful "feedback" link at the bottom of this page. > Let me know if you want to be removed from the issue in the meanwhile. Yes please.
,
Jul 27
,
Jul 27
We are working on initial triage.
,
Aug 7
atomictest is PASSing with latest CPFE. Red color shift also observed.
Find the DUT configurations below:
Board: eve
OS: 10924.0.0 (Official Build) dev-channel eve test
Chrome: Google Chrome 70.0.3505.0 unknown
FW: Google_Eve.9584.107.0
EC: eve_v1.1.6585-859d2ea99
CPU: Intel(R) Core(TM) i5-7Y57 CPU @ 1.20GHz (4 cores)
Kernel: Linux 4.4.144-14598-g91681b08b2f3 x86_64
Mem: 8GB (physical)
Applied the atomictest patch to test https://chromium-review.googlesource.com/c/chromiumos/platform/drm-tests/+/1108513
atomictest FAILed for 1st time but subsequent tests PASSed. Log attached below:
localhost ~ # stop ui
ui stop/waiting
localhost ~ # atomictest -t crtc_ctm -c 0
Committing the following configuration:
----- [CRTC: 35] -----
{Plane ID: 26, Plane format: XR24, Plane type: primary, CRTC_X: 0, CRTC_Y: 0, CRTC_W: 2400, CRTC_H: 1600}
Committing the following configuration:
----- [CRTC: 35] -----
{Plane ID: 26, Plane format: XR24, Plane type: primary, CRTC_X: 0, CRTC_Y: 0, CRTC_W: 2400, CRTC_H: 1600}
Committing the following configuration:
----- [CRTC: 35] -----
ERROR:commit():atomictest.c:594:failed with error: -22
Committing the following configuration:
----- [CRTC: 35] -----
ERROR:commit():atomictest.c:594:failed with error: -22
ERROR:run_testcase():atomictest.c:1486:failed with error: -1
[ FAILED ] atomictest.crtc_ctm
localhost ~ # atomictest -t crtc_ctm -c 0
Committing the following configuration:
----- [CRTC: 35] -----
{Plane ID: 26, Plane format: XR24, Plane type: primary, CRTC_X: 0, CRTC_Y: 0, CRTC_W: 2400, CRTC_H: 1600}
Committing the following configuration:
----- [CRTC: 35] -----
{Plane ID: 26, Plane format: XR24, Plane type: primary, CRTC_X: 0, CRTC_Y: 0, CRTC_W: 2400, CRTC_H: 1600}
Committing the following configuration:
----- [CRTC: 35] -----
[ PASSED ] atomictest.crtc_ctm
If this issue is resolved, then recommending close this bug.
,
Aug 8
Hi Danele, I am seeing a redshift after applying atomictest patch https://chromium-review.googlesource.com/c/chromiumos/platform/drm-tests/+/1108513. attached video FYR. Is this the behavior expected?
,
Jan 14
That doesn't look right. Are you sure you updated the binary (or are running the updated binary)? Attaching a video of what it should look like. Note, I'm not seeing the red shift in the video on Eve. |
||||
►
Sign in to add a comment |
||||
Comment 1 by dcasta...@chromium.org
, Jul 6