New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 854744 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"telemetry.internal.actions.action_runner_unittest.ActionRunnerTest.testWaitForJavaScriptCondition" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 20 2018

Issue description

"telemetry.internal.actions.action_runner_unittest.ActionRunnerTest.testWaitForJavaScriptCondition" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNybAsSBUZsYWtlImF0ZWxlbWV0cnkuaW50ZXJuYWwuYWN0aW9ucy5hY3Rpb25fcnVubmVyX3VuaXR0ZXN0LkFjdGlvblJ1bm5lclRlc3QudGVzdFdhaXRGb3JKYXZhU2NyaXB0Q29uZGl0aW9uDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
This is flaking about twice a day on Mac. Let me disable for now.
Cc: nednguyen@chromium.org
Components: Speed>Telemetry Tests>Telemetry
Owner: nednguyen@chromium.org
Status: Assigned (was: Untriaged)
If I understand correctly, the PRESUBMIT is not happy we me uploading a CL here since I'm not a catapult commiter.

nednguyen@, can you PTAL?
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/b8f8dd3867a92b1860ba51e1b918a2eb730b55e2

commit b8f8dd3867a92b1860ba51e1b918a2eb730b55e2
Author: Nghia Nguyen <nednguyen@google.com>
Date: Thu Jun 21 13:44:52 2018

Disable testWaitForJavaScriptCondition on Mac

Bug: chromium:854744
Change-Id: I9d6339275ded2f02e058ae2debf743a483caddef

TBR=kbr@chromium.org

Change-Id: I9d6339275ded2f02e058ae2debf743a483caddef
Reviewed-on: https://chromium-review.googlesource.com/1110017
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/b8f8dd3867a92b1860ba51e1b918a2eb730b55e2/telemetry/telemetry/internal/actions/action_runner_unittest.py

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d370bf6746dba7d05a325c314cfc12b2693beb9c

commit d370bf6746dba7d05a325c314cfc12b2693beb9c
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Jun 21 18:47:17 2018

Roll src/third_party/catapult 44fc6f687b35..53842b6cbc1f (11 commits)

https://chromium.googlesource.com/catapult.git/+log/44fc6f687b35..53842b6cbc1f


git log 44fc6f687b35..53842b6cbc1f --date=short --no-merges --format='%ad %ae %s'
2018-06-21 ckitagawa@chromium.org [Devil] Fix pylint typecheck errors
2018-06-21 perezju@chromium.org [Telemetry] Add clear_caches option to possible_browser.Create
2018-06-21 charliea@chromium.org Tell sqlite3 to use a write-ahead mode
2018-06-21 perezju@chromium.org Fix index of timeseries data frames
2018-06-21 perezju@chromium.org [Telemetry] Do not cache installed apps in AndroidPlatformBackend
2018-06-21 benjhayden@chromium.org Increase Anomaly query limit in graph_json.
2018-06-21 nednguyen@google.com Disable testWaitForJavaScriptCondition on Mac
2018-06-21 perezju@chromium.org [Telemetry] Example: restart browser during story
2018-06-21 perezju@chromium.org [Telemetry] Fix pylint unidiomatic-typecheck warnings
2018-06-21 perezju@chromium.org [soundwave] Code health in dashboard_api.py
2018-06-21 perezju@chromium.org [soundwave] Follow cursor on fetch alerts API call


Created with:
  gclient setdep -r src/third_party/catapult@53842b6cbc1f

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:811244,chromium:711073,chromium:854744, chromium:849703 , chromium:854986 
TBR=sullivan@chromium.org

Change-Id: I7a6383560447cee344a85996f9a7f595e0e9088c
Reviewed-on: https://chromium-review.googlesource.com/1110297
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#569338}
[modify] https://crrev.com/d370bf6746dba7d05a325c314cfc12b2693beb9c/DEPS

Labels: -Sheriff-Chromium

Comment 6 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 7 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Tests>Telemetry

Comment 8 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry

Sign in to add a comment