Create/use "default" and "default_debug" email templates. |
||
Issue descriptionRight now, there is a single (default) email template for all ChromeOS build notifications. It's only used for tryjobs. We should define a "default_debug" template, and have "cros tryjob" specify it in the tryjob request when "--debug" is used. This will allow us to add new templates and test them before affecting users. PS: We could create a "tryjob" specific template, but on reflection, I just don't see the point of maintaining both a default and tryjob template, yet.
,
Jun 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/889be785576d9dbbd275b1ae1bf9e9a5bb5dc613 commit 889be785576d9dbbd275b1ae1bf9e9a5bb5dc613 Author: Don Garrett <dgarrett@google.com> Date: Thu Jun 21 23:31:19 2018 cros_tryjob: Use "default_debug" email template for --debug. Also, add support to lib/request_build for specifying which LUCI Notify email template to use. BUG= chromium:854734 TEST=run_tests lib/request_build_unittest --network cros tryjob --debug success-build Change-Id: Ia88597e28c1b14a2a645098ab9b5f611c98da0dd Reviewed-on: https://chromium-review.googlesource.com/1108245 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Mike Nichols <mikenichols@chromium.org> [modify] https://crrev.com/889be785576d9dbbd275b1ae1bf9e9a5bb5dc613/lib/request_build.py [modify] https://crrev.com/889be785576d9dbbd275b1ae1bf9e9a5bb5dc613/lib/request_build_unittest.py [modify] https://crrev.com/889be785576d9dbbd275b1ae1bf9e9a5bb5dc613/cli/cros/cros_tryjob.py
,
Jun 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9cac21c5d564a4ad329e6f9d743e3708f2b8b12 commit b9cac21c5d564a4ad329e6f9d743e3708f2b8b12 Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Jun 22 01:32:08 2018 Roll src/third_party/chromite 0d22d3fa3ae1..694c8ff073d5 (7 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/0d22d3fa3ae1..694c8ff073d5 git log 0d22d3fa3ae1..694c8ff073d5 --date=short --no-merges --format='%ad %ae %s' 2018-06-21 metzman@chromium.org [fuzzing] Make env more realistic 2018-06-21 dgarrett@google.com cros_tryjob: Use "default_debug" email template for --debug. 2018-06-21 ayatane@chromium.org Revert "chromeos-infra-go: Disable tests" 2018-06-21 dgarrett@google.com cbuildbot_launch: Tiny tweak to _MaybeCleanDistfiles. 2018-06-21 dgarrett@google.com cbuildbot: Remove .trybot marker concept. 2018-06-21 dgarrett@google.com config_lib: Remove config_lib.UseBuildbucketScheduler. 2018-06-21 dgarrett@google.com buildbucket_lib: Remove config_lib.UseBuildbucketScheduler. Created with: gclient setdep -r src/third_party/chromite@694c8ff073d5 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:648042, chromium:854734 , chromium:852633 ,chromium:None,chromium:None,chromium:853025,chromium:853025 TBR=chrome-os-gardeners@chromium.org Change-Id: Ifce3485cd2e96d41803591c9a039daf716555a68 Reviewed-on: https://chromium-review.googlesource.com/1111158 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569494} [modify] https://crrev.com/b9cac21c5d564a4ad329e6f9d743e3708f2b8b12/DEPS
,
Jun 22 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/1256a1327d8b577ba7fdd82d98ad47fc9ee0431f commit 1256a1327d8b577ba7fdd82d98ad47fc9ee0431f Author: Don Garrett <dgarrett@google.com> Date: Fri Jun 22 21:06:56 2018
,
Jun 22 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/7359af5fb4d5d17d060110daa9880134561de4c6 commit 7359af5fb4d5d17d060110daa9880134561de4c6 Author: Don Garrett <dgarrett@google.com> Date: Fri Jun 22 22:21:35 2018
,
Jun 22 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/900e9b94bc504646b5a7321b8de9bef7cc54db78 commit 900e9b94bc504646b5a7321b8de9bef7cc54db78 Author: Don Garrett <dgarrett@google.com> Date: Fri Jun 22 22:43:23 2018
,
Jun 22 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/e969c31669240694558a1991e488acbdf15182e2 commit e969c31669240694558a1991e488acbdf15182e2 Author: Don Garrett <dgarrett@google.com> Date: Fri Jun 22 22:58:46 2018
,
Jun 25 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/61149e989e325bd121e8d1f3a4a277aa38df859d commit 61149e989e325bd121e8d1f3a4a277aa38df859d Author: Don Garrett <dgarrett@google.com> Date: Mon Jun 25 15:36:58 2018
,
Jun 26 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jun 20 2018