Following the OS_POSIX removal for the Fuchsia build, we still have some conditionals set up as such: #if defined(OS_POSIX) && !defined(OS_FUCHSIA) This is a tracking bug to remove the remaining cases and clean these up once and for all.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7a145a480fce8250e34a9444f0ab105310f57be commit c7a145a480fce8250e34a9444f0ab105310f57be Author: Wez <wez@chromium.org> Date: Mon Jul 09 19:58:46 2018 Correct some OS_POSIX || OS_FUCHSIA conditionals in ProcessUtilTests. Similar to the OS_POSIX && !OS_FUCHSIA sites that need cleaning up, we have a few sites which still use OS_POSIX || OS_FUCHSIA incorrectly, in this case the ProcessUtilTests concerned with kill() / signals. Bug: 854721 Change-Id: Id7896b1ca3ff3da3db6e6444eabc49bf9218de4b Reviewed-on: https://chromium-review.googlesource.com/1129632 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#573417} [modify] https://crrev.com/c7a145a480fce8250e34a9444f0ab105310f57be/base/process/process_util_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3553913abdd97123c3937277f26cba44e6eacacf commit 3553913abdd97123c3937277f26cba44e6eacacf Author: Wez <wez@chromium.org> Date: Tue Jul 17 11:26:05 2018 Remove redundant !OS_FUCHSIA checks from OS_POSIX sites. We no longer define OS_POSIX under Fuchsia, so the !OS_FUCHSIA part of these conditionals is no longer required. TBR: jsbell, gab, thestig, rockot, kbr, sergeyu, skyostil, fdegans, alexmos, asanka Bug: 854721 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia35a44036d520a6b5104ac3ee12f5469cbaf457f Reviewed-on: https://chromium-review.googlesource.com/1135898 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Asanka Herath <asanka@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#575604} [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/base/allocator/partition_allocator/page_allocator_unittest.cc [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/base/allocator/partition_allocator/partition_alloc_unittest.cc [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/base/debug/stack_trace_unittest.cc [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/base/files/file_path_watcher_unittest.cc [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/base/files/file_util_unittest.cc [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/base/memory/platform_shared_memory_region_unittest.cc [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/base/path_service_unittest.cc [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/base/posix/eintr_wrapper.h [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/base/process/kill.h [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/base/process/process_metrics.h [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/base/process/process_unittest.cc [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/base/rand_util.h [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/base/synchronization/condition_variable_unittest.cc [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/base/test/test_shared_memory_util.cc [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/chrome/browser/media/webrtc/webrtc_event_log_manager_unittest.cc [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/chrome/browser/media/webrtc/webrtc_event_log_uploader_impl_unittest.cc [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/components/services/pdf_compositor/public/cpp/pdf_compositor_service_factory.cc [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/content/public/test/browser_test_base.cc [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/content/public/utility/utility_thread.h [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/content/renderer/renderer_blink_platform_impl.cc [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/content/utility/utility_blink_platform_with_sandbox_support_impl.cc [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/content/utility/utility_blink_platform_with_sandbox_support_impl.h [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/content/utility/utility_thread_impl.cc [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/content/utility/utility_thread_impl.h [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/headless/lib/headless_macros.h [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/mojo/core/core.cc [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/mojo/core/shared_buffer_dispatcher.cc [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/net/disk_cache/disk_cache_perftest.cc [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/net/disk_cache/simple/simple_backend_impl.cc [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/net/url_request/url_request_unittest.cc [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/services/service_manager/embedder/main.cc [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/sql/connection_unittest.cc [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/storage/browser/fileapi/dragged_file_util_unittest.cc [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/storage/browser/fileapi/local_file_util_unittest.cc [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/third_party/blink/renderer/platform/scheduler/util/thread_cpu_throttler.cc [modify] https://crrev.com/3553913abdd97123c3937277f26cba44e6eacacf/ui/gl/gl_fence.cc
Comment 1 by bugdroid1@chromium.org
, Jul 9