New issue
Advanced search Search tips

Issue 854720 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

TabManagerTestWithTwoTabs.TabProactiveDiscardAndFocusBeforeFreezeCompletes failed on Windows

Project Member Reported by fdoray@google.com, Jun 20 2018

Issue description

Failing log: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/69853

[ RUN      ] TabManagerTestWithTwoTabs.TabProactiveDiscardAndFocusBeforeFreezeCompletes
[3656:3164:0620/103737.557:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062
[3656:3256:0620/103737.728:WARNING:chrome_browser_main_win.cc(653)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=TabManagerTestWithTwoTabs.TabProactiveDiscardAndFocusBeforeFreezeCompletes --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir5316_1969\results5316_14355\test_results.xml" --test-launcher-summary-output="e:\b\s\w\io61xlv1\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir5316_1969\d5316_20415" --disable-offline-auto-reload --enable-blink-features=PageLifecycle --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=45 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=TestFeatureForBrowserTest1 --disable-features=NetworkPrediction,SpeculativePreconnect,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank
[7076:6836:0620/103738.415:INFO:GrGLInterface.cpp(542)] ../../third_party/skia/src/gpu/gl/GrGLInterface.cpp:542 GrGLInterface::validate() failed.
[7076:6836:0620/103738.446:INFO:media_foundation_video_encode_accelerator_win.cc(353)] Windows versions earlier than 8 are not supported.
[3656:3256:0620/103738.511:WARNING:gaia_auth_fetcher.cc(902)] Could not reach Google Accounts servers: errno -11
[3656:3256:0620/103739.603:WARNING:gaia_auth_fetcher.cc(902)] Could not reach Google Accounts servers: errno -11
[1808:5448:0620/103740.074:ERROR:render_process_impl.cc(209)] WebFrame LEAKED 1 TIMES
[3656:3256:0620/103743.585:WARNING:gaia_auth_fetcher.cc(902)] Could not reach Google Accounts servers: errno -102
[3656:3256:0620/103743.762:FATAL:tab_lifecycle_unit.cc(792)] Check failed: false.
Backtrace:
	base::debug::StackTrace::StackTrace [0x73A49AA6+102]
	base::debug::StackTrace::StackTrace [0x73A48B4B+27]
	logging::LogMessage::~LogMessage [0x73AA8104+148]
	resource_coordinator::TabLifecycleUnitSource::TabLifecycleUnit::OnLifecycleUnitStateChanged [0x06E23E55+245]
	resource_coordinator::LifecycleUnitBase::SetState [0x08A48D91+97]
	resource_coordinator::TabLifecycleUnitSource::TabLifecycleUnit::FinishDiscard [0x06E21638+1384]
	base::internal::FunctorTraits<void (__thiscall resource_coordinator::TabLifecycleUnitSource::TabLifecycleUnit::*)(enum resource_coordinator::DiscardReason),void>::Invoke<void (__thiscall resource_coordinator::TabLifecycleUnitSource::TabLifecycleUnit::*)(e [0x06E2464D+77]
	base::internal::InvokeHelper<0,void>::MakeItSo<void (__thiscall resource_coordinator::TabLifecycleUnitSource::TabLifecycleUnit::*const &)(enum resource_coordinator::DiscardReason),resource_coordinator::TabLifecycleUnitSource::TabLifecycleUnit *,enum resou [0x06E2450C+124]
	base::internal::Invoker<base::internal::BindState<void (__thiscall resource_coordinator::TabLifecycleUnitSource::TabLifecycleUnit::*)(enum resource_coordinator::DiscardReason),base::internal::UnretainedWrapper<resource_coordinator::TabLifecycleUnitSource: [0x06E2447A+122]
	base::internal::Invoker<base::internal::BindState<void (__thiscall resource_coordinator::TabLifecycleUnitSource::TabLifecycleUnit::*)(enum resource_coordinator::DiscardReason),base::internal::UnretainedWrapper<resource_coordinator::TabLifecycleUnitSource: [0x06E242CF+63]
	base::RepeatingCallback<void __cdecl(void)>::Run [0x739E6711+49]
	base::Timer::RunScheduledTask [0x73C8B293+371]
	base::BaseTimerTaskInternal::Run [0x73C8B0AC+60]
	??$Invoke@P8BaseTimerTaskInternal@base@@AEXXZPAV12@$$V@?$FunctorTraits@P8BaseTimerTaskInternal@base@@AEXXZX@internal@base@@SAXP8BaseTimerTaskInternal@2@AEXXZ$$QAPAV32@@Z [0x73C8B62C+28]
	base::internal::InvokeHelper<0,void>::MakeItSo<void (__thiscall base::BaseTimerTaskInternal::*)(void),base::BaseTimerTaskInternal *> [0x73C8B58F+79]
	base::internal::Invoker<base::internal::BindState<void (__thiscall base::BaseTimerTaskInternal::*)(void),base::internal::OwnedWrapper<base::BaseTimerTaskInternal> >,void __cdecl(void)>::RunImpl<void (__thiscall base::BaseTimerTaskInternal::*)(void),std::t [0x73C8B4E5+85]
	base::internal::Invoker<base::internal::BindState<void (__thiscall base::BaseTimerTaskInternal::*)(void),base::internal::OwnedWrapper<base::BaseTimerTaskInternal> >,void __cdecl(void)>::RunOnce [0x73C8B3A4+84]
	base::OnceCallback<void __cdecl(void)>::Run [0x739EC720+80]
	base::debug::TaskAnnotator::RunTask [0x73A4E113+1075]
	base::internal::IncomingTaskQueue::RunTask [0x73AD8858+232]
	base::MessageLoop::RunTask [0x73AE27BB+875]
	base::MessageLoop::DeferOrRunPendingTask [0x73AE2F79+73]
	base::MessageLoop::DoDelayedWork [0x73AE34A7+519]
	base::MessagePumpForUI::DoRunLoop [0x73AEEAA0+128]
	base::MessagePumpWin::Run [0x73AEDFA9+185]
	base::MessageLoop::Run [0x73AE20C6+486]
	base::RunLoop::Run [0x73BA8948+488]
	resource_coordinator::TabManagerTest::GetLifecycleUnitAt [0x01500631+465]
	resource_coordinator::TabManagerTestWithTwoTabs_TabProactiveDiscardAndFocusBeforeFreezeCompletes_Test::RunTestOnMainThread [0x01503793+1187]
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x05243F84+804]
	??$Invoke@P8BrowserTestBase@content@@AEXXZPAV12@$$V@?$FunctorTraits@P8BrowserTestBase@content@@AEXXZX@internal@base@@SAXP8BrowserTestBase@content@@AEXXZ$$QAPAV34@@Z [0x05245EAC+28]
	base::internal::InvokeHelper<0,void>::MakeItSo<void (__thiscall content::BrowserTestBase::*const &)(void),content::BrowserTestBase *> [0x05245DEF+79]
	base::internal::Invoker<base::internal::BindState<void (__thiscall content::BrowserTestBase::*)(void),base::internal::UnretainedWrapper<content::BrowserTestBase> >,void __cdecl(void)>::RunImpl<void (__thiscall content::BrowserTestBase::*const &)(void),std [0x05245D85+85]
	base::internal::Invoker<base::internal::BindState<void (__thiscall content::BrowserTestBase::*)(void),base::internal::UnretainedWrapper<content::BrowserTestBase> >,void __cdecl(void)>::Run [0x05245C7F+63]
	base::RepeatingCallback<void __cdecl(void)>::Run [0x00ABE022+50]
	ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x0731B47F+7071]
	ChromeBrowserMainParts::PreMainMessageLoopRun [0x0731985E+398]
	content::BrowserMainLoop::PreMainMessageLoopRun [0x5FCC1506+342]
	??$Invoke@P8BrowserMainLoop@content@@AEHXZPAV12@$$V@?$FunctorTraits@P8BrowserMainLoop@content@@AEHXZX@internal@base@@SAHP8BrowserMainLoop@content@@AEHXZ$$QAPAV34@@Z [0x5FCCB97C+28]
	base::internal::InvokeHelper<0,int>::MakeItSo<int (__thiscall content::BrowserMainLoop::*const &)(void),content::BrowserMainLoop *> [0x5FCCB8AF+79]
	base::internal::Invoker<base::internal::BindState<int (__thiscall content::BrowserMainLoop::*)(void),base::internal::UnretainedWrapper<content::BrowserMainLoop> >,int __cdecl(void)>::RunImpl<int (__thiscall content::BrowserMainLoop::*const &)(void),std::t [0x5FCCB845+85]
	base::internal::Invoker<base::internal::BindState<int (__thiscall content::BrowserMainLoop::*)(void),base::internal::UnretainedWrapper<content::BrowserMainLoop> >,int __cdecl(void)>::Run [0x5FCCB6FF+63]
	base::RepeatingCallback<int __cdecl(void)>::Run [0x6061CB92+50]
	content::StartupTaskRunner::RunAllTasksNow [0x60F52A69+137]
	content::BrowserMainLoop::CreateStartupTasks [0x5FCBF215+1493]
	content::BrowserMainRunnerImpl::Initialize [0x5FCD18FF+1983]
	content::BrowserMain [0x5FCB8A09+265]
	content::RunBrowserProcessMain [0x625BAA7D+365]
	content::ContentMainRunnerImpl::Run [0x625BBC37+791]
	content::ContentServiceManagerMainDelegate::RunEmbedderProcess [0x625B8311+33]
	service_manager::Main [0x5C8C372A+1418]
	content::ContentMain [0x625BA88C+92]
	content::BrowserTestBase::SetUp [0x05243941+2913]
	InProcessBrowserTest::SetUp [0x050FCAE6+2086]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x02B737BB+107]
	testing::Test::Run [0x02B736AF+111]
	testing::TestInfo::Run [0x02B7413B+251]
	testing::TestCase::Run [0x02B74C3D+269]
	testing::internal::UnitTestImpl::RunAllTests [0x02B7D50B+715]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x02B7D210+112]
	testing::UnitTest::Run [0x02B7D059+297]
	RUN_ALL_TESTS [0x05134E3F+15]
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0d3e9a77cd2e32cd58eefb54a7ca02d5cf9b42e

commit e0d3e9a77cd2e32cd58eefb54a7ca02d5cf9b42e
Author: Francois Doray <fdoray@chromium.org>
Date: Wed Jun 20 20:30:28 2018

Disable TabManagerTestWithTwoTabs.TabProactiveDiscardAndFocusBeforeFreezeCompletes.

TBR=sebmarchand@chromium.org

Bug:  854720 
Change-Id: Id715bfae60ed08a7edd4b59e9814efc1b25d7fb5
Reviewed-on: https://chromium-review.googlesource.com/1108495
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568989}
[modify] https://crrev.com/e0d3e9a77cd2e32cd58eefb54a7ca02d5cf9b42e/chrome/browser/resource_coordinator/tab_manager_browsertest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cab8ab45c85fb1517dd50cc22cfd7ceb8bfde14e

commit cab8ab45c85fb1517dd50cc22cfd7ceb8bfde14e
Author: Francois Doray <fdoray@chromium.org>
Date: Wed Jun 20 21:00:39 2018

RC: Stop freeze timer when PENDING_DISCARD TabLifecycleUnit is focused.

When a PENDING_DISCARD TabLifecycleUnit is focused, its state is
transitioned to PENDING_FREEZE, to indicate that the renderer is
processing a freeze request, but that no discard should happen when
it's done.

With this CL, we also stop the freeze timer to ensure that
FinishDiscard() isn't called when the renderer tells the browser that
the freeze request has been processed.

Bug:  854720 
Change-Id: Iea98644ea1e9b056eb05bbf5ae6da870c324064c
Reviewed-on: https://chromium-review.googlesource.com/1108376
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569009}
[modify] https://crrev.com/cab8ab45c85fb1517dd50cc22cfd7ceb8bfde14e/chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
[modify] https://crrev.com/cab8ab45c85fb1517dd50cc22cfd7ceb8bfde14e/chrome/browser/resource_coordinator/tab_manager_browsertest.cc

Comment 3 by fdoray@chromium.org, Jun 21 2018

Status: Fixed (was: Assigned)

Sign in to add a comment