New issue
Advanced search Search tips

Issue 854704 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 7
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 847992



Sign in to add a comment

Make ash use BrowserNonClientFrameViewAsh for --mash

Project Member Reported by sky@chromium.org, Jun 20 2018

Issue description

For --mash we use BrowserNonClientFrameViewMash. BrowserNonClientFrameViewMash was forked from BrowserNonClientFrameViewAsh a long time ago, and as a result is seriously SERIOUSLY out of date. I think we should try to use BrowserNonClientFrameViewAsh in --mash as well. This may mean more conditionals in BrowserNonClientFrameAsh, but this seems more sustainable in the near term.

I suspect this is a fair amount of work, and I wouldn't try addressing immersive just yet. We may want to create a bunch of smaller bugs that are blocking this.
 

Comment 1 by est...@chromium.org, Jun 22 2018

Took a look today, here's an outline of my plan:

1. recombine the two classes with judicious use of conditionals. This won't guarantee we keep the Mash frame in sync with the classic frame, because someone could still change just one of the conditionals. However, it will prevent divergence on some changes particular such as how the client edge is drawn[1]. This also makes it easier to see where there are differences between Mash and classic.

2. Whittle down the differences.
 - Move hosted app frame header code into its own FrameHeader class in Ash (resolving TODO(alancutter))
 - Move back_button_ into ash::HeaderView
 - Use ash::HeaderView in classic to eliminate frame_caption_button_container_, frame_header_, back_button_, etc.
 - Clean up whatever differences remain.

[1] changed for Classic but not Mash here: https://codereview.chromium.org/1685763004
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a005bd3d713e4fbb06685f455e09c847e83498fb

commit a005bd3d713e4fbb06685f455e09c847e83498fb
Author: Evan Stade <estade@chromium.org>
Date: Fri Jun 22 22:24:00 2018

Merge BrowserNonClientFrameViewAsh/Mash.

Bug:  854704 
Change-Id: I0900ccb649bb7c8b814b8b138bc52439d26bbb67
Reviewed-on: https://chromium-review.googlesource.com/1111651
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569807}
[modify] https://crrev.com/a005bd3d713e4fbb06685f455e09c847e83498fb/ash/frame/caption_buttons/frame_caption_button_container_view.cc
[modify] https://crrev.com/a005bd3d713e4fbb06685f455e09c847e83498fb/ash/frame/caption_buttons/frame_caption_button_container_view.h
[modify] https://crrev.com/a005bd3d713e4fbb06685f455e09c847e83498fb/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/a005bd3d713e4fbb06685f455e09c847e83498fb/chrome/browser/ui/views/frame/DEPS
[modify] https://crrev.com/a005bd3d713e4fbb06685f455e09c847e83498fb/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/a005bd3d713e4fbb06685f455e09c847e83498fb/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h
[modify] https://crrev.com/a005bd3d713e4fbb06685f455e09c847e83498fb/chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_chromeos.cc
[delete] https://crrev.com/046d91b8bb93d735bc6871c774039d9a41988fa3/chrome/browser/ui/views/frame/browser_non_client_frame_view_mash.cc
[delete] https://crrev.com/046d91b8bb93d735bc6871c774039d9a41988fa3/chrome/browser/ui/views/frame/browser_non_client_frame_view_mash.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a7f4578ee399aa4a24d9cf084021eb4a2ed823b

commit 2a7f4578ee399aa4a24d9cf084021eb4a2ed823b
Author: Evan Stade <estade@chromium.org>
Date: Tue Jun 26 20:51:56 2018

Mash browser frame: use default frame for V1/packaged apps.

Extension apps already use DefaultFrameHeader and packaged apps
should do the same (and already do in classic Ash).

This patch also fixes layout of non-app, non-tabbed browser windows,
i.e. popup windows, in Mash.

Bug:  854704 
Change-Id: Id80a06cbd6d0489efd0761421909c9b4ec06c263
Reviewed-on: https://chromium-review.googlesource.com/1115344
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570523}
[modify] https://crrev.com/2a7f4578ee399aa4a24d9cf084021eb4a2ed823b/chrome/browser/ui/views/frame/browser_frame_mash.cc
[modify] https://crrev.com/2a7f4578ee399aa4a24d9cf084021eb4a2ed823b/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/2a7f4578ee399aa4a24d9cf084021eb4a2ed823b/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e90c93d58fafafcf3aa3256e414aa86a729442be

commit e90c93d58fafafcf3aa3256e414aa86a729442be
Author: Evan Stade <estade@chromium.org>
Date: Tue Jun 26 21:27:28 2018

Mash: Support back button for v1 apps

Test: chrome --enable-features=Mash --ash-enable-v1-app-back-button

Bug:  854704 
Change-Id: I37217f18900c9f93c94ea7148de900f3d14564d5
Reviewed-on: https://chromium-review.googlesource.com/1114202
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570536}
[modify] https://crrev.com/e90c93d58fafafcf3aa3256e414aa86a729442be/ash/frame/caption_buttons/frame_caption_button_container_view.cc
[modify] https://crrev.com/e90c93d58fafafcf3aa3256e414aa86a729442be/ash/frame/custom_frame_view_ash.h
[modify] https://crrev.com/e90c93d58fafafcf3aa3256e414aa86a729442be/ash/frame/header_view.cc
[modify] https://crrev.com/e90c93d58fafafcf3aa3256e414aa86a729442be/ash/frame/header_view.h
[modify] https://crrev.com/e90c93d58fafafcf3aa3256e414aa86a729442be/ash/public/cpp/mus_property_mirror_ash.cc
[modify] https://crrev.com/e90c93d58fafafcf3aa3256e414aa86a729442be/ash/public/cpp/window_properties.cc
[modify] https://crrev.com/e90c93d58fafafcf3aa3256e414aa86a729442be/ash/public/cpp/window_properties.h
[modify] https://crrev.com/e90c93d58fafafcf3aa3256e414aa86a729442be/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/e90c93d58fafafcf3aa3256e414aa86a729442be/services/ui/public/interfaces/window_manager.mojom

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f93deb685709cc2d29074e84cafe6182ed79f82

commit 5f93deb685709cc2d29074e84cafe6182ed79f82
Author: Evan Stade <estade@chromium.org>
Date: Fri Jun 29 21:54:13 2018

Mash browser frame: port hosted app support and frame colors for
hosted apps.

The caption buttons are provided by Ash, but we need the menu button
and content settings icons to be added by Chrome (there are lots of
Chrome dependencies there). Thus most changes are in the browser side
frame view, as opposed to //ash/frame/.

Test app: https://airhorner.com/ (app menu > Install Airhorn)

Bug:  854704 
Change-Id: Ibf65e49b0e6f4698a727cfcd17e2d78bb4a719af
Reviewed-on: https://chromium-review.googlesource.com/1116069
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571655}
[modify] https://crrev.com/5f93deb685709cc2d29074e84cafe6182ed79f82/ash/frame/caption_buttons/frame_caption_button.h
[modify] https://crrev.com/5f93deb685709cc2d29074e84cafe6182ed79f82/ash/frame/default_frame_header.cc
[modify] https://crrev.com/5f93deb685709cc2d29074e84cafe6182ed79f82/ash/frame/default_frame_header.h
[modify] https://crrev.com/5f93deb685709cc2d29074e84cafe6182ed79f82/ash/frame/frame_header.cc
[modify] https://crrev.com/5f93deb685709cc2d29074e84cafe6182ed79f82/ash/frame/frame_header.h
[modify] https://crrev.com/5f93deb685709cc2d29074e84cafe6182ed79f82/ash/public/cpp/mus_property_mirror_ash.cc
[modify] https://crrev.com/5f93deb685709cc2d29074e84cafe6182ed79f82/ash/public/cpp/window_properties.cc
[modify] https://crrev.com/5f93deb685709cc2d29074e84cafe6182ed79f82/ash/public/cpp/window_properties.h
[modify] https://crrev.com/5f93deb685709cc2d29074e84cafe6182ed79f82/ash/public/interfaces/window_properties.mojom
[modify] https://crrev.com/5f93deb685709cc2d29074e84cafe6182ed79f82/ash/window_manager.cc
[modify] https://crrev.com/5f93deb685709cc2d29074e84cafe6182ed79f82/ash/wm/non_client_frame_controller.cc
[modify] https://crrev.com/5f93deb685709cc2d29074e84cafe6182ed79f82/ash/wm/non_client_frame_controller.h
[modify] https://crrev.com/5f93deb685709cc2d29074e84cafe6182ed79f82/chrome/browser/ui/views/frame/browser_frame_mash.cc
[modify] https://crrev.com/5f93deb685709cc2d29074e84cafe6182ed79f82/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/5f93deb685709cc2d29074e84cafe6182ed79f82/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/575a70a76428251f9b7b1c4c5a3a3f2738b48dc4

commit 575a70a76428251f9b7b1c4c5a3a3f2738b48dc4
Author: Thomas Anderson <thomasanderson@chromium.org>
Date: Fri Jun 29 23:44:24 2018

Revert "Mash browser frame: fix rendering in single tab mode"

This reverts commit da08ce6d117f9871923fa8658c3820c5d6b91684.

Reason for revert: Suspected cause of build failure on linux-chromeos-dbg:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/6567

obj/chrome/browser/ui/libui.a(obj/chrome/browser/ui/ui/browser_non_client_frame_view_ash.o):browser_non_client_frame_view_ash.cc:function BrowserNonClientFrameViewAsh::UpdateFrameColors(): error: undefined reference to 'BrowserFrameAsh::kMdWebUiFrameColor'

Original change's description:
> Mash browser frame: fix rendering in single tab mode
> 
> Single tab mode makes the frame the same color as a tab.
> 
> Bug:  854704 
> Change-Id: I0d7e790d977858e4ae2942f5f93009c7774bf423
> Reviewed-on: https://chromium-review.googlesource.com/1118977
> Commit-Queue: Evan Stade <estade@chromium.org>
> Reviewed-by: Michael Wasserman <msw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571690}

TBR=msw@chromium.org,estade@chromium.org

Change-Id: I0484532a4c9f1ef0914c2b1ba52cd563d341ff3e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  854704 
Reviewed-on: https://chromium-review.googlesource.com/1121496
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571709}
[modify] https://crrev.com/575a70a76428251f9b7b1c4c5a3a3f2738b48dc4/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/575a70a76428251f9b7b1c4c5a3a3f2738b48dc4/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/575a70a76428251f9b7b1c4c5a3a3f2738b48dc4/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h
[modify] https://crrev.com/575a70a76428251f9b7b1c4c5a3a3f2738b48dc4/chrome/browser/ui/views/tabs/tab_strip.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c7e022ba9fcdb5075e4dedee0dadc86651c41d3

commit 8c7e022ba9fcdb5075e4dedee0dadc86651c41d3
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Sat Jun 30 00:12:08 2018

Revert "Mash browser frame: port hosted app support and frame colors for hosted apps."

This reverts commit 5f93deb685709cc2d29074e84cafe6182ed79f82.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 571655 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzVmOTNkZWI2ODU3MDljYzJkMjkwNzRlODRjYWZlNjE4MmVkNzlmODIM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/6567

Sample Failed Step: compile

Original change's description:
> Mash browser frame: port hosted app support and frame colors for
> hosted apps.
> 
> The caption buttons are provided by Ash, but we need the menu button
> and content settings icons to be added by Chrome (there are lots of
> Chrome dependencies there). Thus most changes are in the browser side
> frame view, as opposed to //ash/frame/.
> 
> Test app: https://airhorner.com/ (app menu > Install Airhorn)
> 
> Bug:  854704 
> Change-Id: Ibf65e49b0e6f4698a727cfcd17e2d78bb4a719af
> Reviewed-on: https://chromium-review.googlesource.com/1116069
> Reviewed-by: Michael Wasserman <msw@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Commit-Queue: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571655}

Change-Id: I8fe91584aa587fad078d418248a4cbd8cf9a7475
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  854704 
Reviewed-on: https://chromium-review.googlesource.com/1121556
Cr-Commit-Position: refs/heads/master@{#571711}
[modify] https://crrev.com/8c7e022ba9fcdb5075e4dedee0dadc86651c41d3/ash/frame/caption_buttons/frame_caption_button.h
[modify] https://crrev.com/8c7e022ba9fcdb5075e4dedee0dadc86651c41d3/ash/frame/default_frame_header.cc
[modify] https://crrev.com/8c7e022ba9fcdb5075e4dedee0dadc86651c41d3/ash/frame/default_frame_header.h
[modify] https://crrev.com/8c7e022ba9fcdb5075e4dedee0dadc86651c41d3/ash/frame/frame_header.cc
[modify] https://crrev.com/8c7e022ba9fcdb5075e4dedee0dadc86651c41d3/ash/frame/frame_header.h
[modify] https://crrev.com/8c7e022ba9fcdb5075e4dedee0dadc86651c41d3/ash/public/cpp/mus_property_mirror_ash.cc
[modify] https://crrev.com/8c7e022ba9fcdb5075e4dedee0dadc86651c41d3/ash/public/cpp/window_properties.cc
[modify] https://crrev.com/8c7e022ba9fcdb5075e4dedee0dadc86651c41d3/ash/public/cpp/window_properties.h
[modify] https://crrev.com/8c7e022ba9fcdb5075e4dedee0dadc86651c41d3/ash/public/interfaces/window_properties.mojom
[modify] https://crrev.com/8c7e022ba9fcdb5075e4dedee0dadc86651c41d3/ash/window_manager.cc
[modify] https://crrev.com/8c7e022ba9fcdb5075e4dedee0dadc86651c41d3/ash/wm/non_client_frame_controller.cc
[modify] https://crrev.com/8c7e022ba9fcdb5075e4dedee0dadc86651c41d3/ash/wm/non_client_frame_controller.h
[modify] https://crrev.com/8c7e022ba9fcdb5075e4dedee0dadc86651c41d3/chrome/browser/ui/views/frame/browser_frame_mash.cc
[modify] https://crrev.com/8c7e022ba9fcdb5075e4dedee0dadc86651c41d3/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/8c7e022ba9fcdb5075e4dedee0dadc86651c41d3/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef37136f805f4172ff68727982ef36b129726508

commit ef37136f805f4172ff68727982ef36b129726508
Author: Evan Stade <estade@chromium.org>
Date: Mon Jul 02 23:47:49 2018

Reland "Mash browser frame: port hosted app support and frame colors for hosted apps."

This relands commit 5f93deb685709cc2d29074e84cafe6182ed79f82

Mash browser frame: port hosted app support and frame colors for
hosted apps.

The caption buttons are provided by Ash, but we need the menu button
and content settings icons to be added by Chrome (there are lots of
Chrome dependencies there). Thus most changes are in the browser side
frame view, as opposed to //ash/frame/.

Test app: https://airhorner.com/ (app menu > Install Airhorn)

TBR=msw@chromium.org,jamescook@chromium.org,tsepez@chromium.org

Bug:  854704 
Change-Id: I7fc4402d6df7515db3e7d7e00d70ceaf0038d779
Reviewed-on: https://chromium-review.googlesource.com/1121961
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572046}
[modify] https://crrev.com/ef37136f805f4172ff68727982ef36b129726508/ash/frame/caption_buttons/frame_caption_button.h
[modify] https://crrev.com/ef37136f805f4172ff68727982ef36b129726508/ash/frame/default_frame_header.cc
[modify] https://crrev.com/ef37136f805f4172ff68727982ef36b129726508/ash/frame/default_frame_header.h
[modify] https://crrev.com/ef37136f805f4172ff68727982ef36b129726508/ash/frame/frame_header.cc
[modify] https://crrev.com/ef37136f805f4172ff68727982ef36b129726508/ash/frame/frame_header.h
[modify] https://crrev.com/ef37136f805f4172ff68727982ef36b129726508/ash/public/cpp/mus_property_mirror_ash.cc
[modify] https://crrev.com/ef37136f805f4172ff68727982ef36b129726508/ash/public/cpp/window_properties.cc
[modify] https://crrev.com/ef37136f805f4172ff68727982ef36b129726508/ash/public/cpp/window_properties.h
[modify] https://crrev.com/ef37136f805f4172ff68727982ef36b129726508/ash/public/interfaces/window_properties.mojom
[modify] https://crrev.com/ef37136f805f4172ff68727982ef36b129726508/ash/window_manager.cc
[modify] https://crrev.com/ef37136f805f4172ff68727982ef36b129726508/ash/wm/non_client_frame_controller.cc
[modify] https://crrev.com/ef37136f805f4172ff68727982ef36b129726508/ash/wm/non_client_frame_controller.h
[modify] https://crrev.com/ef37136f805f4172ff68727982ef36b129726508/chrome/browser/ui/views/frame/browser_frame_ash.h
[modify] https://crrev.com/ef37136f805f4172ff68727982ef36b129726508/chrome/browser/ui/views/frame/browser_frame_mash.cc
[modify] https://crrev.com/ef37136f805f4172ff68727982ef36b129726508/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/ef37136f805f4172ff68727982ef36b129726508/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a85c30b0e9587affeeae45db8c1764a87989c9f

commit 6a85c30b0e9587affeeae45db8c1764a87989c9f
Author: Evan Stade <estade@chromium.org>
Date: Wed Jul 04 02:14:21 2018

Reland: "Mash browser frame: fix rendering in single tab mode"

This relands da08ce6d117f9871923fa8658c3820c5d6b91684

Single tab mode makes the frame the same color as a tab.

There's no change from the original patchset, which was reverted
to make it easier to revert the actual culprit 5f93deb685709cc2d

TBR=msw@chromium.org

Bug:  854704 
Change-Id: I1fb8eeb5ae736501f79676668b146d1c8ac32193
Reviewed-on: https://chromium-review.googlesource.com/1125512
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572448}
[modify] https://crrev.com/6a85c30b0e9587affeeae45db8c1764a87989c9f/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/6a85c30b0e9587affeeae45db8c1764a87989c9f/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/6a85c30b0e9587affeeae45db8c1764a87989c9f/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h
[modify] https://crrev.com/6a85c30b0e9587affeeae45db8c1764a87989c9f/chrome/browser/ui/views/tabs/tab_strip.cc

Blocking: 847992
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/948c826b9dcbb359870b3a3363ed678534ac5749

commit 948c826b9dcbb359870b3a3363ed678534ac5749
Author: Evan Stade <estade@chromium.org>
Date: Tue Jul 17 17:58:44 2018

Chrome OS: Fix window header animation for overview mode.

Before this change, there was a flash of white above every non-browser
window when entering overview mode, because the overview code was using
the kTopViewColor property to get the frame's color. That property was
only set correctly for certain browser windows (not, e.g., v1 apps)
and for some others it was set to always use the inactive frame color.

Instead, use kFrame{Active,Inactive}ColorKey which should be set for all
windows and also has a reasonable default.

Related to linked bug because it reduces the number of differences
between ash and classic browser windows.

Bug:  854704 
Change-Id: Ie86223cb97509f860069895fefa1054b48080ed9
Reviewed-on: https://chromium-review.googlesource.com/1119356
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575714}
[modify] https://crrev.com/948c826b9dcbb359870b3a3363ed678534ac5749/ash/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/948c826b9dcbb359870b3a3363ed678534ac5749/ash/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/948c826b9dcbb359870b3a3363ed678534ac5749/ash/wm/overview/window_selector_item.cc
[modify] https://crrev.com/948c826b9dcbb359870b3a3363ed678534ac5749/ash/wm/panels/panel_frame_view.cc
[modify] https://crrev.com/948c826b9dcbb359870b3a3363ed678534ac5749/ash/wm/panels/panel_frame_view.h
[modify] https://crrev.com/948c826b9dcbb359870b3a3363ed678534ac5749/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/948c826b9dcbb359870b3a3363ed678534ac5749/ui/aura/client/aura_constants.cc
[modify] https://crrev.com/948c826b9dcbb359870b3a3363ed678534ac5749/ui/aura/client/aura_constants.h

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba4e96e7c894648e18cc9bfe921c16a97b58bca5

commit ba4e96e7c894648e18cc9bfe921c16a97b58bca5
Author: Evan Stade <estade@chromium.org>
Date: Wed Jul 18 23:47:43 2018

Simplify overview mode for ash browser frames

- don't toggle visibility of back button and window icon, which only exist
  for non-tabbed windows. Those windows hide the entire header in overview
  and don't need to explicitly hide individual components.
- get rid of the settings window icon workaround that prevented setting the
  window icon on settings windows (designed to preserve the override from
  SettingsWindowObserver). All window icon logic is located in BrowserView.

Bug:  854704 
Change-Id: I84106b7a4a1f8f78c8fc76a9be682422d41c9a45
Reviewed-on: https://chromium-review.googlesource.com/1140520
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576260}
[modify] https://crrev.com/ba4e96e7c894648e18cc9bfe921c16a97b58bca5/chrome/browser/ui/ash/launcher/settings_window_observer.cc
[modify] https://crrev.com/ba4e96e7c894648e18cc9bfe921c16a97b58bca5/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/ba4e96e7c894648e18cc9bfe921c16a97b58bca5/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h
[modify] https://crrev.com/ba4e96e7c894648e18cc9bfe921c16a97b58bca5/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/ba4e96e7c894648e18cc9bfe921c16a97b58bca5/ui/aura/client/aura_constants.cc
[modify] https://crrev.com/ba4e96e7c894648e18cc9bfe921c16a97b58bca5/ui/aura/client/aura_constants.h

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5162497f13ece5288f40c4a13c5bb0a3403e11c1

commit 5162497f13ece5288f40c4a13c5bb0a3403e11c1
Author: Evan Stade <estade@chromium.org>
Date: Thu Jul 19 18:43:41 2018

OopAsh: Fix appearance of browser header when toggling between states
(restored and maximized)

It would be nice if the window's size change and state change were
synced up. As it is, the size change comes through first and causes a
layout which doesn't take into account the new state. Then, the state
change comes through but doesn't cause a layout to occur. This patch
makes the OopAsh frame do an explicit layout due to state changes.

Bug:  854704 
Change-Id: Ieab1883cebab64873e0e1e88da85d8de54af8e7f
Reviewed-on: https://chromium-review.googlesource.com/1142453
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576574}
[modify] https://crrev.com/5162497f13ece5288f40c4a13c5bb0a3403e11c1/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/5162497f13ece5288f40c4a13c5bb0a3403e11c1/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96fb2db7b34d6095f3f5b7f08c04e1cd9d4f5808

commit 96fb2db7b34d6095f3f5b7f08c04e1cd9d4f5808
Author: Evan Stade <estade@chromium.org>
Date: Mon Jul 23 18:28:08 2018

OopAsh: Begin enabling browser frame browser_tests

Bug:  854704 
Change-Id: I00c25bee75cb69d36af1ab022847cf08100f5e88
Reviewed-on: https://chromium-review.googlesource.com/1144640
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577204}
[modify] https://crrev.com/96fb2db7b34d6095f3f5b7f08c04e1cd9d4f5808/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/96fb2db7b34d6095f3f5b7f08c04e1cd9d4f5808/testing/buildbot/filters/mash.browser_tests.filter

Project Member

Comment 16 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c852c98761107a6be1069eb29beb6b9e4f60009

commit 9c852c98761107a6be1069eb29beb6b9e4f60009
Author: Evan Stade <estade@chromium.org>
Date: Tue Jul 24 17:53:19 2018

OopAsh: make Ash share the bounds of the caption buttons with clients.

This avoids some recalculations (chances for bugs) in
BrowserNonClientFrameViewAsh. The bounds are horizontally inverted
(i.e. they are relative to the top right of the frame) to minimize
the number of times they need to be updated when resizing the window
and the likelihood of ephemeral inconsistencies.

Also fix the registered type of kRestoreBoundsOverrideKey. Since it was
registered as a primitive, the address itself would get copied across
processes.

Bug:  854704 
Change-Id: Iedd4eb4dfb2172f7a9ba66bbc542db33633aaf77
Reviewed-on: https://chromium-review.googlesource.com/1144058
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577604}
[modify] https://crrev.com/9c852c98761107a6be1069eb29beb6b9e4f60009/ash/frame/frame_header.cc
[modify] https://crrev.com/9c852c98761107a6be1069eb29beb6b9e4f60009/ash/public/cpp/window_properties.cc
[modify] https://crrev.com/9c852c98761107a6be1069eb29beb6b9e4f60009/ash/public/cpp/window_properties.h
[modify] https://crrev.com/9c852c98761107a6be1069eb29beb6b9e4f60009/ash/public/interfaces/window_properties.mojom
[modify] https://crrev.com/9c852c98761107a6be1069eb29beb6b9e4f60009/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc

Project Member

Comment 17 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e975a3e7a531508aa41248f4ae21a11c7ed667d7

commit e975a3e7a531508aa41248f4ae21a11c7ed667d7
Author: Evan Stade <estade@chromium.org>
Date: Wed Jul 25 16:09:15 2018

OopAsh: share frame hit test implementation with classic Ash.

This cl places the responsibility of determing the hit test component
on individual Views, which gets rid of some ash/ dependencies and
reduces code duplication.

The one behavioral change in classic Ash is that padding parts of
the hosted app button container (e.g. the medium sized space between
the menu button and the minimize button) are now HTCAPTION, i.e. can
be used to drag the frame rather than do nothing.

Bug:  854704 
Change-Id: Ia290a42652a9acbf9b4b01c86941e8d2bdcadc48
Reviewed-on: https://chromium-review.googlesource.com/1145545
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577915}
[modify] https://crrev.com/e975a3e7a531508aa41248f4ae21a11c7ed667d7/ash/BUILD.gn
[modify] https://crrev.com/e975a3e7a531508aa41248f4ae21a11c7ed667d7/ash/frame/caption_buttons/frame_back_button.cc
[modify] https://crrev.com/e975a3e7a531508aa41248f4ae21a11c7ed667d7/ash/frame/caption_buttons/frame_caption_button.cc
[modify] https://crrev.com/e975a3e7a531508aa41248f4ae21a11c7ed667d7/ash/frame/caption_buttons/frame_caption_button.h
[modify] https://crrev.com/e975a3e7a531508aa41248f4ae21a11c7ed667d7/ash/frame/caption_buttons/frame_caption_button_container_view.cc
[modify] https://crrev.com/e975a3e7a531508aa41248f4ae21a11c7ed667d7/ash/frame/caption_buttons/frame_caption_button_container_view.h
[modify] https://crrev.com/e975a3e7a531508aa41248f4ae21a11c7ed667d7/ash/frame/caption_buttons/frame_size_button.cc
[modify] https://crrev.com/e975a3e7a531508aa41248f4ae21a11c7ed667d7/ash/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/e975a3e7a531508aa41248f4ae21a11c7ed667d7/ash/frame/custom_frame_view_ash_unittest.cc
[delete] https://crrev.com/2d43ed4c8d17b477714a42226aa9a80a39d38d3c/ash/frame/frame_border_hit_test.cc
[delete] https://crrev.com/2d43ed4c8d17b477714a42226aa9a80a39d38d3c/ash/frame/frame_border_hit_test.h
[modify] https://crrev.com/e975a3e7a531508aa41248f4ae21a11c7ed667d7/ash/public/cpp/BUILD.gn
[add] https://crrev.com/e975a3e7a531508aa41248f4ae21a11c7ed667d7/ash/public/cpp/frame_border_hit_test.cc
[add] https://crrev.com/e975a3e7a531508aa41248f4ae21a11c7ed667d7/ash/public/cpp/frame_border_hit_test.h
[modify] https://crrev.com/e975a3e7a531508aa41248f4ae21a11c7ed667d7/ash/wm/panels/panel_frame_view.cc
[modify] https://crrev.com/e975a3e7a531508aa41248f4ae21a11c7ed667d7/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/e975a3e7a531508aa41248f4ae21a11c7ed667d7/chrome/browser/ui/views/frame/hosted_app_button_container.cc
[modify] https://crrev.com/e975a3e7a531508aa41248f4ae21a11c7ed667d7/chrome/browser/ui/views/frame/hosted_app_menu_button.cc
[modify] https://crrev.com/e975a3e7a531508aa41248f4ae21a11c7ed667d7/testing/buildbot/filters/mash.browser_tests.filter
[modify] https://crrev.com/e975a3e7a531508aa41248f4ae21a11c7ed667d7/ui/views/view_properties.cc
[modify] https://crrev.com/e975a3e7a531508aa41248f4ae21a11c7ed667d7/ui/views/view_properties.h

Project Member

Comment 18 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72fe6d0fadf94b430ff2e18b3a8626cb4a9237c7

commit 72fe6d0fadf94b430ff2e18b3a8626cb4a9237c7
Author: Evan Stade <estade@chromium.org>
Date: Wed Jul 25 18:10:17 2018

OopAsh: fix and enable some more frame-related browser tests.

Bug:  854704 
Change-Id: If201f772e7afeb646d619b7917f0f1e134e9edca
Reviewed-on: https://chromium-review.googlesource.com/1149154
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577974}
[modify] https://crrev.com/72fe6d0fadf94b430ff2e18b3a8626cb4a9237c7/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/72fe6d0fadf94b430ff2e18b3a8626cb4a9237c7/testing/buildbot/filters/mash.browser_tests.filter

Project Member

Comment 19 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37a7f684254b706415a8c61679977b26e34d84ea

commit 37a7f684254b706415a8c61679977b26e34d84ea
Author: Daniel Bratell <bratell@opera.com>
Date: Wed Jul 25 19:07:27 2018

Fix link error for ViewProperties for Mac (!aura)

TBR=sky@chromium.org

Bug:  854704 

Change-Id: I58fded8d7ad7c764e55ac435940ff0656a1d2aa5
Reviewed-on: https://chromium-review.googlesource.com/1150235
Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#578006}
[modify] https://crrev.com/37a7f684254b706415a8c61679977b26e34d84ea/ui/views/view_properties.cc

Project Member

Comment 21 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95b5463e248e7aac8ae50b055edf4c89d8010fcb

commit 95b5463e248e7aac8ae50b055edf4c89d8010fcb
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Wed Aug 01 02:16:49 2018

Revert "OopAsh: port/enable some more browser tests."

This reverts commit 1edc413fd90233f702cf2894f645fa638966646b.

Reason for revert: the test added by this (CustomFrameViewAshTest.ActiveStateOfButtonMatchesWidget)
has been super flaky on linux-chromeos-rel right after this was added.

Some builds:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/11360
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/11361
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/11363

Original change's description:
> OopAsh: port/enable some more browser tests.
> 
> Bug:  854704 
> Change-Id: Ic3dcef42f108beb02a398302f3ecd70dd72c0f2d
> Reviewed-on: https://chromium-review.googlesource.com/1153777
> Commit-Queue: Evan Stade <estade@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579476}

TBR=sky@chromium.org,estade@chromium.org

Change-Id: I33d224561923905ceaabe67a57cec6c78c0b104c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  854704 
Reviewed-on: https://chromium-review.googlesource.com/1157844
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579670}
[modify] https://crrev.com/95b5463e248e7aac8ae50b055edf4c89d8010fcb/ash/frame/custom_frame_view_ash_unittest.cc
[modify] https://crrev.com/95b5463e248e7aac8ae50b055edf4c89d8010fcb/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h
[modify] https://crrev.com/95b5463e248e7aac8ae50b055edf4c89d8010fcb/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/95b5463e248e7aac8ae50b055edf4c89d8010fcb/testing/buildbot/filters/mash.browser_tests.filter

Project Member

Comment 22 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d689b3355eccb93a97a70c00ea37abf24388951b

commit d689b3355eccb93a97a70c00ea37abf24388951b
Author: Evan Stade <estade@chromium.org>
Date: Thu Aug 02 01:17:22 2018

OopAsh: make browser frame respond to changes in tablet mode.

Tested via --ash-debug-shortcuts and Ctrl+Alt+Shift+T

Bug:  854704 ,760811
Change-Id: Ia3aadae89fcd50d95a84fdf7d275e97bc2e9e2e9
Reviewed-on: https://chromium-review.googlesource.com/1152230
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580021}
[modify] https://crrev.com/d689b3355eccb93a97a70c00ea37abf24388951b/ash/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/d689b3355eccb93a97a70c00ea37abf24388951b/ash/public/interfaces/shell_test_api.mojom
[modify] https://crrev.com/d689b3355eccb93a97a70c00ea37abf24388951b/ash/shell_test_api.cc
[modify] https://crrev.com/d689b3355eccb93a97a70c00ea37abf24388951b/ash/shell_test_api.h
[modify] https://crrev.com/d689b3355eccb93a97a70c00ea37abf24388951b/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/d689b3355eccb93a97a70c00ea37abf24388951b/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc
[modify] https://crrev.com/d689b3355eccb93a97a70c00ea37abf24388951b/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc
[modify] https://crrev.com/d689b3355eccb93a97a70c00ea37abf24388951b/testing/buildbot/filters/mash.browser_tests.filter

Project Member

Comment 23 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c948168648360bdffb159637d02a9cf5fd8e8fc1

commit c948168648360bdffb159637d02a9cf5fd8e8fc1
Author: Evan Stade <estade@chromium.org>
Date: Thu Aug 02 17:30:43 2018

Reland "OopAsh: port/enable some more browser tests."

This re-lands commit 1edc413fd90233f702cf2894f645fa638966646b.

Original change is ps1, fix is in latest patchset.

Original change's description:
> OopAsh: port/enable some more browser tests.
>
> Bug:  854704 
> Change-Id: Ic3dcef42f108beb02a398302f3ecd70dd72c0f2d
> Reviewed-on: https://chromium-review.googlesource.com/1153777
> Commit-Queue: Evan Stade <estade@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579476}

Bug:  854704 
Change-Id: I0a264093a2d90b00bcdc5a0e2e71a9d391336fea
Reviewed-on: https://chromium-review.googlesource.com/1159086
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580229}
[modify] https://crrev.com/c948168648360bdffb159637d02a9cf5fd8e8fc1/ash/frame/custom_frame_view_ash_unittest.cc
[modify] https://crrev.com/c948168648360bdffb159637d02a9cf5fd8e8fc1/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h
[modify] https://crrev.com/c948168648360bdffb159637d02a9cf5fd8e8fc1/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/c948168648360bdffb159637d02a9cf5fd8e8fc1/testing/buildbot/filters/mash.browser_tests.filter

Project Member

Comment 24 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63e6d37570c2c3f1c62296173bd21c2a2df39df6

commit 63e6d37570c2c3f1c62296173bd21c2a2df39df6
Author: Evan Stade <estade@chromium.org>
Date: Thu Aug 09 22:26:42 2018

OopAsh: update and enable a browser test for the frame.

Bug:  854704 
Change-Id: I13acab5de5dc2565f12c02b2cb23b2d41d4331f8
Reviewed-on: https://chromium-review.googlesource.com/1167744
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581920}
[modify] https://crrev.com/63e6d37570c2c3f1c62296173bd21c2a2df39df6/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/63e6d37570c2c3f1c62296173bd21c2a2df39df6/testing/buildbot/filters/mash.browser_tests.filter

Project Member

Comment 25 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d30a68227a635fb7ab0f3a98f7280ed0ce189503

commit d30a68227a635fb7ab0f3a98f7280ed0ce189503
Author: Evan Stade <estade@chromium.org>
Date: Fri Aug 10 21:14:47 2018

Ash: Port two browser frame tests to Ash.

One of them lives on in browser because the Ash version trips a dcheck
when run in classic Ash mode.

Bug:  854704 
Change-Id: I7822cc088c255b8c16c91cb1b5304c5e2b974115
Reviewed-on: https://chromium-review.googlesource.com/1170127
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582333}
[modify] https://crrev.com/d30a68227a635fb7ab0f3a98f7280ed0ce189503/ash/frame/non_client_frame_view_ash.h
[modify] https://crrev.com/d30a68227a635fb7ab0f3a98f7280ed0ce189503/ash/frame/non_client_frame_view_ash_unittest.cc
[modify] https://crrev.com/d30a68227a635fb7ab0f3a98f7280ed0ce189503/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/d30a68227a635fb7ab0f3a98f7280ed0ce189503/testing/buildbot/filters/mash.browser_tests.filter

Project Member

Comment 26 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fab555d3998a26570fec630ab63408612d6c70e

commit 7fab555d3998a26570fec630ab63408612d6c70e
Author: Evan Stade <estade@chromium.org>
Date: Tue Aug 14 22:22:14 2018

OopAsh: fix/enable another frame-related browser test.

Bug:  854704 
Change-Id: If3326d678e53b3ccff89bcd2ba98d02a0611b605
Reviewed-on: https://chromium-review.googlesource.com/1172739
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583057}
[modify] https://crrev.com/7fab555d3998a26570fec630ab63408612d6c70e/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/7fab555d3998a26570fec630ab63408612d6c70e/testing/buildbot/filters/mash.browser_tests.filter

Project Member

Comment 27 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36e308a43893423fa3774dec66577e97933c1de0

commit 36e308a43893423fa3774dec66577e97933c1de0
Author: Evan Stade <estade@chromium.org>
Date: Thu Aug 16 17:04:53 2018

Mash: enable HostedAppNonClientFrameViewAshTest.*

Only needed one small tweak to BrowserNonClientFrameViewAsh.

Bug:  854704 
Change-Id: Ib6536580a84bf4035279512f2e6c22c31d4cdabd
Reviewed-on: https://chromium-review.googlesource.com/1176427
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583700}
[modify] https://crrev.com/36e308a43893423fa3774dec66577e97933c1de0/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/36e308a43893423fa3774dec66577e97933c1de0/testing/buildbot/filters/mash.browser_tests.filter

Project Member

Comment 31 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/426a298ecc132678a8ffba330095acbf71dce876

commit 426a298ecc132678a8ffba330095acbf71dce876
Author: Evan Stade <estade@chromium.org>
Date: Fri Oct 19 22:42:07 2018

Mash: Fix browser split view mode and browser tests.

Bug:  854704 
Change-Id: Ic04c377547f74c4866b46fd91f7f3fc0b075fdd4
Reviewed-on: https://chromium-review.googlesource.com/c/1290139
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601330}
[modify] https://crrev.com/426a298ecc132678a8ffba330095acbf71dce876/ash/public/interfaces/shell_test_api.mojom
[modify] https://crrev.com/426a298ecc132678a8ffba330095acbf71dce876/ash/shell_test_api.cc
[modify] https://crrev.com/426a298ecc132678a8ffba330095acbf71dce876/ash/shell_test_api.h
[modify] https://crrev.com/426a298ecc132678a8ffba330095acbf71dce876/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/426a298ecc132678a8ffba330095acbf71dce876/ash/wm/splitview/split_view_controller.h
[modify] https://crrev.com/426a298ecc132678a8ffba330095acbf71dce876/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/426a298ecc132678a8ffba330095acbf71dce876/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/426a298ecc132678a8ffba330095acbf71dce876/testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter
[modify] https://crrev.com/426a298ecc132678a8ffba330095acbf71dce876/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter

Status: Fixed (was: Assigned)

Sign in to add a comment